• pthier's avatar
    Reland "[sparkplug] Change bytecode offset mapping and introduce iterator." · 2966c896
    pthier authored
    This is a reland of a8b61ef5
    
    The main reason for the revert was not related to this CL and was fixed
    with https://crrev.com/c/2739646
    In addition debug output in d8.test.verifySourcePositions was removed
    due to TSAN complaints.
    
    Original change's description:
    > [sparkplug] Change bytecode offset mapping and introduce iterator.
    >
    > Previously, we recorded pairs of (bytecode offset, sparkplug pc) to
    > create a mapping of bytecode offset <-> sparkplug pc.
    > These pairs were only recorded after builtin/runtime calls.
    > In preparation for deoptimizing to Sparkplug, we need a more precise
    > mapping.
    > With this CL, we record positions for every bytecode. Instead of storing
    > a pair of (bytecode offset, sparkplug pc), we store only the pc,
    > calculating the bytecode offset from the index in the mapping table.
    > For easier use an iterator to access the mapping is introduced.
    >
    > Drive-by: Reduce sampling interval in cpu-profiler cctest to get rid of
    flaky failures.
    >
    > Bug: v8:11420, v8:11429
    > Change-Id: I36a9171f43a574eb67880cbca6cf9ff7ab291e60
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2720189
    > Reviewed-by: Victor Gomes <victorgomes@chromium.org>
    > Reviewed-by: Camillo Bruni <cbruni@chromium.org>
    > Auto-Submit: Patrick Thier <pthier@chromium.org>
    > Commit-Queue: Patrick Thier <pthier@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#73186}
    >
    > Change-Id: I9ab4cb60da002ef130f8a21ad10ba69e2826a7b6
    
    Change-Id: I9ab4cb60da002ef130f8a21ad10ba69e2826a7b6
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2745335Reviewed-by: 's avatarVictor Gomes <victorgomes@chromium.org>
    Reviewed-by: 's avatarCamillo Bruni <cbruni@chromium.org>
    Commit-Queue: Patrick Thier <pthier@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#73293}
    2966c896
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
baseline Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...