• Milad Farazmand's avatar
    PPC/s390: PPC/s390: Reland^2 "[runtime] Move Context::native_context to the map" · 26539972
    Milad Farazmand authored
    Port 36ab93d8
    
    Original Commit Message:
    
        Port 3cad6bf5
    
        Original Commit Message:
    
            This is a reland of c7c47c68.
    
            This makes TSAN happy in addition to:
    
            Previously I presumed that the context read from a frame in the profiler was
            a valid context. Turns out that on non-intel we're not guaranteed that the
            frame is properly set up. In the case we looked at, the profiler took a
            sample right before writing the frame marker indicating a builtin frame,
            causing the "context" pointer from that frame to be a bytecode array. Since
            we'll read random garbage on the stack as a possible context pointer, I made
            the code reading the native context from it a little more defensive.
    
            Original change's description:
            > [runtime] Move Context::native_context to the map
            >
            > Remove the native context slot from contexts by making context maps
            > native-context-specific. Now we require 2 loads to go from a context to the
            > native context, but we have 1 field fewer to store when creating contexts.
            >
            > Change-Id: I3c0d7c50c94060c4129db684f46a567de6f30e8d
            > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1859629
            > Commit-Queue: Toon Verwaest <verwaest@chromium.org>
            > Reviewed-by: Igor Sheludko <ishell@chromium.org>
            > Reviewed-by: Peter Marshall <petermarshall@chromium.org>
            > Reviewed-by: Maya Lekova <mslekova@chromium.org>
            > Reviewed-by: Georg Neis <neis@chromium.org>
            > Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
            > Reviewed-by: Toon Verwaest <verwaest@chromium.org>
            > Cr-Commit-Position: refs/heads/master@{#64296}
    
    R=miladfar@ca.ibm.com, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com
    BUG=
    LOG=N
    
    Change-Id: I996a1f5096b34fc556918752224ff51889f0a5ce
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1879443Reviewed-by: 's avatarJunliang Yan <jyan@ca.ibm.com>
    Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com>
    Cr-Commit-Position: refs/heads/master@{#64570}
    26539972
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...