• Dominik Inführ's avatar
    Reland "[heap] String::MakeThin can get away without NotifyObjectLayoutChange" · 255db1d2
    Dominik Inführ authored
    This is a reland of 6e621f84
    
    Original change's description:
    > [heap] String::MakeThin can get away without NotifyObjectLayoutChange
    >
    > String::MakeThin doesn't need to invoke NotifyObjectLayoutChange because
    > ThinString will only introduce tagged values and hence will not
    > overwrite recorded slots with untagged values.
    >
    > Bug: v8:10315
    > Change-Id: Iaff9c06cef763462eb57bf3debc5183ae8db6fa0
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2448792
    > Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
    > Commit-Queue: Dominik Inführ <dinfuehr@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#70321}
    
    The reland fixes the failures by first updating actual and only then
    updating the map with a release store. This ensures that concurrent
    markers will observe the pointer when visiting a ThinString and not some
    stale data from before String::MakeThin.
    
    Bug: v8:10315
    Change-Id: I42db7ba9f44a48c920c997bf1258c561f3dd9bcc
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2450066
    Commit-Queue: Dominik Inführ <dinfuehr@chromium.org>
    Reviewed-by: 's avatarUlan Degenbaev <ulan@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#70346}
    255db1d2
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...