• Ulan Degenbaev's avatar
    [heap, deserializer] Restore marking invariant for deserialized maps · 250ba28a
    Ulan Degenbaev authored
    when black allocation is on.
    
    The scenario:
    1) Incremental marking is off.
    2) Partial deserialization starts and calls Heap::ReserveSpace.
    2) ReserveSpace creates (white) reservations in old space.
    3) ReserveSpace allocates map placeholders. One of these allocations
    starts incremental marking, which starts black allocation (currently
    when concurrent marking is on). Subsequent maps are black allocated.
    4) ReserveSpace succeeds without triggering a GC.
    5) Deserialization continues. Some maps are black. Note that
    deserialization emits only old->new write barriers and skips
    marking write barriers.
    6) Deserialization finishes and re-visits the black allocated
    reservations and large object. This misses black allocated maps.
    7) There is black->white descriptor array pointer in one of these map.
    
    BUG=chromium:723600
    
    Change-Id: Ifffe46f22a7d7dbc5cff2e882190234fcc722ccb
    Reviewed-on: https://chromium-review.googlesource.com/581187
    Commit-Queue: Ulan Degenbaev <ulan@chromium.org>
    Reviewed-by: 's avatarMichael Lippautz <mlippautz@chromium.org>
    Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#46816}
    250ba28a
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...