• Alexey Kozyatinskiy's avatar
    debug-evaluate: do not return JSGlobalObject instead of JSGlobalProxy · 215608f4
    Alexey Kozyatinskiy authored
    DebugEvaluate contains code since 2009 that bypasses JSGlobalProxy and
    returns JSGlobalObject when result of expression is global proxy.
    This behavior may be dangerous:
    - JSGlobalObject does not perform security checks,
    - some parts of V8 code do not ready for JSGlobalObject, e.g.,
      SetHashAndUpdateProperties function will crash on DCHECK if we will
      try to store JSGlobalObject to map.
    
    At the same time it looks like there is no any valid use case for it.
    
    R=yangguo@chromium.org
    
    Bug: none
    Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
    Change-Id: Ib0e35d5ae9ef47318c866e44c5c6856e34ed05a5
    Reviewed-on: https://chromium-review.googlesource.com/1198764Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
    Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#55550}
    215608f4
Name
Last commit
Last update
..
arm Loading commit data...
arm64 Loading commit data...
ia32 Loading commit data...
mips Loading commit data...
mips64 Loading commit data...
ppc Loading commit data...
s390 Loading commit data...
x64 Loading commit data...
OWNERS Loading commit data...
debug-coverage.cc Loading commit data...
debug-coverage.h Loading commit data...
debug-evaluate.cc Loading commit data...
debug-evaluate.h Loading commit data...
debug-frames.cc Loading commit data...
debug-frames.h Loading commit data...
debug-interface.h Loading commit data...
debug-scope-iterator.cc Loading commit data...
debug-scope-iterator.h Loading commit data...
debug-scopes.cc Loading commit data...
debug-scopes.h Loading commit data...
debug-stack-trace-iterator.cc Loading commit data...
debug-stack-trace-iterator.h Loading commit data...
debug-type-profile.cc Loading commit data...
debug-type-profile.h Loading commit data...
debug.cc Loading commit data...
debug.h Loading commit data...
interface-types.h Loading commit data...
liveedit.cc Loading commit data...
liveedit.h Loading commit data...