• Clemens Backes's avatar
    Fail earlier on FreePages · 205fb295
    Clemens Backes authored
    {FreePages} is never expected to fail, and each caller wraps the call in
    a CHECK macro. In order to learn more about failures, this CL moves the
    CHECK inside of {::FreePages}, to fail whenever the {PageAllocator}
    fails to free pages.
    
    As a next step, I'll audit our {PageAllocator} implementations to ensure
    that none of them return {false} for {FreePages}. Note that this is
    already the case for the gin platform (chromium).
    
    R=mlippautz@chromium.org
    
    Bug: v8:12656, chromium:1299735
    Change-Id: Ib61be6cc8da0110ead2db1ad005728bd061e0243
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3484321Reviewed-by: 's avatarMichael Lippautz <mlippautz@chromium.org>
    Reviewed-by: 's avatarLeszek Swirski <leszeks@chromium.org>
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#79248}
    205fb295
Name
Last commit
Last update
..
benchmarks Loading commit data...
bigint Loading commit data...
cctest Loading commit data...
common Loading commit data...
debugger Loading commit data...
debugging Loading commit data...
fuzzer Loading commit data...
fuzzilli Loading commit data...
inspector Loading commit data...
intl Loading commit data...
js-perf-test Loading commit data...
memory Loading commit data...
message Loading commit data...
mjsunit Loading commit data...
mkgrokdump Loading commit data...
mozilla Loading commit data...
test262 Loading commit data...
torque Loading commit data...
unittests Loading commit data...
wasm-api-tests Loading commit data...
wasm-js Loading commit data...
wasm-spec-tests Loading commit data...
webkit Loading commit data...
BUILD.gn Loading commit data...
OWNERS Loading commit data...