• Clemens Hammacher's avatar
    [wasm] Store WasmEngine in NativeModule · 69546692
    Clemens Hammacher authored
    The {CompilationState} currently stores the {WasmEngine}, while the
    {NativeModule} only stores the {WasmCodeManager}. From a high-level
    view, this does not make much sense. The {NativeModule} belongs to
    exactly one {WasmEngine}, so that link should be stored there. We can
    then get to the {WasmCodeManager} from the {WasmEngine}.
    
    This change requires a refactoring of the {WasmCodeManagerTest} which
    created {WasmCodeManager}s independent of the {Isolate} and the
    {WasmEngine}. This is not supported any more.
    Note that in production, each {WasmEngine} owns exactly one
    {WasmCodeManager} and one {WasmMemoryTracker}, so testing that a
    {WasmMemoryTracker} can be shared by several {WasmCodeManager}s didn't
    make sense in the first place.
    
    R=mstarzinger@chromium.org
    
    Bug: v8:8217
    Change-Id: I582e698be35f97dbd38bf6e12eb7f8ee4fc1f0f2
    Reviewed-on: https://chromium-review.googlesource.com/c/1297960
    Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
    Reviewed-by: 's avatarMichael Starzinger <mstarzinger@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#56992}
    69546692
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
assembler Loading commit data...
base Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
heap Loading commit data...
interpreter Loading commit data...
libplatform Loading commit data...
objects Loading commit data...
parser Loading commit data...
torque Loading commit data...
wasm Loading commit data...
zone Loading commit data...
BUILD.gn Loading commit data...
DEPS Loading commit data...
allocation-unittest.cc Loading commit data...
background-compile-task-unittest.cc Loading commit data...
bigint-unittest.cc Loading commit data...
cancelable-tasks-unittest.cc Loading commit data...
char-predicates-unittest.cc Loading commit data...
code-stub-assembler-unittest.cc Loading commit data...
code-stub-assembler-unittest.h Loading commit data...
counters-unittest.cc Loading commit data...
detachable-vector-unittest.cc Loading commit data...
eh-frame-iterator-unittest.cc Loading commit data...
eh-frame-writer-unittest.cc Loading commit data...
locked-queue-unittest.cc Loading commit data...
object-unittest.cc Loading commit data...
register-configuration-unittest.cc Loading commit data...
run-all-unittests.cc Loading commit data...
source-position-table-unittest.cc Loading commit data...
strings-storage-unittest.cc Loading commit data...
test-helpers.cc Loading commit data...
test-helpers.h Loading commit data...
test-utils.cc Loading commit data...
test-utils.h Loading commit data...
testcfg.py Loading commit data...
unicode-unittest.cc Loading commit data...
unittests.status Loading commit data...
utils-unittest.cc Loading commit data...
value-serializer-unittest.cc Loading commit data...