• Maya Lekova's avatar
    Revert "[parser] Inline byte scope data into PreparseData object" · 1ec1712c
    Maya Lekova authored
    This reverts commit e2d44ede.
    
    Reason for revert: Breaks GC stress tests - https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux64%20GC%20Stress%20-%20custom%20snapshot/23527
    
    Original change's description:
    > [parser] Inline byte scope data into PreparseData object
    > 
    > Each PreparseData object had at least one pointer to a PodArray for its
    > serialized scope data. These objects usually have only tens of bytes of
    > payload. By inlining the byte data we save 3 words per PreparseData object.
    > This optimization saves 140KB of data on cnn.com.
    > 
    > 
    > - Store data_length and inner_length as int32 saving a words on 64bit
    > - Inline store byte data into PreparseData
    > - OnHeapConsumedPreparseData directly uses the PreparseData object
    > - get_inner, set_inner no longer allow Null sentinels
    > 
    > Change-Id: I1f62154d05ea2f98a6574efa738b32a8a84319d5
    > Reviewed-on: https://chromium-review.googlesource.com/c/1406673
    > Reviewed-by: Leszek Swirski <leszeks@chromium.org>
    > Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
    > Commit-Queue: Camillo Bruni <cbruni@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#58751}
    
    TBR=ulan@chromium.org,cbruni@chromium.org,leszeks@chromium.org
    
    Change-Id: I39d92ee7bd2864e1b0c3a8fed4a11b68b3e14d58
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Reviewed-on: https://chromium-review.googlesource.com/c/1407073Reviewed-by: 's avatarMaya Lekova <mslekova@chromium.org>
    Commit-Queue: Maya Lekova <mslekova@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#58753}
    1ec1712c
Name
Last commit
Last update
..
benchmarks Loading commit data...
cctest Loading commit data...
common Loading commit data...
debugger Loading commit data...
fuzzer Loading commit data...
inspector Loading commit data...
intl Loading commit data...
js-perf-test Loading commit data...
memory Loading commit data...
message Loading commit data...
mjsunit Loading commit data...
mkgrokdump Loading commit data...
mozilla Loading commit data...
preparser Loading commit data...
test262 Loading commit data...
torque Loading commit data...
unittests Loading commit data...
wasm-js Loading commit data...
wasm-spec-tests Loading commit data...
webkit Loading commit data...
BUILD.gn Loading commit data...