• Peter Marshall's avatar
    [inspector] Add a test for const declaration and side effects · 73f4ac62
    Peter Marshall authored
    Add a test that does the same thing the devtools-frontend does when
    evaluating console inputs.
    
    1) Declare a const variable with throwOnSideEffect=true. This should
    throw.
    2) Declare the same const variable with throwOnSideEffect=false.
    This should successfully declare the variable.
    
    Previously it could be the case that even though we threw in 1), the
    variable would fail to be initialized in 2) with a re-declaration
    error.
    
    Bug: chromium:1043151
    Change-Id: I1a6126b518f7bb3788c39b9f8e3adb8850aa962a
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2016587
    Commit-Queue: Peter Marshall <petermarshall@chromium.org>
    Reviewed-by: 's avatarSimon Zünd <szuend@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#65991}
    73f4ac62
Name
Last commit
Last update
..
console Loading commit data...
cpu-profiler Loading commit data...
debugger Loading commit data...
heap-profiler Loading commit data...
runtime Loading commit data...
runtime-call-stats Loading commit data...
sessions Loading commit data...
type-profiler Loading commit data...
BUILD.gn Loading commit data...
DEPS Loading commit data...
OWNERS Loading commit data...
inspector-test.cc Loading commit data...
inspector.status Loading commit data...
isolate-data.cc Loading commit data...
isolate-data.h Loading commit data...
json-parse-expected.txt Loading commit data...
json-parse.js Loading commit data...
print-method-not-found-expected.txt Loading commit data...
print-method-not-found.js Loading commit data...
protocol-test.js Loading commit data...
task-runner.cc Loading commit data...
task-runner.h Loading commit data...
testcfg.py Loading commit data...