• Sathya Gunasekaran's avatar
    [parser] Improve error when using import decl in a script · e101b9c0
    Sathya Gunasekaran authored
    Perform a best-effort check for module context and provide an
    appropriate error.
    
    As seen from the import-blah-script.js test, we could have invalid
    import expressions in a script context that could result in an error
    saying "Cannot use import statement outside a module" which isn't
    the ideal error because the error is an incorrect import
    expression.
    
    But, when the developer changes to a module context, the
    correct error is thrown.
    
    To fix this, we'd have to refactor and call ParseImportDeclaration,
    and then throw an appropriate error, which seems like a lot of
    overhead for not enough gain.
    
    Bug: v8:9392, v8:6513
    Change-Id: I520ebb490fff4d95743a7c751d4095db9a35d41b
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1675948Reviewed-by: 's avatarMythri Alle <mythria@chromium.org>
    Reviewed-by: 's avatarGeorg Neis <neis@chromium.org>
    Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#62358}
    e101b9c0
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
OWNERS Loading commit data...