• Simon Zünd's avatar
    Reland^3 "[torque] Throw exception instead of aborting if something goes wrong" · 2d8f2e86
    Simon Zünd authored
    This is a reland of ffe6940f
    
    The UBSan issue is fixed with https://crrev.com/c/1566511
    
    TBR=tebbi@chromium.org
    
    Original change's description:
    > Reland^2 "[torque] Throw exception instead of aborting if something goes wrong"
    >
    > This is a reland of 251d1623
    >
    > The reland fixes ASAN component builds by adding RTTI build config to both
    > torque executables. Big thanks to sigurds for finding the fix.
    >
    > Original change's description:
    > > Reland "[torque] Throw exception instead of aborting if something goes wrong"
    > >
    > > This is a reland of 3bd49f9b
    > >
    > > The issue on the windows bot is apparently a compiler bug in MSVC related to
    > > move construction. The fix seems to be to change the order of the fields in
    > > "JsonParseResult" (go figure).
    > >
    > > Drive-by-change: Fix LS on windows by emitting correct line endings and
    > > enabling exceptions for the LS executable as well.
    > >
    > > Original change's description:
    > > > [torque] Throw exception instead of aborting if something goes wrong
    > > >
    > > > This CL enables exceptions for the Torque compiler and Torque language
    > > > server. Instead of aborting when something goes wrong during
    > > > compilation, a TorqueError is thrown, containing the error message
    > > > and a source position. The compiler executable still prints the error
    > > > and aborts, while the language server will pass this information
    > > > along to the client (not included in this CL).
    > > >
    > > > R=danno@chromium.org
    > > >
    > > > Bug: v8:8880
    > > > Change-Id: Iad83c46fb6a91c1babbc0ae7dbd94fbe4e7f1663
    > > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1526003
    > > > Reviewed-by: Daniel Clifford <danno@chromium.org>
    > > > Commit-Queue: Simon Zünd <szuend@chromium.org>
    > > > Cr-Commit-Position: refs/heads/master@{#60512}
    > >
    > > Bug: v8:8880
    > > Change-Id: I00e6591bbb4c516dd7540a7e27196853bc637f11
    > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1545995
    > > Reviewed-by: Tobias Tebbi <tebbi@chromium.org>
    > > Commit-Queue: Simon Zünd <szuend@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#60736}
    >
    > Bug: v8:8880
    > Change-Id: Iba198d771169283e83e74324f27aa9e90b8d8975
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1563770
    > Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
    > Commit-Queue: Simon Zünd <szuend@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#60804}
    
    Bug: v8:8880
    Change-Id: I5b7e40ad27bff8f7bfa22240954c2cb75083ad82
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1564065Reviewed-by: 's avatarSimon Zünd <szuend@chromium.org>
    Commit-Queue: Simon Zünd <szuend@chromium.org>
    Auto-Submit: Simon Zünd <szuend@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#60860}
    2d8f2e86
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
assembler Loading commit data...
base Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
heap Loading commit data...
interpreter Loading commit data...
libplatform Loading commit data...
parser Loading commit data...
regress Loading commit data...
torque Loading commit data...
wasm Loading commit data...
zone Loading commit data...
BUILD.gn Loading commit data...
DEPS Loading commit data...
allocation-unittest.cc Loading commit data...
background-compile-task-unittest.cc Loading commit data...
bigint-unittest.cc Loading commit data...
cancelable-tasks-unittest.cc Loading commit data...
char-predicates-unittest.cc Loading commit data...
code-stub-assembler-unittest.cc Loading commit data...
code-stub-assembler-unittest.h Loading commit data...
conversions-unittest.cc Loading commit data...
counters-unittest.cc Loading commit data...
detachable-vector-unittest.cc Loading commit data...
eh-frame-iterator-unittest.cc Loading commit data...
eh-frame-writer-unittest.cc Loading commit data...
locked-queue-unittest.cc Loading commit data...
microtask-queue-unittest.cc Loading commit data...
object-unittest.cc Loading commit data...
register-configuration-unittest.cc Loading commit data...
run-all-unittests.cc Loading commit data...
source-position-table-unittest.cc Loading commit data...
strings-storage-unittest.cc Loading commit data...
test-helpers.cc Loading commit data...
test-helpers.h Loading commit data...
test-utils.cc Loading commit data...
test-utils.h Loading commit data...
testcfg.py Loading commit data...
unicode-unittest.cc Loading commit data...
unittests.status Loading commit data...
utils-unittest.cc Loading commit data...
value-serializer-unittest.cc Loading commit data...