• Ng Zhi An's avatar
    [wasm-simd] Optimize codegen when shift is constant · 19be4913
    Ng Zhi An authored
    Define a macro in code-generator-x64 to help identify cases when the
    shift value is an immediate/constant. In those cases we can directly
    emit the shifts without any masking, since the instruction selector
    would have modulo-ed the shift value. We also don't need any temporaries
    in this case.
    
    This is only x64 codegen, optimizations for other archs will come in
    future patches (and will probably look very similar to this).
    
    The current test case passes the shifts as an immediate, so we add a new
    path that loads the shift value from memory, thereby exercising the
    slower path of non-immediate shift value.
    
    Bug: v8:10115
    Change-Id: Iaf13d81595714882a8f5418734e031b8bc654af3
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2026067Reviewed-by: 's avatarDeepti Gandluri <gdeepti@chromium.org>
    Commit-Queue: Zhi An Ng <zhin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#66074}
    19be4913
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...