• Omer Katz's avatar
    cppgc: Eliminate marking boilerplate · 18ff5660
    Omer Katz authored
    Starting marking required Creating a Marker and calling StartMarking.
    StartMarking should always have been called immediately after creating
    the marker.
    Since markers are not persisted between GC (a marker exists only while
    marking is in progress), it makes sense to start marking implicitly when
    a marker is created.
    
    Calling StartMarking in MarkerBase ctor is inadvisable since subclasses
    might still to initialize fields.
    Using MarkerFactory instead guarantees that StartMarking is always
    called immediately after creating a Marker.
    
    Bug: chromium:1056170
    Change-Id: Icbf11afd848e1618c204ca6bf951600b3ae9fef2
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2375199
    Commit-Queue: Omer Katz <omerkatz@chromium.org>
    Reviewed-by: 's avatarUlan Degenbaev <ulan@chromium.org>
    Reviewed-by: 's avatarAnton Bikineev <bikineev@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#69601}
    18ff5660
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...