• Samuel Groß's avatar
    [base] Abort on unexpected failures in OS::SetPermissions · 18159ba6
    Samuel Groß authored
    It is expected that changing page permissions can fail due to the system
    running out of memory. However, any other failure is unexpected and
    likely indicates a bug in the caller, such as changing the permissions
    of an invalid memory region. To allow distinguishing between these
    unexpected failures and expected OOM failures, this CL adds CHECKs into
    the low-level memory management routines to abort when an unexpected
    failure occurs.
    
    Similar logic could later be added to other low-level memory management
    routines that can legitimately fail due to OOM as well.
    
    Bug: chromium:1320126
    Change-Id: I3de6f4b2aed8962c91770b81382df34384584501
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3610445
    Commit-Queue: Samuel Groß <saelo@chromium.org>
    Reviewed-by: 's avatarVictor Gomes <victorgomes@chromium.org>
    Reviewed-by: 's avatarMichael Lippautz <mlippautz@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#80245}
    18159ba6
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
baseline Loading commit data...
bigint Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
maglev Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sandbox Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
temporal Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
web-snapshot Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...