• Clemens Backes's avatar
    Reland "[wasm] Disallow late enabling of trap handlers" · 15efe5a6
    Clemens Backes authored
    This is a reland of bcb0a7c5.
    Data races detected by TSan are fixed by using (relaxed) atomic
    updates.
    
    Original change's description:
    > [wasm] Disallow late enabling of trap handlers
    >
    > It's dangerous if trap handlers are enabled after we already used the
    > information whether they are enabled or not.
    > This CL checks for such misbehaviour by remembering whether
    > {IsTrapHandlerEnabled} was already called, and disallowing
    > {EnableTrapHandler} afterwards. Also, calling {EnableTrapHandler}
    > multiple times is disallowed now.
    >
    > The trap handler tests are changed to only enable trap handlers once,
    > and to do that before allocating wasm memory or generating code.
    >
    > R=ahaas@chromium.org
    >
    > Bug: v8:11017
    > Change-Id: Ib2256bb8435efd914c12769cedd4a0051052aeef
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2494935
    > Reviewed-by: Andreas Haas <ahaas@chromium.org>
    > Commit-Queue: Clemens Backes <clemensb@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#70750}
    
    Bug: v8:11017
    Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_rel_ng
    Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_isolates_rel_ng
    Change-Id: I24299c433ffa3ce31e2aac12134dc03f30609da2
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2498683
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Reviewed-by: 's avatarAndreas Haas <ahaas@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#70761}
    15efe5a6
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
assembler Loading commit data...
base Loading commit data...
codegen Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
date Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
heap Loading commit data...
interpreter Loading commit data...
libplatform Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parser Loading commit data...
profiler Loading commit data...
regress Loading commit data...
strings Loading commit data...
tasks Loading commit data...
torque Loading commit data...
utils Loading commit data...
wasm Loading commit data...
zone Loading commit data...
BUILD.gn Loading commit data...
DEPS Loading commit data...
run-all-unittests.cc Loading commit data...
test-helpers.cc Loading commit data...
test-helpers.h Loading commit data...
test-utils.cc Loading commit data...
test-utils.h Loading commit data...
testcfg.py Loading commit data...
unittests.status Loading commit data...