• Peter Marshall's avatar
    Revert "Reland "[cpu-profiler] Log OSR code when starting the profiler"" · 15a78f97
    Peter Marshall authored
    This reverts commit 8b60d8fc.
    
    Reason for revert: Flaky on windows: https://ci.chromium.org/p/v8/builders/ci/V8%20Win32%20-%20debug/27302
    
    Original change's description:
    > Reland "[cpu-profiler] Log OSR code when starting the profiler"
    > 
    > This is a reland of f6965281
    > 
    > Updated the test:
    > 1. Set profiling interval to 100us to get 10x the samples
    > 2. Guarantee we spend at least 1ms per iteration, instead of only
    > bailing out if we spend more than 1ms. This gives us enough samples on
    > release mode.
    > 3. Increase the time spent profiling optimized code by 50% to make sure
    > we have a big enough difference.
    > 
    > With 1000 iterations I didn't see any flakes locally so this looks solid
    > now.
    > 
    > Original change's description:
    > > [cpu-profiler] Log OSR code when starting the profiler
    > >
    > > OSR code doesn't hang off any JSFunction or SFI, so we missed it when
    > > starting up the profiler. This meant we didn't properly attribute
    > > ticks to SFI code. The ticks ended up going to the caller instead.
    > >
    > > There is a weak cache of OSR code per native context, so iterate that
    > > on profiler startup and log all the code objects.
    > >
    > > Change-Id: I2e9738b86a488b37f36ac89803561607dc76f745
    > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2414216
    > > Commit-Queue: Peter Marshall <petermarshall@chromium.org>
    > > Reviewed-by: Dominik Inführ <dinfuehr@chromium.org>
    > > Reviewed-by: Mythri Alle <mythria@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#69964}
    > 
    > Change-Id: Ib506e88b546008e462967259763bbf985b74b462
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2418092
    > Commit-Queue: Peter Marshall <petermarshall@chromium.org>
    > Reviewed-by: Dominik Inführ <dinfuehr@chromium.org>
    > Reviewed-by: Mythri Alle <mythria@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#69990}
    
    TBR=mythria@chromium.org,petermarshall@chromium.org,dinfuehr@chromium.org
    
    Change-Id: Ie3272c4fd297ca6f10a47c3fe8826e226a9f0545
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2418714Reviewed-by: 's avatarPeter Marshall <petermarshall@chromium.org>
    Commit-Queue: Peter Marshall <petermarshall@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#69999}
    15a78f97
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
OWNERS Loading commit data...