• Clemens Backes's avatar
    [flags] Fix pointer casts in {Flag} implementation · 14d019cb
    Clemens Backes authored
    The getters and setters were not using the correct types for the casts
    of {valptr_} and {defptr_}. It was mostly fine though, because
    {FlagValue<T>} just wraps a {T}, so accessing a {FlagValue<T>*} as a
    {T*} just works.
    
    This CL fixes the casts of {valptr_} to use proper {FlagValue<T>*}, and
    changes the definition of the default values to use plain {T} instead of
    {FlagValue<T>}.
    
    R=tebbi@chromium.org
    
    Bug: v8:12887
    Change-Id: I3a38ba466df95a4c7b45e83fbd5d37c9a4785a13
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3695558Reviewed-by: 's avatarTobias Tebbi <tebbi@chromium.org>
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#81029}
    14d019cb
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
baseline Loading commit data...
bigint Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
maglev Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sandbox Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
temporal Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
web-snapshot Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...