• Dominik Inführ's avatar
    [heap] Fix failing DCHECK with original_top < top · ca448997
    Dominik Inführ authored
    The problem here was that IncrementalMarking::Step was invoking
    new_space()->ResetOriginalTop() which sets original_top to the current
    top. IncrementalMarking::Step could be invoked during
    InvokeAllocationObservers(), which is called right after acquiring a
    new LAB and allocating the first object in it. However this first
    allocation might be from generated code with allocation folding enabled.
    The generated code might not use all of the memory it allocated and in
    that process move top backwards again. Nevertheless
    InvokeAllocationObservers() could already set original_top to the
    current top. If the generated code later not uses all of that
    memory, original_top can be bigger than top.
    
    Fix this problem by ensuring that original_top always equals the LAB
    start. Each time LAB start is moved/accounted for, original_top is now
    updated as well for the new space. Also IncrementalMarking::Step()
    isn't allowed to move original_top anymore.
    
    Bug: chromium:1116278, v8:10315
    Change-Id: Ib18a0b07e2665b8ba933555387b84329cbecdf5b
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2398519Reviewed-by: 's avatarUlan Degenbaev <ulan@chromium.org>
    Reviewed-by: 's avatarIgor Sheludko <ishell@chromium.org>
    Commit-Queue: Dominik Inführ <dinfuehr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#69840}
    ca448997
Name
Last commit
Last update
..
base Loading commit data...
cppgc Loading commit data...
cppgc-js Loading commit data...
third-party Loading commit data...
OWNERS Loading commit data...
allocation-observer.cc Loading commit data...
allocation-observer.h Loading commit data...
allocation-stats.h Loading commit data...
array-buffer-sweeper.cc Loading commit data...
array-buffer-sweeper.h Loading commit data...
barrier.h Loading commit data...
base-space.cc Loading commit data...
base-space.h Loading commit data...
basic-memory-chunk.cc Loading commit data...
basic-memory-chunk.h Loading commit data...
code-object-registry.cc Loading commit data...
code-object-registry.h Loading commit data...
code-stats.cc Loading commit data...
code-stats.h Loading commit data...
combined-heap.cc Loading commit data...
combined-heap.h Loading commit data...
concurrent-allocator-inl.h Loading commit data...
concurrent-allocator.cc Loading commit data...
concurrent-allocator.h Loading commit data...
concurrent-marking.cc Loading commit data...
concurrent-marking.h Loading commit data...
conservative-stack-visitor.cc Loading commit data...
conservative-stack-visitor.h Loading commit data...
embedder-tracing.cc Loading commit data...
embedder-tracing.h Loading commit data...
factory-base-inl.h Loading commit data...
factory-base.cc Loading commit data...
factory-base.h Loading commit data...
factory-inl.h Loading commit data...
factory.cc Loading commit data...
factory.h Loading commit data...
finalization-registry-cleanup-task.cc Loading commit data...
finalization-registry-cleanup-task.h Loading commit data...
free-list-inl.h Loading commit data...
free-list.cc Loading commit data...
free-list.h Loading commit data...
gc-idle-time-handler.cc Loading commit data...
gc-idle-time-handler.h Loading commit data...
gc-tracer.cc Loading commit data...
gc-tracer.h Loading commit data...
heap-controller.cc Loading commit data...
heap-controller.h Loading commit data...
heap-inl.h Loading commit data...
heap-write-barrier-inl.h Loading commit data...
heap-write-barrier.cc Loading commit data...
heap-write-barrier.h Loading commit data...
heap.cc Loading commit data...
heap.h Loading commit data...
incremental-marking-inl.h Loading commit data...
incremental-marking-job.cc Loading commit data...
incremental-marking-job.h Loading commit data...
incremental-marking.cc Loading commit data...
incremental-marking.h Loading commit data...
invalidated-slots-inl.h Loading commit data...
invalidated-slots.cc Loading commit data...
invalidated-slots.h Loading commit data...
item-parallel-job.cc Loading commit data...
item-parallel-job.h Loading commit data...
large-spaces.cc Loading commit data...
large-spaces.h Loading commit data...
list.h Loading commit data...
local-allocator-inl.h Loading commit data...
local-allocator.h Loading commit data...
local-factory-inl.h Loading commit data...
local-factory.cc Loading commit data...
local-factory.h Loading commit data...
local-heap-inl.h Loading commit data...
local-heap.cc Loading commit data...
local-heap.h Loading commit data...
mark-compact-inl.h Loading commit data...
mark-compact.cc Loading commit data...
mark-compact.h Loading commit data...
marking-barrier-inl.h Loading commit data...
marking-barrier.cc Loading commit data...
marking-barrier.h Loading commit data...
marking-visitor-inl.h Loading commit data...
marking-visitor.h Loading commit data...
marking-worklist-inl.h Loading commit data...
marking-worklist.cc Loading commit data...
marking-worklist.h Loading commit data...
marking.cc Loading commit data...
marking.h Loading commit data...
memory-allocator.cc Loading commit data...
memory-allocator.h Loading commit data...
memory-chunk-inl.h Loading commit data...
memory-chunk-layout.cc Loading commit data...
memory-chunk-layout.h Loading commit data...
memory-chunk.cc Loading commit data...
memory-chunk.h Loading commit data...
memory-measurement-inl.h Loading commit data...
memory-measurement.cc Loading commit data...
memory-measurement.h Loading commit data...
memory-reducer.cc Loading commit data...
memory-reducer.h Loading commit data...
new-spaces-inl.h Loading commit data...
new-spaces.cc Loading commit data...
new-spaces.h Loading commit data...
object-start-bitmap.h Loading commit data...
object-stats.cc Loading commit data...
object-stats.h Loading commit data...
objects-visiting-inl.h Loading commit data...
objects-visiting.cc Loading commit data...
objects-visiting.h Loading commit data...
paged-spaces-inl.h Loading commit data...
paged-spaces.cc Loading commit data...
paged-spaces.h Loading commit data...
read-only-heap-inl.h Loading commit data...
read-only-heap.cc Loading commit data...
read-only-heap.h Loading commit data...
read-only-spaces.cc Loading commit data...
read-only-spaces.h Loading commit data...
remembered-set-inl.h Loading commit data...
remembered-set.h Loading commit data...
safepoint.cc Loading commit data...
safepoint.h Loading commit data...
scavenge-job.cc Loading commit data...
scavenge-job.h Loading commit data...
scavenger-inl.h Loading commit data...
scavenger.cc Loading commit data...
scavenger.h Loading commit data...
setup-heap-internal.cc Loading commit data...
slot-set.cc Loading commit data...
slot-set.h Loading commit data...
spaces-inl.h Loading commit data...
spaces.cc Loading commit data...
spaces.h Loading commit data...
stress-marking-observer.cc Loading commit data...
stress-marking-observer.h Loading commit data...
stress-scavenge-observer.cc Loading commit data...
stress-scavenge-observer.h Loading commit data...
sweeper.cc Loading commit data...
sweeper.h Loading commit data...
worklist.h Loading commit data...