• Shu-yu Guo's avatar
    [builtins] Use SetPropertyInLiteral instead of FastCreateDataProperty in Object.fromEntries · 1458040f
    Shu-yu Guo authored
    The spec uses the CreateDataProperty abstract operation to add
    properties to the result object of Object.fromEntries.
    
    Confusingly, the FastCreateDataProperty Torque macro is special-cased
    for adding array element properties instead of generic keyed properties.
    The slow path for FastCreateDataProperty goes to runtime, which was
    being hit everytime in Object.fromEntries since the result object is not
    an array.
    
    This CL switches to using StorePropertyInLiteral instead, which
    corresponds to the CreateDataProperty spec operation, and also has fast
    paths that stay in CSA.
    
    Bug: v8:11814
    Change-Id: I72a6809bde556f0888806307816e200bd47edf8e
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2915755Reviewed-by: 's avatarMarja Hölttä <marja@chromium.org>
    Commit-Queue: Shu-yu Guo <syg@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#74755}
    1458040f
Name
Last commit
Last update
.github Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...