• Patrick Thier's avatar
    Reland "Reland "Improve error messages for property access on null/undefined"" · 819c3ae2
    Patrick Thier authored
    This is a reland of 8b18c5e6
    
    Original change's description:
    > Reland "Improve error messages for property access on null/undefined"
    >
    > This is a reland of 24c626c1
    >
    > Original change's description:
    > > Improve error messages for property access on null/undefined
    > >
    > > Only print the property name when accessing null/undefined if we can
    > > convert it to a string without causing side effects.
    > > If we can't, omit the property name in the error message.
    > > This should avoid confusion when the key is an object with toString().
    > > E.g. undefined[{toString:()=>'a'}] doesn't print 'read property [object
    > > Object]' anymore, which was misleading since the property accessed would
    > > be 'a', but we can't evaluate the key without side effects.
    > >
    > > Bug: v8:11365
    > > Change-Id: If82d1adb42561d4851e2bd2ca297a1c71738aee8
    > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2960211
    > > Reviewed-by: Toon Verwaest <verwaest@chromium.org>
    > > Commit-Queue: Patrick Thier <pthier@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#75250}
    >
    > Bug: v8:11365
    > Change-Id: Ie2312337f4f1915faa31528a728d90833d80dbd1
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2979599
    > Reviewed-by: Toon Verwaest <verwaest@chromium.org>
    > Commit-Queue: Patrick Thier <pthier@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#75571}
    
    Bug: v8:11365
    Change-Id: I90360641ecd870bd93247aa6d91dfb0ad049cfb8
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3008219
    Auto-Submit: Patrick Thier <pthier@chromium.org>
    Commit-Queue: Toon Verwaest <verwaest@chromium.org>
    Reviewed-by: 's avatarToon Verwaest <verwaest@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#75604}
    819c3ae2
Name
Last commit
Last update
..
bugs/harmony Loading commit data...
debug Loading commit data...
protocol Loading commit data...
regress Loading commit data...
wrapper Loading commit data...
BUILD.gn Loading commit data...
OWNERS Loading commit data...
debugger.status Loading commit data...
test-api.js Loading commit data...
testcfg.py Loading commit data...