• adamk's avatar
    Remove Scope::scope_contains_with_ bit · 108efd7f
    adamk authored
    This part of Scope has existed since V8's initial check in, but from what
    I can tell it's not required to implement "with". The only tests that
    depend upon it are tests of the debugger and the Scope mirrors, but the
    resulting test behavior after removing the bit still seems perfectly
    reasonable to me. In fact, with the included fix for scope name collection,
    the scope mirror is actually improved with this change.
    
    As a bi-product, this fixes the attached bug, about the contains_with
    bit having inconsistent values in some arrow function compilation
    scenarios.
    
    BUG=chromium:592353
    LOG=n
    CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
    
    Review URL: https://codereview.chromium.org/1804783002
    
    Cr-Commit-Position: refs/heads/master@{#34802}
    108efd7f
Name
Last commit
Last update
..
benchmarks Loading commit data...
cctest Loading commit data...
fuzzer Loading commit data...
intl Loading commit data...
js-perf-test Loading commit data...
memory Loading commit data...
message Loading commit data...
mjsunit Loading commit data...
mozilla Loading commit data...
preparser Loading commit data...
promises-aplus Loading commit data...
simdjs Loading commit data...
test262 Loading commit data...
unittests Loading commit data...
webkit Loading commit data...
bot_default.gyp Loading commit data...
bot_default.isolate Loading commit data...
default.gyp Loading commit data...
default.isolate Loading commit data...
ignition.gyp Loading commit data...
ignition.isolate Loading commit data...
optimize_for_size.gyp Loading commit data...
optimize_for_size.isolate Loading commit data...
perf.gyp Loading commit data...
perf.isolate Loading commit data...