• mvstanton's avatar
    Revert of X87: Type Feedback Vector lives in the closure. (patchset #1 id:1 of... · 0ff456af
    mvstanton authored
    Revert of X87: Type Feedback Vector lives in the closure. (patchset #1 id:1 of https://codereview.chromium.org/1672643002/ )
    
    Reason for revert:
    Bugs with chromium api natives, must revert for now.
    
    Original issue's description:
    > X87: Type Feedback Vector lives in the closure.
    >
    >   port bb31db3a (r33741)
    >
    >   original commit message:
    >   (RELAND: the problem before was a missing write barrier for adding the code
    >   entry to the new closure. It's been addressed with a new macro instruction
    >   and test. The only change to this CL is the addition of two calls to
    >   __ RecordWriteCodeEntryField() in the platform CompileLazy builtin.)
    >
    >   We get less "pollution" of type feedback if we have one vector per native
    >   context, rather than one for the whole system. This CL moves the vector
    >   appropriately.
    >
    >   We rely more heavily on the Optimized Code Map in the SharedFunctionInfo. The
    >   vector actually lives in the first slot of the literals array (indeed there is
    >   great commonality between those arrays, they can be thought of as the same
    >   thing). So we make greater effort to ensure there is a valid literals array
    >   after compilation.
    >
    >   This meant, for performance reasons, that we needed to extend
    >   FastNewClosureStub to support creating closures with literals. And ultimately,
    >   it drove us to move the optimized code map lookup out of FastNewClosureStub
    >   and into the compile lazy builtin.
    >
    >   The heap change is trivial so I TBR Hannes for it...
    >   Also, Yang has had a look at the debugger changes already and approved 'em. So he is TBR style too.
    >   And Benedikt reviewed it as well.
    >
    > BUG=
    >
    > Committed: https://crrev.com/25bfba9329b93cb8ebefe1446e024005a4227a93
    > Cr-Commit-Position: refs/heads/master@{#33759}
    
    TBR=chunyang.dai@intel.com,weiliang.lin@intel.com,zhengxing.li@intel.com
    # Skipping CQ checks because original CL landed less than 1 days ago.
    NOPRESUBMIT=true
    NOTREECHECKS=true
    NOTRY=true
    BUG=
    
    Review URL: https://codereview.chromium.org/1673613002
    
    Cr-Commit-Position: refs/heads/master@{#33764}
    0ff456af
Name
Last commit
Last update
benchmarks Loading commit data...
build Loading commit data...
docs Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party/binutils Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
Makefile.nacl Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...