• Clemens Backes's avatar
    [isolate] Strengthen check for builtins results · 0f4a62c0
    Clemens Backes authored
    The CHECK was checking that we return the exception sentinel if an
    exception is pending. The other way is actually equally important: If we
    return the exception sentinel, a pending exception must be scheduled.
    
    Since the CEntry stub assumes that all values returned from runtime
    functions are valid tagged values (pointing into the JS heap), do also
    check that. This check would have prevented the linked issue.
    
    Bug: chromium:1311960
    
    R=jkummerow@chromium.org
    CC=​cbruni@chromium.org
    
    Change-Id: I833d2968529e3b73f3009e0104b46182197c2d23
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3675098Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#81145}
    0f4a62c0
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
baseline Loading commit data...
bigint Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
maglev Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sandbox Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
temporal Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
web-snapshot Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...