• Thibaud Michaud's avatar
    [regalloc] Fix slot requirement for live ranges defined by a const · 0ee6f90a
    Thibaud Michaud authored
    Live ranges defined by a constant operand normally don't require a spill
    slot since they can just rematerialize the value from the constant. In
    the attached issue however, deoptimization adds an explicit slot
    requirement for a range that is defined by a constant operand. This case
    is not expected in the register allocator and we eventually hit a
    DCHECK.
    
    This fix allocates a new stack slot during the MeetRegisterConstraints
    and adds the missing gap move.
    
    Drive-by: remove dead method LiveRange::NextSlotPosition.
    
    R=sigurds@chromium.org
    CC=​nicohartmann@chromium.org
    
    Bug: chromium:1146880
    Change-Id: I08fbb890f2f3d9574196989cf3e5ef6232433484
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2563689Reviewed-by: 's avatarSigurd Schneider <sigurds@chromium.org>
    Commit-Queue: Thibaud Michaud <thibaudm@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#73510}
    0ee6f90a
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
baseline Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
web-snapshot Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...