• Clemens Backes's avatar
    Reland "[wasm][debug] Fix tier down during streaming compilation" · 18ac08d0
    Clemens Backes authored
    This is a reland of 3cc981cb with a
    fix for data race detected by TSan.
    
    Original change's description:
    > [wasm][debug] Fix tier down during streaming compilation
    >
    > If the debugger is enabled while streaming compilation is happening, we
    > won't correctly tier down to Liftoff. This is because during streaming
    > compilation, we always compile for no debugging. Fixing that is a bit
    > tricky, since when the debugger is enabled, functions can either already
    > have finished compiling, or they are currently being compiled, or their
    > wire bytes are not received yet.
    > Instead of handling this correctly while streaming compilation is
    > running, we just recompile the whole module with Liftoff after streaming
    > compilation finished.
    >
    > For testing this, we use the existing tests for async compilation, and
    > enable --wasm-test-streaming, which compiles via the streaming decoder
    > even in the async compilation case.
    >
    > R=thibaudm@chromium.org
    >
    > Bug: v8:10531
    > Change-Id: I0177248a9ad2e90f83faee965d6746de05423f1f
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2207133
    > Reviewed-by: Thibaud Michaud <thibaudm@chromium.org>
    > Commit-Queue: Clemens Backes <clemensb@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#67882}
    
    Bug: v8:10531, v8:10544
    Change-Id: I884922b6ac55543e6ff9b1046438f6b3abab6f64
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2207187Reviewed-by: 's avatarThibaud Michaud <thibaudm@chromium.org>
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#67896}
    18ac08d0
Name
Last commit
Last update
..
asm-debug.js Loading commit data...
debug-enabled-tier-down-wasm-streaming.js Loading commit data...
debug-enabled-tier-down-wasm-unsupported-liftoff.js Loading commit data...
debug-enabled-tier-down-wasm.js Loading commit data...
debug-step-into-wasm.js Loading commit data...
frame-inspection.js Loading commit data...