• Clemens Hammacher's avatar
    Revert "Reland "[builtins] Verify Isolate compatibility with the embedded blob"" · 2c6e96a6
    Clemens Hammacher authored
    This reverts commit 1e3582b5.
    
    Reason for revert: Still fails nosnap: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux%20-%20nosnap%20-%20debug/22789
    
    Original change's description:
    > Reland "[builtins] Verify Isolate compatibility with the embedded blob"
    > 
    > This is a reland of b022e825
    > 
    > Original change's description:
    > > [builtins] Verify Isolate compatibility with the embedded blob
    > >
    > > Embedded builtins (= the embedded blob) have a few dependencies on the
    > > snapshot state. For instance, they require that metadata stored on
    > > builtin Code objects as well as the builtins constant table remain
    > > unchanged from mksnapshot-time. Embedders may violate these
    > > assumptions by accident, e.g. by loading a snapshot generated with
    > > different build flags, leading to seemingly unrelated failures later
    > > on.
    > >
    > > This CL introduces an Isolate hash stored in the embedded blob which
    > > hashes relevant parts of builtin Code objects and the builtins
    > > constant table. It's verified in Isolate::Init in debug builds.
    > >
    > > Bug: v8:8723
    > > Change-Id: Ifc9bdbe6f56ea67d8984f162afa73a3572cfbba8
    > > Reviewed-on: https://chromium-review.googlesource.com/c/1442641
    > > Commit-Queue: Jakob Gruber <jgruber@chromium.org>
    > > Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#59177}
    > 
    > Tbr: yangguo@chromium.org,sigurds@chromium.org
    > Bug: v8:8723
    > Change-Id: I1dd001783f0f1fae21a9809c8639e40f55b8f663
    > Reviewed-on: https://chromium-review.googlesource.com/c/1445985
    > Commit-Queue: Jakob Gruber <jgruber@chromium.org>
    > Reviewed-by: Jakob Gruber <jgruber@chromium.org>
    > Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#59236}
    
    TBR=yangguo@chromium.org,sigurds@chromium.org,jgruber@chromium.org
    
    Change-Id: If6082452c739d4de44ed70d3c6355f5282684ac1
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: v8:8723
    Reviewed-on: https://chromium-review.googlesource.com/c/1448311Reviewed-by: 's avatarClemens Hammacher <clemensh@chromium.org>
    Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#59241}
    2c6e96a6
Name
Last commit
Last update
..
benchmarks Loading commit data...
cctest Loading commit data...
common Loading commit data...
debugger Loading commit data...
fuzzer Loading commit data...
inspector Loading commit data...
intl Loading commit data...
js-perf-test Loading commit data...
memory Loading commit data...
message Loading commit data...
mjsunit Loading commit data...
mkgrokdump Loading commit data...
mozilla Loading commit data...
preparser Loading commit data...
test262 Loading commit data...
torque Loading commit data...
unittests Loading commit data...
wasm-js Loading commit data...
wasm-spec-tests Loading commit data...
webkit Loading commit data...
BUILD.gn Loading commit data...