• Adam Klein's avatar
    Revert "Remove all custom CopyCharsUnsigned implementations" · 0aac347e
    Adam Klein authored
    This reverts commit 5d8c4890.
    
    Reason for revert: Fails on UBSan bot:
    https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20UBSan/7946
    
    Original change's description:
    > Remove all custom CopyCharsUnsigned implementations
    > 
    > It's unclear whether the custom implementation have any advantage over
    > the standard library one's.
    > Since we update our toolchain and standard library regularly, it might
    > well be the case that the custom implementations are slower by now.
    > 
    > Thus this CL removes all {CopyCharsUnsigned} implementations and
    > implements {CopyChars} generically using {std::copy_n}.
    > 
    > Note that this does not touch the {MemMove} and {MemCopy} functions
    > yet, as we have seen regressions when trying to remove them before
    > (https://crbug.com/v8/8675#c5).
    > 
    > R=​leszeks@chromium.org
    > 
    > Bug: v8:9396
    > Change-Id: I97a183afebcccd2fbb567bdba02e827331475608
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1800577
    > Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
    > Reviewed-by: Leszek Swirski <leszeks@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#63808}
    
    TBR=leszeks@chromium.org,clemensh@chromium.org
    
    Change-Id: Ia16da942c7c28ba71076d1e3b0b8a6388a4ba359
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: v8:9396
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1806103Reviewed-by: 's avatarAdam Klein <adamk@chromium.org>
    Commit-Queue: Adam Klein <adamk@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#63810}
    0aac347e
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
OWNERS Loading commit data...