• Nikolaos Papaspyrou's avatar
    heap: Fix bug in minor MC heap verification · f20949fa
    Nikolaos Papaspyrou authored
    Minor MC heap verification requires heap iterability. This however was
    not directly ensured. Coincidentally, there was an unrelated call to
    `Heap::Verify` that ensured `Heap::MakeHeapIterable` had been called,
    so the precondition was met. This call was moved to an earlier point
    by https://crrev.com/c/3497318 and, because of that, some combination
    of flags now results in a crash.
    
    This CL fixes the issue by directly ensuring heap iterability. It also
    moves back the call to `Heap::Verify`, so that it takes place inside
    the GC safepoint.
    
    Bug: v8:12768
    Change-Id: I2c66de0d0a735b84dd9435ff503e78bb3611ce55
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3569224Reviewed-by: 's avatarDominik Inführ <dinfuehr@chromium.org>
    Commit-Queue: Nikolaos Papaspyrou <nikolaos@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#79844}
    f20949fa
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
baseline Loading commit data...
bigint Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
maglev Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sandbox Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
temporal Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
web-snapshot Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...