• Toon Verwaest's avatar
    [parser] Accumulate even if we already thought we had an error · 94d8fcb8
    Toon Verwaest authored
    At certain points in time we learn that we have to drop certain errors in the
    ExpressionScope. If an AccumulationScope appears between where we learn about
    the error and where we drop the error, we previously stopped accumulating,
    assuming that we're already going to fail anyway. Since we might drop the
    earlier error later; we can't early on this. Instead the accumulator should
    simply keep on accumulating, keeping the earlier error alive across
    accumulation.
    
    Bug: chromium:1015567
    Change-Id: I4d70643d02233fe82582b568a0a946eacf883880
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1869198
    Commit-Queue: Toon Verwaest <verwaest@chromium.org>
    Commit-Queue: Leszek Swirski <leszeks@chromium.org>
    Auto-Submit: Toon Verwaest <verwaest@chromium.org>
    Reviewed-by: 's avatarLeszek Swirski <leszeks@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#64384}
    94d8fcb8
Name
Last commit
Last update
..
OWNERS Loading commit data...
expression-scope-reparenter.cc Loading commit data...
expression-scope-reparenter.h Loading commit data...
expression-scope.h Loading commit data...
func-name-inferrer.cc Loading commit data...
func-name-inferrer.h Loading commit data...
keywords-gen.h Loading commit data...
keywords.txt Loading commit data...
literal-buffer.cc Loading commit data...
literal-buffer.h Loading commit data...
parse-info.cc Loading commit data...
parse-info.h Loading commit data...
parser-base.h Loading commit data...
parser.cc Loading commit data...
parser.h Loading commit data...
parsing.cc Loading commit data...
parsing.h Loading commit data...
pending-compilation-error-handler.cc Loading commit data...
pending-compilation-error-handler.h Loading commit data...
preparse-data-impl.h Loading commit data...
preparse-data.cc Loading commit data...
preparse-data.h Loading commit data...
preparser-logger.h Loading commit data...
preparser.cc Loading commit data...
preparser.h Loading commit data...
rewriter.cc Loading commit data...
rewriter.h Loading commit data...
scanner-character-streams.cc Loading commit data...
scanner-character-streams.h Loading commit data...
scanner-inl.h Loading commit data...
scanner.cc Loading commit data...
scanner.h Loading commit data...
token.cc Loading commit data...
token.h Loading commit data...