• Adam Klein's avatar
    Revert "Reland "Remove all custom CopyCharsUnsigned implementations"" · 24c35b92
    Adam Klein authored
    This reverts commits 9febc505
    (along with followup commit 60624b56).
    
    Reason for revert: Breaks win32 nosnap shared, blocking lkgr & roll:
    https://ci.chromium.org/p/v8/builders/ci/V8%20Win32%20-%20nosnap%20-%20shared/35145
    
    nosnap bots may be deprecated, but as long as they're in LKGR
    we need to mind them.
    
    Original change's description:
    > Reland "Remove all custom CopyCharsUnsigned implementations"
    >
    > This is a reland of 5d8c4890
    >
    > Original change's description:
    > > Remove all custom CopyCharsUnsigned implementations
    > >
    > > It's unclear whether the custom implementation have any advantage over
    > > the standard library one's.
    > > Since we update our toolchain and standard library regularly, it might
    > > well be the case that the custom implementations are slower by now.
    > >
    > > Thus this CL removes all {CopyCharsUnsigned} implementations and
    > > implements {CopyChars} generically using {std::copy_n}.
    > >
    > > Note that this does not touch the {MemMove} and {MemCopy} functions
    > > yet, as we have seen regressions when trying to remove them before
    > > (https://crbug.com/v8/8675#c5).
    > >
    > > R=leszeks@chromium.org
    > >
    > > Bug: v8:9396
    > > Change-Id: I97a183afebcccd2fbb567bdba02e827331475608
    > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1800577
    > > Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
    > > Reviewed-by: Leszek Swirski <leszeks@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#63808}
    >
    > Bug: v8:9396
    > Cq-Include-Trybots: luci.v8.try:v8_linux64_ubsan_rel_ng
    > Change-Id: I9cd754ebe6b802bb4aabd6d2a448de41da040874
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1807357
    > Reviewed-by: Leszek Swirski <leszeks@chromium.org>
    > Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#63823}
    
    TBR=leszeks@chromium.org,clemensh@chromium.org
    
    Change-Id: Ic53ab2293d5dc7722a1121d1aa1159328a6ed8f5
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: v8:9396
    Cq-Include-Trybots: luci.v8.try:v8_linux64_ubsan_rel_ng
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1808035Reviewed-by: 's avatarAdam Klein <adamk@chromium.org>
    Commit-Queue: Adam Klein <adamk@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#63854}
    24c35b92
Name
Last commit
Last update
..
OWNERS Loading commit data...
char-predicates-inl.h Loading commit data...
char-predicates.cc Loading commit data...
char-predicates.h Loading commit data...
string-builder-inl.h Loading commit data...
string-builder.cc Loading commit data...
string-case.cc Loading commit data...
string-case.h Loading commit data...
string-hasher-inl.h Loading commit data...
string-hasher.h Loading commit data...
string-search.h Loading commit data...
string-stream.cc Loading commit data...
string-stream.h Loading commit data...
unicode-decoder.cc Loading commit data...
unicode-decoder.h Loading commit data...
unicode-inl.h Loading commit data...
unicode.cc Loading commit data...
unicode.h Loading commit data...
uri.cc Loading commit data...
uri.h Loading commit data...