• Kim-Anh Tran's avatar
    [wasm] Removing cyclic dependency caused by the CompilationState · 071cecc0
    Kim-Anh Tran authored
    Removes the deferred handle reference to the native context that
    caused a cyclic dependency, which resulted in a memory leak. Instead of
    keeping a reference to the native context, we use a phantom reference
    to the WasmCompiledModule in order to get the context.
    All foreground tasks are now registered in its own foreground task
    manager, in order to make sure that we cancel all scheduled
    foreground tasks as soon as the CompilationState is collected.
    
    Bug: chromium:825741
    Also-by: ahaas@chromium.org
    Change-Id: Id69426a15280a14a1dc3ecd035415e7cfa61780b
    Reviewed-on: https://chromium-review.googlesource.com/982622Reviewed-by: 's avatarAndreas Haas <ahaas@chromium.org>
    Reviewed-by: 's avatarUlan Degenbaev <ulan@chromium.org>
    Commit-Queue: Kim-Anh Tran <kimanh@google.com>
    Cr-Commit-Position: refs/heads/master@{#52270}
    071cecc0
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...