• Sathya Gunasekaran's avatar
    Revert "[builtins] Move non-JS linkage builtins code objects into RO_SPACE" · f1ebde88
    Sathya Gunasekaran authored
    This reverts commit 83f8464f.
    
    Reason for revert: speculative revert for blink linux failure
    https://ci.chromium.org/p/v8/builders/ci/V8%20Blink%20Linux/1272
    
    Original change's description:
    > [builtins] Move non-JS linkage builtins code objects into RO_SPACE
    > 
    > Creates an allow-list of builtins that can still go in code_space
    > including all TFJ builtins and a small manual list that should be pared
    > down in the future.
    > 
    > For builtins that go in RO_SPACE a Code object is created that contains
    > no code at all (shrinking its size from 96 bytes to 64 bytes on x64),
    > but is there to allow the runtime to continue to work since it expects
    > a Code object.
    > 
    > This reduces code_space from ~152k to ~40k (-112k) and increases
    > read_only_space from 33k to 108k (+75k) in the snapshot.
    > 
    > Bug: v8:7464, v8:9821, v8:9338, v8:8127
    > Change-Id: Icc8bfc722bb267a2bcc17e2f1e27bef7f02f2376
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1795358
    > Commit-Queue: Dan Elphick <delphick@chromium.org>
    > Reviewed-by: Jakob Gruber <jgruber@chromium.org>
    > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#64377}
    
    TBR=mstarzinger@chromium.org,jgruber@chromium.org,delphick@chromium.org
    
    Change-Id: I4cf38e9370280acdd2de718ca527776ebc509003
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: v8:7464, v8:9821, v8:9338, v8:8127
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1868621Reviewed-by: 's avatarSathya Gunasekaran  <gsathya@chromium.org>
    Commit-Queue: Sathya Gunasekaran  <gsathya@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#64383}
    f1ebde88
Name
Last commit
Last update
..
arm Loading commit data...
arm64 Loading commit data...
ia32 Loading commit data...
mips Loading commit data...
mips64 Loading commit data...
ppc Loading commit data...
s390 Loading commit data...
x64 Loading commit data...
OWNERS Loading commit data...
arguments-inl.h Loading commit data...
arguments.cc Loading commit data...
arguments.h Loading commit data...
execution.cc Loading commit data...
execution.h Loading commit data...
frame-constants.h Loading commit data...
frames-inl.h Loading commit data...
frames.cc Loading commit data...
frames.h Loading commit data...
futex-emulation.cc Loading commit data...
futex-emulation.h Loading commit data...
interrupts-scope.cc Loading commit data...
interrupts-scope.h Loading commit data...
isolate-data.h Loading commit data...
isolate-inl.h Loading commit data...
isolate-utils-inl.h Loading commit data...
isolate-utils.h Loading commit data...
isolate.cc Loading commit data...
isolate.h Loading commit data...
messages.cc Loading commit data...
messages.h Loading commit data...
microtask-queue.cc Loading commit data...
microtask-queue.h Loading commit data...
protectors-inl.h Loading commit data...
protectors.cc Loading commit data...
protectors.h Loading commit data...
runtime-profiler.cc Loading commit data...
runtime-profiler.h Loading commit data...
simulator-base.cc Loading commit data...
simulator-base.h Loading commit data...
simulator.h Loading commit data...
stack-guard.cc Loading commit data...
stack-guard.h Loading commit data...
thread-id.cc Loading commit data...
thread-id.h Loading commit data...
thread-local-top.cc Loading commit data...
thread-local-top.h Loading commit data...
v8threads.cc Loading commit data...
v8threads.h Loading commit data...
vm-state-inl.h Loading commit data...
vm-state.h Loading commit data...