• clemensh's avatar
    [base] Pass scalar arguments by value in CHECK/DCHECK · 76723502
    clemensh authored
    This not only potentially improves performance, but also avoids weird
    linker errors, like the one below, where I used Smi::kMinValue in a
    DCHECK_EQ.
    
    > [421/649] LINK ./mksnapshot
    > FAILED: mksnapshot
    > src/base/logging.h|178| error: undefined reference to
      'v8::internal::Smi::kMinValue'
    
    R=bmeurer@chromium.org, ishell@chromium.org
    
    Review-Url: https://codereview.chromium.org/2524093002
    Cr-Commit-Position: refs/heads/master@{#41273}
    76723502
Name
Last commit
Last update
..
base Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
heap Loading commit data...
interpreter Loading commit data...
libplatform Loading commit data...
wasm Loading commit data...
zone Loading commit data...
BUILD.gn Loading commit data...
DEPS Loading commit data...
cancelable-tasks-unittest.cc Loading commit data...
char-predicates-unittest.cc Loading commit data...
counters-unittest.cc Loading commit data...
eh-frame-iterator-unittest.cc Loading commit data...
eh-frame-writer-unittest.cc Loading commit data...
locked-queue-unittest.cc Loading commit data...
register-configuration-unittest.cc Loading commit data...
run-all-unittests.cc Loading commit data...
source-position-table-unittest.cc Loading commit data...
test-utils.cc Loading commit data...
test-utils.h Loading commit data...
unicode-unittest.cc Loading commit data...
unittests.gyp Loading commit data...
unittests.isolate Loading commit data...
unittests.status Loading commit data...
value-serializer-unittest.cc Loading commit data...