• aperez's avatar
    Cleanups needed for this-scoping in arrow functions · 00844d46
    aperez authored
    Remove Variable::IsValidReference(), and the Variable::is_valid_ref_
    member: This was "false" only for "this", and for internal variables.
    For the first, VariableProxy::is_this() can be used for the check
    instead; and for internal variables, it is guaranteed they they will
    not be written to (because the V8 code does not do it, and they are
    not accessible from JavaScript).
    
    The "bool is_this" parameter of VariableProxy() constructor is
    changed to use Variable::Kind. This will allow to later on adding
    a parameter to create unresolved variables of any kind, which in
    turn will be used to make references to "this" initially unresolved,
    and use the existing variable resolution mechanics for "this".
    
    BUG=v8:2700
    LOG=N
    
    Review URL: https://codereview.chromium.org/1024703004
    
    Cr-Commit-Position: refs/heads/master@{#27404}
    00844d46
Name
Last commit
Last update
benchmarks Loading commit data...
build Loading commit data...
include Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party/binutils Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
Makefile.nacl Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...