1. 17 Sep, 2018 1 commit
  2. 15 Sep, 2018 1 commit
  3. 13 Sep, 2018 1 commit
  4. 10 Sep, 2018 1 commit
  5. 06 Sep, 2018 1 commit
    • Simon Zünd's avatar
      [array] Move Array.p.unshift fall-back to Torque · cfe71156
      Simon Zünd authored
      This CL implements a generic baseline version of Array.p.unshift
      in Torque, enabling us to remove the JS fall-back.
      
      The elements-accessor fast-path is still used, but the check whether
      to use it is also moved to Torque.
      
      Support for sparse JSArrays is removed.
      
      Drive-by change: Small refactoring in builtins-array that will
      get extended to other array builtins in a follow-up CL.
      
      R=cbruni@chromium.org, jgruber@chromium.org
      
      Bug: v8:7624
      Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng
      Change-Id: I7b23ce15e7b922eb333f61a408050dedec77c95a
      Reviewed-on: https://chromium-review.googlesource.com/1189902
      Commit-Queue: Simon Zünd <szuend@google.com>
      Reviewed-by: 's avatarCamillo Bruni <cbruni@chromium.org>
      Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#55670}
      cfe71156
  6. 04 Sep, 2018 1 commit
    • Mike Stanton's avatar
      [builtins] Enable Torque Array.prototype.splice · fd334b32
      Mike Stanton authored
      Before, splice was implemented with a C++ fast path and a
      comprehensive JavaScript version.
      
      This impl. is entirely in Torque with a fastpath for SMI,
      DOUBLE and OBJECT arrays, and a comprehensive slow path.
      The same level of "sparse" array support as given by the
      array.js implementation is included.
      
      This reland addresses several issues:
      
      * Removed "sparse" array support from splice.
      * Addressed ClusterFuzz issue 876443:
        The test and code that uses the fix is in this CL.
        The fix in isolation can be seen here:
        https://chromium-review.googlesource.com/c/v8/v8/+/1199403
      * Removed dead code in elements.cc
      
      BUG=chromium:876443, v8:8131, v8:1956, v8:7221
      
      Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng
      Change-Id: I2d4a66c24ba1edabeca34e27e6ff8ee6136ed5f1
      Reviewed-on: https://chromium-review.googlesource.com/1201783
      Commit-Queue: Michael Stanton <mvstanton@chromium.org>
      Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#55610}
      fd334b32
  7. 03 Sep, 2018 1 commit
  8. 31 Aug, 2018 1 commit
    • Sathya Gunasekaran's avatar
      [Intl] Remove bound function SFIs from context · e56bf9f4
      Sathya Gunasekaran authored
      Instead of creating the SFIs during bootstrapping and storing on the
      context, this patch just creates the SFIs on demand.
      
      This patch saves 8 words per context, and several words per bound
      function by not storing the SFI.
      
      The created bound JSFunction is cached on the instance anyway, so it's
      totally fine to take a small hit when creating the bound JSFunction.
      
      Previously in the JS implementation, the creation of a bound function
      was even slower as it was a lazy function that would have to parsed,
      compiled and executed. So this is a step up in terms up perf and
      memory.
      
      Bug: v8:5751
      Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng
      Change-Id: If3b8461d00e5b37567b34b236d44e14576b630ff
      Reviewed-on: https://chromium-review.googlesource.com/1200006Reviewed-by: 's avatarAdam Klein <adamk@chromium.org>
      Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#55566}
      e56bf9f4
  9. 29 Aug, 2018 1 commit
  10. 28 Aug, 2018 3 commits
  11. 25 Aug, 2018 1 commit
  12. 24 Aug, 2018 1 commit
  13. 22 Aug, 2018 1 commit
    • Tobias Tebbi's avatar
      Revert "[builtins] Reland Array.prototype.splice() Torque implementation." · e99a1092
      Tobias Tebbi authored
      This reverts commit cdaaa311.
      
      Reason for revert: chromium:876445 chromium:876453 chromium:876443
      
      Original change's description:
      > [builtins] Reland Array.prototype.splice() Torque implementation.
      > 
      > Before, splice was implemented with a C++ fast path and a
      > comprehensive JavaScript version.
      > 
      > This impl. is entirely in Torque with a fastpath for SMI,
      > DOUBLE and OBJECT arrays, and a comprehensive slow path.
      > The same level of "sparse" array support as given by the
      > array.js implementation is included.
      > 
      > Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng
      > Change-Id: Ia7334a30b401988309e9909cfa0069da0bb6fb9f
      > Reviewed-on: https://chromium-review.googlesource.com/1169466
      > Reviewed-by: Tobias Tebbi <tebbi@chromium.org>
      > Reviewed-by: Jakob Gruber <jgruber@chromium.org>
      > Commit-Queue: Tobias Tebbi <tebbi@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#55263}
      
      TBR=mvstanton@chromium.org,jgruber@chromium.org,tebbi@chromium.org
      
      Change-Id: I5b750a98e671b7284474ffcabc6b4d37a9d1219e
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng
      Reviewed-on: https://chromium-review.googlesource.com/1184741Reviewed-by: 's avatarTobias Tebbi <tebbi@chromium.org>
      Commit-Queue: Tobias Tebbi <tebbi@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#55289}
      e99a1092
  14. 21 Aug, 2018 2 commits
  15. 17 Aug, 2018 1 commit
  16. 14 Aug, 2018 1 commit
  17. 09 Aug, 2018 1 commit
  18. 08 Aug, 2018 2 commits
  19. 07 Aug, 2018 1 commit
  20. 06 Aug, 2018 1 commit
    • Sathya Gunasekaran's avatar
      [Intl] Optimize Intl.PluralRules · cdb4d913
      Sathya Gunasekaran authored
      Previously, Intl.PluralRules was mostly implemented in JavaScript. This
      patch moves most of the constructor and parts of other methods to C++.
      
      The size of the Intl.PluralRules object is reduced by not storing
      MinimumIntegerDigits, MinimumFractionDigits, MaximumFractionDigits,
      MinimumSignificantDigits, MaximumSignificantDigits. Instead these are
      looked up from icu::DecimalFormat as required.
      
      Another optimziation is that we don't create the result of
      resolvedOptions when the Intl.PluralRules object is constructed, but
      instead defer until this method is called. In the future, we may want
      to cache the result.
      
      This patch also cleans up several error handling paths that shouldn't
      happen with ICU and instead just crashes should it ever happen.
      
      Bug: v8:5751
      Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng
      Change-Id: I84c5aa6c25c35fe2d336693dee1b36bf3dcd4a79
      Reviewed-on: https://chromium-review.googlesource.com/1158701
      Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org>
      Reviewed-by: 's avatarMichael Starzinger <mstarzinger@chromium.org>
      Reviewed-by: 's avatarJungshik Shin <jshin@chromium.org>
      Reviewed-by: 's avatarCamillo Bruni <cbruni@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#54917}
      cdb4d913
  21. 01 Aug, 2018 1 commit
  22. 28 Jul, 2018 1 commit
    • Frank Tang's avatar
      Reland "[Intl] move localeCompare to C++" · 22c7dd2e
      Frank Tang authored
      This is a reland of 51ad234f
      
      With a manual layout rebaseline of js/fast/string-prototype-properties
      [1], this CL can be relanded without breaking the layout test.
      
      [1] https://chromium-review.googlesource.com/c/chromium/src/+/1154289
      also marks the test for skipping until this fix is rolled to Chromium.
      
      
      Original change's description:
      > [Intl] move localeCompare to C++
      >
      >
      > Bug: v8:7958
      > Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng
      > Change-Id: I84a27dda5205c8581a7ffe37213d685cc49974fa
      > Reviewed-on: https://chromium-review.googlesource.com/1144644
      > Commit-Queue: Frank Tang <ftang@chromium.org>
      > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#54740}
      
      TBR=ftang@chromium.org, gsathya@chromium.org
      
      Bug: v8:7958
      Test: layout test: js/fast/string-prototype-properties
      Change-Id: Ic546349fcbc935917ded018801f7d942e50565d5
      Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng
      Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng
      Reviewed-on: https://chromium-review.googlesource.com/1154247
      Commit-Queue: Jungshik Shin <jshin@chromium.org>
      Reviewed-by: 's avatarJungshik Shin <jshin@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#54772}
      22c7dd2e
  23. 27 Jul, 2018 2 commits
  24. 26 Jul, 2018 1 commit
  25. 19 Jul, 2018 1 commit
  26. 17 Jul, 2018 1 commit
  27. 10 Jul, 2018 1 commit
  28. 06 Jul, 2018 2 commits
  29. 05 Jul, 2018 2 commits
  30. 19 Jun, 2018 1 commit
  31. 15 Jun, 2018 1 commit
  32. 15 May, 2018 1 commit
  33. 14 May, 2018 1 commit