Skip to content

V
V8
Switch branch/tag
  1. 10 Aug, 2017 1 commit
  3. 02 Aug, 2017 1 commit
  5. 13 Jul, 2017 1 commit
  7. 10 Jul, 2017 1 commit
  9. 20 Jun, 2017 1 commit
    • Michael Starzinger's avatar
      [asm.js] Ensure coercion of imports is non-observable. · 21cbc914
      Michael Starzinger authored 
      This makes sure that the coercion of global import values to numbers
remains non-observable to JavaScript. It allows instantiation failures
to fall back to JavaScript proper without accidentally causing some
side-effect to happen twice. Also coercions might invalidate previous
checks done during linking or throw exceptions.

R=clemensh@chromium.org
TEST=mjsunit/regress/regress-6431
BUG=v8:6431

Change-Id: Ibe2f7a336bc0fb25532d526746ecc802e04bbd5c
Reviewed-on: https://chromium-review.googlesource.com/512544
Commit-Queue: Michael Starzinger <mstarzinger@chromium.org>
Reviewed-by: 's avatarClemens Hammacher <clemensh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#46051}
      21cbc914
  11. 01 Jun, 2017 1 commit
  13. 23 May, 2017 1 commit
  15. 12 May, 2017 1 commit
  17. 11 May, 2017 1 commit
  19. 10 May, 2017 2 commits
  21. 09 May, 2017 1 commit
  23. 05 May, 2017 1 commit
  25. 04 May, 2017 1 commit
  27. 03 May, 2017 1 commit
  29. 27 Apr, 2017 1 commit
  31. 26 Apr, 2017 2 commits
  33. 25 Apr, 2017 1 commit
  35. 21 Apr, 2017 1 commit
  37. 13 Apr, 2017 1 commit
    • Michael Starzinger's avatar
      [asm.js] Test and fix "|0" annotation of calls. · f0946038
      Michael Starzinger authored 
      This fixes the validation of "|0" annotations of call sites that are
used to indicate a "signed" return type of functions. We use lookahead
during call validation and request deferred validation as part of the
actual OR-expression. Special care has to be taken to get precedence
levels of all involved operators right.

R=clemensh@chromium.org
TEST=mjsunit/asm/call-annotation
BUG=v8:6183

Change-Id: If0586f669e7cee26a13425b0fd9f41098e852d68
Reviewed-on: https://chromium-review.googlesource.com/475871
Commit-Queue: Michael Starzinger <mstarzinger@chromium.org>
Reviewed-by: 's avatarClemens Hammacher <clemensh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#44639}
      f0946038
  39. 11 Apr, 2017 1 commit
  41. 28 Mar, 2017 3 commits
    • bradnelson's avatar
      [wasm][asm.js] Fix and enable several asm.js tests with the new parser. · a84da1c3
      bradnelson authored 
      Fix a few items broken during review of scanner + parser:
* Make the scanner retain stale newline state on a rewind (as otherwise it must be able to correctly rewind that too, though it doesn't need it). (Probably should revisit).
* Change StashCode in the builder skip to the zero case, as it crashes for some reason (added TODO).

Also fix:
* Drop test based on constant expression evaluation in main parser
* Support constant defined based on existing constant.
* Type constants as signed.
* Added a check that all used functions are defined eventually.
* Zone allocate strings for simplicity (TODOs to refactor better).

BUG=v8:6090
BUG=v8:4203
R=mstarzinger@chromium.org,marja@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2771183002
Cr-Original-Commit-Position: refs/heads/master@{#44200}
Committed: https://chromium.googlesource.com/v8/v8/+/be0dbdd679b60c31d480d7635e579787a6a218df
Review-Url: https://codereview.chromium.org/2771183002
Cr-Commit-Position: refs/heads/master@{#44203}
      a84da1c3
    • bradnelson's avatar
      Revert of [wasm][asm.js] Fix and enable several asm.js tests with the new... · f8973f1c
      bradnelson authored 
      Revert of [wasm][asm.js] Fix and enable several asm.js tests with the new parser. (patchset #10 id:180001 of https://codereview.chromium.org/2771183002/ )

Reason for revert:
Fails on gc-stress.

Original issue's description:
> [wasm][asm.js] Fix and enable several asm.js tests with the new parser.
>
> Fix a few items broken during review of scanner + parser:
> * Make the scanner retain stale newline state on a rewind (as otherwise it must be able to correctly rewind that too, though it doesn't need it). (Probably should revisit).
> * Change StashCode in the builder skip to the zero case, as it crashes for some reason (added TODO).
>
> Also fix:
> * Drop test based on constant expression evaluation in main parser
> * Support constant defined based on existing constant.
> * Type constants as signed.
> * Added a check that all used functions are defined eventually.
> * Zone allocate strings for simplicity (TODOs to refactor better).
>
> BUG=v8:6090
> BUG=v8:4203
> R=mstarzinger@chromium.org,marja@chromium.org,vogelheim@chromium.org
>
> Review-Url: https://codereview.chromium.org/2771183002
> Cr-Commit-Position: refs/heads/master@{#44200}
> Committed: https://chromium.googlesource.com/v8/v8/+/be0dbdd679b60c31d480d7635e579787a6a218df

TBR=clemensh@chromium.org,bradnelson@google.com,marja@chromium.org,mstarzinger@chromium.org,vogelheim@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:6090

Review-Url: https://codereview.chromium.org/2782613002
Cr-Commit-Position: refs/heads/master@{#44201}
      f8973f1c
    • bradnelson's avatar
      [wasm][asm.js] Fix and enable several asm.js tests with the new parser. · be0dbdd6
      bradnelson authored 
      Fix a few items broken during review of scanner + parser:
* Make the scanner retain stale newline state on a rewind (as otherwise it must be able to correctly rewind that too, though it doesn't need it). (Probably should revisit).
* Change StashCode in the builder skip to the zero case, as it crashes for some reason (added TODO).

Also fix:
* Drop test based on constant expression evaluation in main parser
* Support constant defined based on existing constant.
* Type constants as signed.
* Added a check that all used functions are defined eventually.
* Zone allocate strings for simplicity (TODOs to refactor better).

BUG=v8:6090
BUG=v8:4203
R=mstarzinger@chromium.org,marja@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2771183002
Cr-Commit-Position: refs/heads/master@{#44200}
      be0dbdd6
  43. 14 Mar, 2017 1 commit
  45. 28 Feb, 2017 1 commit
  47. 14 Feb, 2017 1 commit
    • clemensh's avatar
      [asm] Fix lots of invalid asm.js tests · be1a5f75
      clemensh authored 
      I identified lots of asm.js tests that are actually not valid according
to the spec, hence they execute in default-javascript-mode.
This CL fixes most of them by adding additional type annotations.

The atomic tests are totally non-spec-compliant by expecting a fourth
argument, and infinite-loops-taken expects a function-type parameter,
so I did not fix those.
I also did not fix the regression tests.

R=titzer@chromium.org, bradnelson@chromium.org
BUG=v8:4203

Review-Url: https://codereview.chromium.org/2663243002
Cr-Commit-Position: refs/heads/master@{#43179}
      be1a5f75
  49. 08 Feb, 2017 1 commit
  51. 28 Jan, 2017 1 commit
  53. 26 Jan, 2017 1 commit
  55. 18 Jan, 2017 2 commits
  57. 10 Jan, 2017 3 commits
  59. 12 Dec, 2016 3 commits
  61. 09 Dec, 2016 1 commit