1. 27 Nov, 2018 1 commit
  2. 10 Aug, 2018 1 commit
    • Bret Sepulveda's avatar
      Escape backslashes when logging. · f642de00
      Bret Sepulveda authored
      Log::MessageBuilder was already escaping most unsafe characters when
      they were being logged, but plain backslashes were not. Merely updating
      the existing escaping path was not sufficient, as recursion would cause
      escape codes to be doubly escaped. This patches refactors the API to
      ensure incoming text is escaped exactly once.
      
      Bug: v8:8039
      Change-Id: Id48aabf29fb6153189ae4a1ad7dfaaf4b41b62ad
      Reviewed-on: https://chromium-review.googlesource.com/1169049Reviewed-by: 's avatarCamillo Bruni <cbruni@chromium.org>
      Commit-Queue: Bret Sepulveda <bsep@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#55038}
      f642de00
  3. 05 Jul, 2018 1 commit
  4. 03 May, 2018 2 commits
  5. 20 Dec, 2017 2 commits
  6. 02 Dec, 2017 1 commit
    • Mathias Bynens's avatar
      Normalize casing of hexadecimal digits · 822be9b2
      Mathias Bynens authored
      This patch normalizes the casing of hexadecimal digits in escape
      sequences of the form `\xNN` and integer literals of the form
      `0xNNNN`.
      
      Previously, the V8 code base used an inconsistent mixture of uppercase
      and lowercase.
      
      Google’s C++ style guide uses uppercase in its examples:
      https://google.github.io/styleguide/cppguide.html#Non-ASCII_Characters
      
      Moreover, uppercase letters more clearly stand out from the lowercase
      `x` (or `u`) characters at the start, as well as lowercase letters
      elsewhere in strings.
      
      BUG=v8:7109
      TBR=marja@chromium.org,titzer@chromium.org,mtrofin@chromium.org,mstarzinger@chromium.org,rossberg@chromium.org,yangguo@chromium.org,mlippautz@chromium.org
      NOPRESUBMIT=true
      
      Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_chromium_rel_ng
      Change-Id: I790e21c25d96ad5d95c8229724eb45d2aa9e22d6
      Reviewed-on: https://chromium-review.googlesource.com/804294
      Commit-Queue: Mathias Bynens <mathias@chromium.org>
      Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#49810}
      822be9b2
  7. 14 Nov, 2017 1 commit
  8. 03 Nov, 2017 1 commit
  9. 30 Oct, 2017 1 commit
  10. 27 Oct, 2017 1 commit
  11. 24 Oct, 2017 1 commit
  12. 20 Oct, 2017 4 commits
  13. 18 Oct, 2017 1 commit
  14. 13 Oct, 2017 1 commit
  15. 05 Oct, 2017 1 commit
  16. 28 Jul, 2017 2 commits
  17. 21 Jan, 2017 2 commits
  18. 10 Jan, 2017 2 commits
    • hablich's avatar
      Revert of [build] Introduce an embedder version string (patchset #2 id:20001... · f3026389
      hablich authored
      Revert of [build] Introduce an embedder version string (patchset #2 id:20001 of https://codereview.chromium.org/2619213002/ )
      
      Reason for revert:
      Seems to break the Chromium build: https://codereview.chromium.org/2619193005/
      
      Message:
      
      [1832/9671] CXX obj/v8/v8_base/version.o
      FAILED: obj/v8/v8_base/version.o
      /b/c/cipd/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/v8/v8_base/version.o.d -DV8_DEPRECATION_WARNINGS -DDCHECK_ALWAYS_ON=1 -DUSE_UDEV -DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_AURA=1 -DUSE_PANGO=1 -DUSE_CAIRO=1 -DUSE_GLIB=1 -DUSE_NSS_CERTS=1 -DUSE_X11=1 -DUSE_PROPRIETARY_CODECS -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD -DENABLE_MEDIA_ROUTER=1 -DFIELDTRIAL_TESTING_ENABLED -DCR_CLANG_REVISION=289944-2 -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DV8_I18N_SUPPORT -DENABLE_HANDLE_ZAPPING -DV8_USE_EXTERNAL_STARTUP_DATA -DV8_TARGET_ARCH_X64 -DDEBUG -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DU_STATIC_IMPLEMENTATION -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_FILE -I../.. -Igen -I../../v8 -I../../v8/include -I../../third_party/icu/source/common -I../../third_party/icu/source/i18n -fno-strict-aliasing --param=ssp-buffer-size=4 -fstack-protector -funwind-tables -fPIC -pipe -B../../third_party/binutils/Linux_x64/Release/bin -fcolor-diagnostics -fdebug-prefix-map=/b/c/b/linux/src=. -m64 -march=x86-64 -pthread -g1 --sysroot=../../build/linux/debian_wheezy_amd64-sysroot -fvisibility=hidden -Xclang -load -Xclang ../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so -Xclang -add-plugin -Xclang find-bad-constructs -Xclang -plugin-arg-find-bad-constructs -Xclang check-ipc -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -Werror -Wall -Wno-unused-variable -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-covered-switch-default -Wno-deprecated-register -Wno-unneeded-internal-declaration -Wno-inconsistent-missing-override -Wno-shift-negative-value -Wno-undefined-var-template -Wno-nonportable-include-path -Wno-address-of-packed-member -Wsign-compare -Winconsistent-missing-override -Wshorten-64-to-32 -O3 -fno-ident -fdata-sections -ffunction-sections -fno-threadsafe-statics -fvisibility-inlines-hidden -std=gnu++11 -fno-rtti -fno-exceptions -Wno-deprecated -c ../../v8/src/version.cc -o obj/v8/v8_base/version.o
      ../../v8/src/version.cc:42:34: error: use of undeclared identifier 'V8_EMBEDDER_STRING'
      const char* Version::embedder_ = V8_EMBEDDER_STRING;
                                       ^
      1 error generated.
      
      Original issue's description:
      > [build] Introduce an embedder version string
      >
      > Sometimes, the embedder might want to merge a fix to an abandoned branch
      > or to a supported branch but the fix is not relevant to Chromium.
      > This adds a new version string that the embedder can set on compile time
      > and that will be appended to the official V8 version.
      > The separator must be provided in the string. For instance, to have a
      > full version string like "5.5.372.37.custom.1", the embedder must set
      > V8_EMBEDDER_STRING to ".custom.1".
      >
      > Related Node.js issue: https://github.com/nodejs/node/pull/9754
      >
      > BUG=v8:5740
      > R=machenbach@chromium.org,hablich@chromium.com,ofrobots@google.com
      >
      > Review-Url: https://codereview.chromium.org/2619213002
      > Cr-Commit-Position: refs/heads/master@{#42175}
      > Committed: https://chromium.googlesource.com/v8/v8/+/fc86d4329b253bf21c1dd85469f1ef4b6e5ba01a
      
      TBR=hablich@chromium.com,machenbach@chromium.org,ofrobots@google.com,mic.besace@gmail.com
      # Skipping CQ checks because original CL landed less than 1 days ago.
      NOPRESUBMIT=true
      NOTREECHECKS=true
      NOTRY=true
      BUG=v8:5740
      
      Review-Url: https://codereview.chromium.org/2621033002
      Cr-Commit-Position: refs/heads/master@{#42182}
      f3026389
    • mic.besace's avatar
      [build] Introduce an embedder version string · fc86d432
      mic.besace authored
      Sometimes, the embedder might want to merge a fix to an abandoned branch
      or to a supported branch but the fix is not relevant to Chromium.
      This adds a new version string that the embedder can set on compile time
      and that will be appended to the official V8 version.
      The separator must be provided in the string. For instance, to have a
      full version string like "5.5.372.37.custom.1", the embedder must set
      V8_EMBEDDER_STRING to ".custom.1".
      
      Related Node.js issue: https://github.com/nodejs/node/pull/9754
      
      BUG=v8:5740
      R=machenbach@chromium.org,hablich@chromium.com,ofrobots@google.com
      
      Review-Url: https://codereview.chromium.org/2619213002
      Cr-Commit-Position: refs/heads/master@{#42175}
      fc86d432
  19. 14 Oct, 2016 1 commit
  20. 06 Jun, 2016 1 commit
  21. 24 May, 2016 1 commit
  22. 12 Apr, 2016 1 commit
  23. 11 Apr, 2016 2 commits
  24. 08 Apr, 2016 2 commits
    • jfb's avatar
      Revert of Fix printf formats (patchset #8 id:140001 of... · 4c4fdc2d
      jfb authored
      Revert of Fix printf formats (patchset #8 id:140001 of https://codereview.chromium.org/1869433004/ )
      
      Reason for revert:
      One small issue easily fixed here: https://codereview.chromium.org/1867333003/
      
      But it looks like MSVS 2013 doesn't like some of the formats and exists with the unhelpful:
      Stderr:
      f:\dd\vctools\crt\crtw32\stdio\output.c(1125) : Assertion failed: ("Incorrect
      format specifier", 0)
      
      It's easier to revert for now, I'll dig more into the docs:
      https://msdn.microsoft.com/en-us/library/56e442dc(v=vs.120).aspx
      https://msdn.microsoft.com/en-us/library/tcxf1dw6(v=vs.120).aspx
      
      And then resubmit, making sure I run these bots.
      
      Original issue's description:
      > Fix printf formats
      >
      > The usage of __attribute__((format(x, y)) was either wrong or missing from multiple functions, leading to erroneous formats. This CL:
      >
      >  - Imports PRINTF_FORMAT macro from Chrome's src/base/compiler-specific.h.
      >  - Uses it appropriately.
      >  - Imports Chrome's base/format_macros.h mainly to fix size_t formats (further cleanup could be done).
      >  - Fixes a bunch of incorrect formats.
      >
      > R= jochen@chromium.org, bmeurer@chromium.org, yangguo@chromium.org, ahaas@chromium.org
      >
      > Committed: https://crrev.com/6ebf9fbb93d31f9be41156a3325d58704ed4933d
      > Cr-Commit-Position: refs/heads/master@{#35365}
      
      TBR=jochen@chromium.org,bmeurer@chromium.org,yangguo@chromium.org,ahaas@chromium.org
      # Skipping CQ checks because original CL landed less than 1 days ago.
      NOPRESUBMIT=true
      NOTREECHECKS=true
      NOTRY=true
      
      Review URL: https://codereview.chromium.org/1867383002
      
      Cr-Commit-Position: refs/heads/master@{#35366}
      4c4fdc2d
    • jfb's avatar
      Fix printf formats · 6ebf9fbb
      jfb authored
      The usage of __attribute__((format(x, y)) was either wrong or missing from multiple functions, leading to erroneous formats. This CL:
      
       - Imports PRINTF_FORMAT macro from Chrome's src/base/compiler-specific.h.
       - Uses it appropriately.
       - Imports Chrome's base/format_macros.h mainly to fix size_t formats (further cleanup could be done).
       - Fixes a bunch of incorrect formats.
      
      R= jochen@chromium.org, bmeurer@chromium.org, yangguo@chromium.org, ahaas@chromium.org
      
      Review URL: https://codereview.chromium.org/1869433004
      
      Cr-Commit-Position: refs/heads/master@{#35365}
      6ebf9fbb
  25. 14 Aug, 2015 1 commit
  26. 01 Jun, 2015 1 commit
  27. 16 Dec, 2014 1 commit
  28. 04 Aug, 2014 1 commit
  29. 14 Jul, 2014 1 commit
  30. 30 Jun, 2014 1 commit