- 26 May, 2020 25 commits
-
-
Daniel Clifford authored
There was a legacy place in map code that wasn't fully ported to use the strong, new SloppyArgumentsElements type because of code that used hard-coded constants. Bug: chromium:1086470 Change-Id: Ieba152e4bd92c89125f831949c2efb4f4219f95c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2215059Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Daniel Clifford <danno@chromium.org> Cr-Commit-Position: refs/heads/master@{#67984}
-
Ng Zhi An authored
See https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-override.html for more on this warning. Bug: v8:10488 Change-Id: Ia2bf5c1ec84dd4473d0e013ec3d22548b38a0578 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2211190Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#67983}
-
Ng Zhi An authored
Making them private was a way to hide them, we can explicitly delete them, which give a better compilation error message as well. Also see: https://stackoverflow.com/q/55205874 Bug: v8:10488 Change-Id: Ieffa05951aeefc0225f8fb84e756eb67353e57a3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2211184Reviewed-by:
-
Seth Brenith authored
VisitWord32EqualImpl was checking for inputs of type kCompressedHeapConstant, but it can also sometimes have inputs of type kHeapConstant. In either case, we can check for whether to do a load from the roots array. This improves Octane score by about 3% (or about 1.5% if --no-opt is specified). Bug: v8:8948 Change-Id: Iab6c0b1dacd96c74e4cfb54c772aa92e5baf00ff Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2213081 Commit-Queue: Seth Brenith <seth.brenith@microsoft.com> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#67981}
-
Ng Zhi An authored
Making them private was a way to hide them, we can explicitly delete them, which give a better compilation error message as well. Also see: https://stackoverflow.com/q/55205874 Bug: v8:10488 Change-Id: I3f2b6881ae2252809c84fbd32ce0687e8328506e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2211182Reviewed-by:
-
Ng Zhi An authored
Recommended by clang-tidy's modernize-use-nullptr. Bug: v8:10488 Change-Id: I7cf26f7bda69b9b1a6bdabe274399b494f6d49ed Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2211155Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#67979}
-
Ng Zhi An authored
See https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-override.html for more on this warning. Bug: v8:10488 Change-Id: I66efe295b8a3372bc2e99516447f70d258520090 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2211185Reviewed-by:
-
Anton Bikineev authored
This reverts commit a35d0e8c. The original CL is likely not a culprit for the infra failures. Bug: chromium:1056170 Change-Id: I8fa85db8a737fb01328021782f0c43626fa52b0d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2215826Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Anton Bikineev <bikineev@chromium.org> Cr-Commit-Position: refs/heads/master@{#67977}
-
Tobias Tebbi authored
Bug: v8:7793 Change-Id: I5eac73a2b437e5e2d4005f79b7807ae7a9ed78e8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2214829Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#67976}
-
Milad Farazmand authored
Change-Id: I5a93231b16c8291c87fce57062837dce886bc2f8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2216231Reviewed-by:
Junliang Yan <jyan@ca.ibm.com> Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#67975}
-
Santiago Aboy Solanes authored
Several tests were using them and we can dedup code. Change-Id: I4ef5ae5772856d1f36e965b6b62ff5895b4e04fb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2215173Reviewed-by:
Maya Lekova <mslekova@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#67974}
-
Maya Lekova authored
Bug: v8:9975 Change-Id: I51cbc83adecfa52959c991ed3c6f26cf4929c297 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2215175Reviewed-by:
Clemens Backes <clemensb@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#67973}
-
Seth Brenith authored
This reverts commit 4e5fabae. Reason for revert: performance regressions chromium:1085305, chromium:1084978 Original change's description: > [torque][cleanup] Use more precise field types in a few classes > > This change updates some Torque-defined classes to include more precise > field types where possible. It also updates those classes to use > @generateCppClass. One field was removed because it's unused > (PrototypeInfo::validity_cell), and two fields in StackFrameInfo > actually became less precise because they're based on Script::name, > which is an embedder-provided untyped Local<Value>. (Automatically > generated accessors pointed out this bug easily.) > > This change also includes a couple of minor fixes in Torque. > > Change-Id: Ib2bc6c7165bb3612b6d344c0686a94165a568277 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2199640 > Commit-Queue: Seth Brenith <seth.brenith@microsoft.com> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Tobias Tebbi <tebbi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#67907} TBR=ulan@chromium.org,tebbi@chromium.org,verwaest@chromium.org,seth.brenith@microsoft.com Change-Id: I720821d8dc84ea0d79eb137f1c2507f75df9a107 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2211322Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#67972}
-
Victor Gomes authored
This CL is a step towards reversing JS stack arguments for TurboFan. It does the following: 1. Add StackOrder to CallInterfaceDescriptor 2. Reverse arguments in TF backend for JS calls. 3. Cleanup TFJ builtins interface descriptors, since calls for these builtins already reverse the arguments, we don't need to reverse the interface descriptor anymore. Change-Id: Ie840b1757bf023aa381a7fa01cbe66e7cf90778f Bug: v8:10201 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2213440Reviewed-by:
-
Maya Lekova authored
This reverts commit 9a0e6bd5. Reason for revert: Speculative revert for https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20-%20builder/47777 Original change's description: > cppgc: Port concurrent sweeper > > This moves concurrent and incremental sweeping from Blink. This also > adds TestPlatform that makes it easier to test concurrent and > incremental sweeping. > > Drive-by: fix unmarking of large pages. > > Bug: chromium:1056170 > Change-Id: Ifd50ff67b9df17ff117a5f4d4eb5a2937d3023be > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2207132 > Commit-Queue: Anton Bikineev <bikineev@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Reviewed-by: Omer Katz <omerkatz@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#67969} TBR=ulan@chromium.org,mlippautz@chromium.org,bikineev@chromium.org,omerkatz@chromium.org Change-Id: I5530f11f7b8560116324bb156ba98e426c0feb35 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1056170 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2215057Reviewed-by:
-
Anton Bikineev authored
This moves concurrent and incremental sweeping from Blink. This also adds TestPlatform that makes it easier to test concurrent and incremental sweeping. Drive-by: fix unmarking of large pages. Bug: chromium:1056170 Change-Id: Ifd50ff67b9df17ff117a5f4d4eb5a2937d3023be Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2207132 Commit-Queue: Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Reviewed-by:
-
Dominik Inführ authored
With --stress-incremental-marking we want to start concurrent marking faster by also sweeping pages on incremental marking steps. Bug: v8:10315 Change-Id: Ie3fa04acc5e59a4b81c3351f4b522c78368bb1a6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2210247 Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by:
-
Dominik Inführ authored
Objects allocated on the background thread during incremental marking, need to be allocated black. This prevents concurrent marking to observe uninitialized objects. Bug: v8:10315 Change-Id: Ia4b05a2a72e4142c79b31a01cbf162a6599a18c0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2196347 Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by:
-
Clemens Backes authored
The Isolate is only used to access the wasm engine, and the accounting allocating. The latter is also linked directly from the wasm engine, and the engine is linked from the native module, to which the DebugInfoImpl already has access. Hence, this CL removes the redundant Isolate pointers, and just accesses the engine and the allocator via the NativeModule. R=thibaudm@chromium.org Change-Id: Ib51cee2d166443a34e22fa02e8ad1549328aaa7f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2214827Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#67966}
-
Clemens Backes authored
Triggering recompilation can reduce the number of outstanding recompilation functions. If it gets reduced to zero, we also need to trigger other callbacks waiting for recompilation to finish. This situation can happen if all recompiled code was already installed in the native module, but the compilation state was not updated yet via {OnFinishedUnits}. R=thibaudm@chromium.org Bug: v8:10557, chromium:1084369, v8:10359 Change-Id: Ib80ff110776cf284632303b0b23e4c6e63426411 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2214828Reviewed-by: -
Clemens Backes authored
The interpreter is still used for testing, but frame inspection is not wired any more. Hence this CL removes it. R=thibaudm@chromium.org Bug: v8:10389 Change-Id: If93928dd3996a19c1251a93d843034574d4c43ce Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2215165Reviewed-by:
-
Jakob Gruber authored
... and CallParameters::arity(). The construct arity contains the actual argument count, plus 2 for the target (the first input) and new target (the last input). This CL adds a named constant and a helper method for accessing arity without extra args. In the future we may want to remove the extra args from arity() altogether. Call arity is similar but includes the target and receiver. Bug: v8:10542,v8:8888 Change-Id: I850fa314f88c2bee9d4dcd87eac9295b2bf88281 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2208850 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#67963}
-
Jakob Gruber authored
If --turbo-nci is enabled, use unary op builtins with feedback collection during generic lowering. Bug: v8:8888 Change-Id: Ie32cfe1558a7fbada2ac69a99ef969097558bc89 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2209067 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Kim-Anh Tran authored
This adds the wasm instance to the module scope. The instance contains the exported entities that can now be inspected. Bug: chromium:1043034 Change-Id: I9236ac9c126f3bc4b1e056990fe34956bbe8ed6b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2213433 Commit-Queue: Kim-Anh Tran <kimanh@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#67961}
-
Manos Koukoutos authored
After all struct/array definitions are parsed, we need to check if all reference type indices are legal. We need to do it at the end because types can be mutually recursive. Bug: v8:7748 Change-Id: I5e6b5185e7d0c5e8d905b6833a2b9026ab630c01 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2214821 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
-
- 25 May, 2020 11 commits
-
-
Shu-yu Guo authored
Bug: v8:10552 Change-Id: I1160ff0f9d2c91bb3c2ad3e0d5e1f36953538420 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2211402Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/master@{#67959}
-
Clemens Backes authored
The interpreter is not used for debugging any more. Hence any breakpoint support and related functionality is dead code. This CL removes - the {SetBreakpoint} and {GetBreakpoint} methods, - the {break_pc_} field which holds the current pause position, - the {break_flags_} field which is used to break at function entry and after calls, - functions to modify {break_flags_}, - the dead {kInternalBreakpoint} and {kInvalidPc} constants (plus respective macros and enums), - the {orig_start} and {orig_end} fields (code is not being modified any more, so we just use {start} and {end} now), - the {PrepareStepIn} method, - the unimplemented {SetTracing} method, and - two tests that test breakpoints in the interpreter. R=thibaudm@chromium.org Bug: v8:10389 Change-Id: I52103c37516446e40d3dfa365d6b480a7c623577 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2215163 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by: -
Clemens Backes authored
If multiple isolates share the same module, and the debugger gets enabled, then we trigger tier down in each isolate separately. To avoid generating too much code, we only recompile functions that are not already in the right tier. This CL is only the first step towards an actual fix. Since we only check already installed code (and ignore compilations that are already scheduled), we might still compile the same functions multiple times. A second CL will make sure that only one recompilation is running at the same time. R=thibaudm@chromium.org Bug: chromium:1084369, v8:10359 Change-Id: Ic4f9afac1add0fe8ad9e5d68f22d3d41ba2e52be Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2213438Reviewed-by:
-
Jakob Gruber authored
This CL adds the new _WithFeedback variant of unary, binary, and compare operation builtins. Existing logic to do these operations is refactored s.t. it can be used by both ignition bytecode handlers and the new builtins. Note that the new builtins are not yet used. Follow-up CLs will hook them into generic lowering. Bug: v8:8888 Change-Id: Id77dbe74bdf3b3806b2aefdf1abe52c3d165a3a3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2208862 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#67956}
-
Andreas Haas authored
This CL introduces the SyncStreamingDecoder to support streaming compilation when --single-threaded is set. The SyncStreamingDecoder buffers all bytes it receives over {OnBytesReceived}, and compiles them synchronously upon {Finish}. In addition to introducing SyncStreamingDecoder, this CL does the following changes: * Redirect streaming compilation to the new streaming decoder if --no-wasm-async-compilation is set. This flag is set if --single-threaded is set. * Extend the test-streaming-compilation.cc tests to test also the new streaming decoder. R=thibaudm@chromium.org Bug: v8:10548 Change-Id: I807e291a6060067c9835de4adf82bcb00321d995 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2209053 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by: -
Daniel Clifford authored
Change-Id: I092c0d70bf517b4c714f5958b188d54030dd9774 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1932838 Commit-Queue: Daniel Clifford <danno@chromium.org> Reviewed-by:
-
Ross McIlroy authored
We can't consistently rewire the successor blocks of an unreachable node to disconnect them from the graph when we are trying to maintain the schedule. Instead simply leave the code there. As a future optimization we could add a proper scheduled dead code elimination phase which can deal with this. As a side-effect, one of the tests sees a int64 DeadValue, so add support for that in the instruction selector. BUG=chromium:1083272,chromium:1083763,chromium:1084953,v8:9684 Change-Id: I69a6feaeef4eae62110392e27ea848b28bccf787 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2209061 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
-
Manos Koukoutos authored
Failing to do so results in an error when generating the respective ValueType, since the index has to be encoded in 24 bits. Bug: v8:7748, chromium:1080444 Change-Id: Ifd1ce9744388b65f91dbd9eaeb497726c6cd207e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2214823 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#67952}
-
Junha Park authored
This patch added an IsValid method to StartupData which returns a boolean upon verifying a given snapshot matches the v8 version. Embedders can use this API now to check snapshots' versions. This was originally done by Snapshot::CheckVersion, which now simply runs Startup::IsValid. Bug: v8:8104 Change-Id: If555bcc55de4a05adf61798cd58d9ea8c8a71302 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2178091 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
-
Camillo Bruni authored
- Add button to select top-10 instance types per category - Right align category selection buttons - Lazily draw the graph for snappier UI - Pre-init instance variables in details-selection Change-Id: I61ea80d523c49215b9d418e66698a12cbc050316 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2210681 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#67950}
-
Andreas Haas authored
This CL also fixes a small bug in the update-wasm-spec-tests.sh script, as it was not able to handle proposals without additional core spec tests. It also disables a lot of tests. R=jkummerow@chromium.org bug:v8:10556 Change-Id: Ibd885350478de935dc67edb664715cfa64f1d8e1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2210248 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
-
- 22 May, 2020 1 commit
-
-
Seth Brenith authored
Sometimes CSA code carefully constructs a mask to check several bitfields at once. Thus far, such a check has been very awkward to write in Torque. This change adds a way to do so, using the non-short-circuiting binary `&` operator. So now you can write an expression that depends on several bitfields from a bitfield struct, like `x.a == 5 & x.b & !x.c & x.d == 2` (assuming b is a one-bit value), and it will be reduced to a single mask and equality check. To demonstrate a usage of this new reduction, this change ports the trivial macro IsSimpleObjectMap to Torque. I manually verified that the generated code for the builtin SetDataProperties, which uses that macro, is unchanged. Bug: v8:7793 Change-Id: I4a23e0005d738a6699ea0f2a63f9fd67b01e7026 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2183276 Commit-Queue: Seth Brenith <seth.brenith@microsoft.com> Reviewed-by:
-
- 21 May, 2020 3 commits
-
-
Ng Zhi An authored
From 10 to 8 instructions (each). We do this by using mi (instead of lt) and ls (instead of le), which check for strictly less than and greater than or unordered. That way we don't have to have an extra mov for NaN. Change-Id: I18ff876ac12b7097d73d6cbbb64de6c2a1148e43 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2208934Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#67947}
-
Ng Zhi An authored
These were changed in the renumbering https://github.com/WebAssembly/simd/blob/master/proposals/simd/NewOpcodes.md Bug: v8:10501 Change-Id: I4e98b0a482e18208b63f11a1675a90c9367a6d93 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2212682Reviewed-by:
-
Ng Zhi An authored
The proposal uses the lane shape, e.g. i64x2.anytrue, and we were using s1x2.anytrue in our opcodes. This was a legacy naming, because we were trying to bitpack the booleans. Now that we aren't doing that, rename these to be more consistent with the proposal. This was done with a straightforward sed script, changing both cpp code and also some comments in mjsunit test files. Bug: v8:10506 Change-Id: If077ed805de23520d8580d6b3b1906c80f67b94f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2207915 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
-
