- 07 Feb, 2019 8 commits
-
-
Tobias Tebbi authored
Bug: v8:7793 v8:8737 Change-Id: I186cb33eb2e84a47fcb0897978bde9c6dffb9df3 Reviewed-on: https://chromium-review.googlesource.com/c/1456044 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#59431}
-
Ulan Degenbaev authored
Some tests assume that kMaxRegularHeapObjectSize is close to the page size. They break if the constant is decreased to 16KB to stress young large objects. Bug: chromium:852420 Change-Id: I2542878810823f7a73019b1e451a080fcfc1f78f Reviewed-on: https://chromium-review.googlesource.com/c/1456043Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#59430}
-
Michael Starzinger authored
This adds a test case to check consistency of how an "unreachable" trap is handled by a surrounding "try" block in case those two operations are in different functions (i.e. not local to one function body). It also fixes a DCHECK for an as-of-yet untested interpreter state transition. R=clemensh@chromium.org TEST=cctest/test-run-wasm-exceptions BUG=v8:8729 Change-Id: I432c48d0bc664f7ab092aaafef6dfa29c5f262fd Reviewed-on: https://chromium-review.googlesource.com/c/1454605 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#59429}
-
Jakob Gruber authored
We've recently run into several platform- and compiler-specific errors and warnings about alignment. This tentatively implements AlignToDataAlignment for all platforms, which is used when setting up the v8_Default_embedded_blob_ v8_Default_embedded_blob_size_ variables. Bug: v8:6666,chromium:929205 Change-Id: I0cee09eda71551f8b7d14f4076da496057023146 Reviewed-on: https://chromium-review.googlesource.com/c/1458018 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#59428}
-
deepak1556 authored
When BUILDING_V8_SHARED in release builds __declspec(dllexport) causes generation of implicit constructors in the forwarding class while its deleted in TurboAssemblerBase, which leads to compilation errors like: In file included from gen/v8/v8_base_jumbo_6.cc:41: In file included from .\../../v8/src/interface-descriptors.cc:7: In file included from ../../v8\src/macro-assembler.h:40: ../../v8\src/x64/macro-assembler-x64.h(92,9): error: call to deleted constructor of 'v8::internal::TurboAssemblerBase' : TurboAssemblerBase(std::forward<Args>(args)...) {} ^ ~~~~~~~~~~~~~~~~~~~~~~~~ ../../v8\src/x64/macro-assembler-x64.h(536,25): note: in instantiation of function template specialization 'v8::internal::TurboAssembler::TurboAssembler<v8::internal::TurboAssembler>' requested here class V8_EXPORT_PRIVATE MacroAssembler : public TurboAssembler { ^ ../../v8\src/turbo-assembler.h(127,34): note: 'TurboAssemblerBase' has been explicitly marked deleted here DISALLOW_IMPLICIT_CONSTRUCTORS(TurboAssemblerBase); ^ 1 error generated. The original changes were made in https://chromium-review.googlesource.com/c/v8/v8/+/1414913 R=mstarzinger@chromium.org,jgruber@chromium.org,clemensh@chromium.org Bug: NONE Change-Id: I87a5a678b8bae13b3adc6f1c6ac0b9313ed18d85 Reviewed-on: https://chromium-review.googlesource.com/c/1454676 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: -
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/85b07e9..e148b4c Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/4fbc755..11e283f Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/67d70d2..61d0c29 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/215c4a1..1dc7541 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I578f4f74f4231faa0b959eb176d5f6c31f578437 Reviewed-on: https://chromium-review.googlesource.com/c/1457607Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#59426}
-
Frank Tang authored
Lazy initialize some data once. $ python -u tools/run_perf.py --binary-override-path out/x64.release/d8 --filter "JSTests/Intl" test/js-perf-test/JSTests.json INFO >>> Running suite: JSTests/Intl INFO >>> Stdout (#1): NewIntlCollator-Intl(Score): 2047 NewIntlDateTimeFormat-Intl(Score): 26.5 NewIntlNumberFormat-Intl(Score): 449 NewIntlPluralRules-Intl(Score): 670 NewIntlListFormat-Intl(Score): 1762 NewIntlRelativeTimeFormat-Intl(Score): 918 Compare to performance baseline scores in https://chromium-review.googlesource.com/c/v8/v8/+/1455717 Bug: chromium:928098 Change-Id: I7f213f50eb261474fb38d9592725a101939020d8 Reviewed-on: https://chromium-review.googlesource.com/c/1455727 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#59425}
-
Frank Tang authored
Just add tests so we can observe the number first. Got the following results $ python -u tools/run_perf.py --binary-override-path out/x64.release/d8 --filter "JSTests/Intl" test/js-perf-test/JSTests.json INFO >>> Running suite: JSTests/Intl INFO >>> Stdout (#1): NewIntlCollator-Intl(Score): 161 NewIntlDateTimeFormat-Intl(Score): 9.73 NewIntlNumberFormat-Intl(Score): 18.6 NewIntlPluralRules-Intl(Score): 18.5 NewIntlListFormat-Intl(Score): 19.4 NewIntlRelativeTimeFormat-Intl(Score): 18.7 Bug: chromium:928098 Change-Id: I59f28393af8f868de639dcb81a7b2f69ce2f0eba Reviewed-on: https://chromium-review.googlesource.com/c/1455717 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
-
- 06 Feb, 2019 32 commits
-
-
Sigurd Schneider authored
This unifies the RelocInfo::Visit method across architectures. Bug: v8:8562 Change-Id: I36fdfb2f456aebb4d69977bb84727c9b49b22f69 Reviewed-on: https://chromium-review.googlesource.com/c/1456106 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#59423}
-
Ulan Degenbaev authored
For the initial implementation we simply keep the capacity of the young large object space in sync with the capacity of the new space. The only subtlety is that we allow at least one large object independent from its size. So it may exceed the capacity of the space. This also fixes setting of the large page flags for incremental marking. Bug: chromium:852420 Change-Id: I12a9d4a7350464ca291710917ecad782ae73b8e1 Reviewed-on: https://chromium-review.googlesource.com/c/1456092 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
-
Sigurd Schneider authored
This reverts commit 78ed0e3f. Reason for revert: Weird breakage on https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux64%20GC%20Stress%20-%20custom%20snapshot/24063 Two tests should not run on GC stress, but this one is really curious: https://logs.chromium.org/logs/v8/buildbucket/cr-buildbucket.appspot.com/8922258236346866528/+/steps/Mjsunit/0/logs/templates/0 Original change's description: > Ship constant field tracking > > Bug: v8:8361 > Change-Id: I25c52c708517cf27add89e0c5c97e6d21abb2a9a > Reviewed-on: https://chromium-review.googlesource.com/c/1456089 > Reviewed-by: Igor Sheludko <ishell@chromium.org> > Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#59415} TBR=jarin@chromium.org,ishell@chromium.org Change-Id: I0017230c840f4ab712852ba338f0119503688ec9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:8361 Reviewed-on: https://chromium-review.googlesource.com/c/1456108Reviewed-by:
-
Toon Verwaest authored
Otherwise preparsed variables will cause unnecessary dynamic variable allocation, which is especially bad when we're preparsing top-level functions with references to other global variables. Change-Id: I2fa17dae8c1cc5264a26ddc8b8868de1d791b0ac Reviewed-on: https://chromium-review.googlesource.com/c/1456040 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#59420}
-
Sigurd Schneider authored
This reverts commit d7def900. Reason for revert: Breaks UBSan: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux64%20UBSan/4542 Besides undefined behavior, things were looking good! Original change's description: > Reland "[builtins] [turbofan] Refactor Float64Pow to use single implementation" > > This is a reland of I968a08cef6a6d49350aa79185b2c6fb856d15f23 > > Original change's description: > > [builtins] [turbofan] Refactor Float64Pow to use single implementation > > > > Remove platform-specific Float64Pow implementations and utils Pow in > > favor of a base::ieee754::pow implementation. > > > > This unifies the implementation of pow for the compiler, wasm, and > > runtime. > > > > Bug: v8:5848, v8:5086 > > Change-Id: I968a08cef6a6d49350aa79185b2c6fb856d15f23 > > Reviewed-on: https://chromium-review.googlesource.com/c/1403018 > > Commit-Queue: Clemens Hammacher <clemensh@chromium.org> > > Reviewed-by: Clemens Hammacher <clemensh@chromium.org> > > Reviewed-by: Georg Neis <neis@chromium.org> > > Reviewed-by: Yang Guo <yangguo@chromium.org> > > Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#59229} > > Bug: v8:5848, v8:5086 > Change-Id: I92f22ae03adafd9ad042e8d4bb406cbd5b5fb51e > Cq-Include-Trybots: luci.chromium.try:linux_chromium_ubsan_rel_ng > Reviewed-on: https://chromium-review.googlesource.com/c/1447854 > Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> > Reviewed-by: Clemens Hammacher <clemensh@chromium.org> > Reviewed-by: Georg Neis <neis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#59411} TBR=jkummerow@chromium.org,jarin@chromium.org,neis@chromium.org,jgruber@chromium.org,clemensh@chromium.org,bmeurer@chromium.org,me@gus.host Change-Id: I65c4bbd3ab7aaa1c396d182467c5a1fe6a639df5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:5848, v8:5086 Cq-Include-Trybots: luci.chromium.try:linux_chromium_ubsan_rel_ng Reviewed-on: https://chromium-review.googlesource.com/c/1456107Reviewed-by:
-
Junliang Yan authored
the DCHECK in set_constant_pool_offset fails due to the InstructionSize() needs builtin_index() Change-Id: Ia86b57ebc4901672dee3012ba931e0222933ec1d Reviewed-on: https://chromium-review.googlesource.com/c/1454265Reviewed-by:
-
Clemens Hammacher authored
We often use raw assertPromiseResult with {success == assertUnreachable} for that. Having a separate helper increases readability and allows us to generate consistent (and better) error messages. R=titzer@chromium.org Bug: chromium:926311 Change-Id: I507941eacaafe6c576098d7829a76b27384a4fb6 Reviewed-on: https://chromium-review.googlesource.com/c/1456039Reviewed-by:Ben Titzer <titzer@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#59417}
-
Sigurd Schneider authored
Bug: v8:8562 Change-Id: I6f7dcaf888d0012fba2798613523c45d584753d4 Reviewed-on: https://chromium-review.googlesource.com/c/1456102Reviewed-by:
-
Jaroslav Sevcik authored
Bug: v8:8361 Change-Id: I25c52c708517cf27add89e0c5c97e6d21abb2a9a Reviewed-on: https://chromium-review.googlesource.com/c/1456089Reviewed-by:
Igor Sheludko <ishell@chromium.org> Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#59415}
-
Georg Neis authored
This would enable us to move the computation to the serialization pass, while keeping the merging in the reducers. Bug: v8:7790 Change-Id: Ic1a4da7085e1c0ebe787a5c7ad79f0f09e7c3c76 Reviewed-on: https://chromium-review.googlesource.com/c/1452796Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#59414}
-
Igor Sheludko authored
This drops Read() and Slot() methods from UnalignedSlot and simplifies Deserializer::ReadDataCase() method. Bug: v8:8794, v8:8562 Change-Id: I8a1f62e7b36fb91e379e38d91bcbf5728d1c5471 Reviewed-on: https://chromium-review.googlesource.com/c/1456099 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
This is a reland of 84d6864a. Timeout fixed by any of https://crrev.com/c/1454484 or updated chromium lkgr. Original change's description: > [wasm] Reenable code logging > > Code logging was fixed in https://crrev.com/c/1454598. Reenable it. > > R=mstarzinger@chromium.org > CC=herhut@chromium.org > > Bug: v8:8783 > Change-Id: I50773d4b42ce52e8d078e47a797ab517771c2756 > Reviewed-on: https://chromium-review.googlesource.com/c/1454601 > Commit-Queue: Clemens Hammacher <clemensh@chromium.org> > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#59394} Tbr: mstarzinger@chromium.org Bug: v8:8783 Change-Id: Ib6a7c079a73f90fbeeade17ef186742d2d30e0d3 Reviewed-on: https://chromium-review.googlesource.com/c/1456105Reviewed-by:
-
Gus Caplan authored
This is a reland of I968a08cef6a6d49350aa79185b2c6fb856d15f23 Original change's description: > [builtins] [turbofan] Refactor Float64Pow to use single implementation > > Remove platform-specific Float64Pow implementations and utils Pow in > favor of a base::ieee754::pow implementation. > > This unifies the implementation of pow for the compiler, wasm, and > runtime. > > Bug: v8:5848, v8:5086 > Change-Id: I968a08cef6a6d49350aa79185b2c6fb856d15f23 > Reviewed-on: https://chromium-review.googlesource.com/c/1403018 > Commit-Queue: Clemens Hammacher <clemensh@chromium.org> > Reviewed-by: Clemens Hammacher <clemensh@chromium.org> > Reviewed-by: Georg Neis <neis@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#59229} Bug: v8:5848, v8:5086 Change-Id: I92f22ae03adafd9ad042e8d4bb406cbd5b5fb51e Cq-Include-Trybots: luci.chromium.try:linux_chromium_ubsan_rel_ng Reviewed-on: https://chromium-review.googlesource.com/c/1447854 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#59411}
-
Igor Sheludko authored
Bug: v8:8794, v8:8562 Change-Id: I199b60150437c3a475a25c49c708058cd1371a1d Reviewed-on: https://chromium-review.googlesource.com/c/1456038 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Jaroslav Sevcik authored
This adds constant field tracking for arrays. To prevent changing the field in some other elements-kind-branch of transition tree, we only use the const information in the optimizing compiler if the map is not an array map or if the map is stable (since stable maps cannot transition to a different elements-kind-branch without deopt). Some more details: https://docs.google.com/document/d/1r2GAvdi_wudDS6iRUfdPw0gxWMfV-IX1PqKgwW47FyE Bug: chromium:912162, v8:8361 Change-Id: Iea1b2f03ddee16205c2141ac5e813a973dd23cf4 Reviewed-on: https://chromium-review.googlesource.com/c/1454606 Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> Reviewed-by:
-
Tamer Tas authored
V8 test suites return tests by loading them into memory up-front. Up-front loading has memory and loading-time overhead for the testrunner. This CL converts the test-suites to load tests during the test run in parallel. After CL, most test suites start running immediately and all test suites start running after 3 seconds on a modern SSD. This CL eliminates the 200 MiB memory spikes that causes memory problems in mac minis. Overhead of running test262 before CL: Line # Mem usage Increment Line Contents ================================================= 264 225.760 MiB 195.8.000 MiB tests = self._load_testsuite_generators(args, options) ------------------------------------------------- Overhead of running test262 after CL: Line # Mem usage Increment Line Contents ================================================ 264 28.840 MiB 0.000 MiB tests = self._load_testsuite_generators(args, options) ------------------------------------------------- R=machenbach@chromium.org CC=yangguo@chromium.org,sergiyb@chromium.org Bug: v8:8174, v8:8552, v8:8728 Change-Id: Iab540b9410239b05dc80b4a5228db25d8b8fb3b9 Reviewed-on: https://chromium-review.googlesource.com/c/1454478 Commit-Queue: Tamer Tas <tmrts@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Sergiy Belozorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#59408}
-
Yang Guo authored
This reverts commit 84d6864a. Reason for revert: Still observing failures with http/tests/wasm/wasm_worker_termination_while_compiling.html https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8-Blink%20Linux%2064/29821 Original change's description: > [wasm] Reenable code logging > > Code logging was fixed in https://crrev.com/c/1454598. Reenable it. > > R=mstarzinger@chromium.org > CC=herhut@chromium.org > > Bug: v8:8783 > Change-Id: I50773d4b42ce52e8d078e47a797ab517771c2756 > Reviewed-on: https://chromium-review.googlesource.com/c/1454601 > Commit-Queue: Clemens Hammacher <clemensh@chromium.org> > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#59394} TBR=mstarzinger@chromium.org,clemensh@chromium.org Change-Id: I1ec69d2dbcbb38744174827c0aa1a994dd0df7ea No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:8783 Reviewed-on: https://chromium-review.googlesource.com/c/1456086Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#59407}
-
Tobias Tebbi authored
Change-Id: Ibcac85442e755ceabd79cd87ebba7098b95a9182 Reviewed-on: https://chromium-review.googlesource.com/c/1454720Reviewed-by:
Simon Zünd <szuend@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#59406}
-
Simon Zünd authored
This CL adds a method to the factory which converts a stack trace frame represented by a FrameArray plus index, into a StackFrameInfo object. This factory method will later be used to lazily populate stack trace frames when they are retrieved via inspector API. Drive-by: Expose the script id in StackFrameBase. R=jgruber@chromium.org Bug: v8:8742 Change-Id: I79965e466370706593903f3d1a336ac29736f8ac Reviewed-on: https://chromium-review.googlesource.com/c/1454928 Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by:
-
Tobias Tebbi authored
Bug: v8:7793 Change-Id: Ifc2bf26e9d3bc13d4f2455d6d04ce5e2682626db Reviewed-on: https://chromium-review.googlesource.com/c/1454600Reviewed-by:
Daniel Clifford <danno@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#59404}
-
Daniel Clifford authored
Change-Id: I6bb75c72670043fafaf917c8ed3d146019d542df Reviewed-on: https://chromium-review.googlesource.com/c/1454727Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Daniel Clifford <danno@chromium.org> Cr-Commit-Position: refs/heads/master@{#59403}
-
Igor Sheludko authored
... rather than as a suffix. This avoids reading previous values which in turn will make things simpler from the pointer compression point of view in a sense that this is a step towards replacing UnalignedSlot with MaybeObjectSlot. Bug: v8:8794, v8:8562 Change-Id: I9a9b4a01f73b8058074d337b7e9e9f75fa1c9de0 Reviewed-on: https://chromium-review.googlesource.com/c/1456037 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Tobias Tebbi authored
Bug: v8:7793 Change-Id: I6e1fb19fb260350daca8351321a79d038b5fdbd3 Reviewed-on: https://chromium-review.googlesource.com/c/1436053Reviewed-by:
-
Clemens Hammacher authored
Creating the LogCodesTask and adding the code objects to it adds 10-20% to Liftoff compilation time. Thus cache whether code logging is needed per isolate, and avoid the overhead if that flag is false. R=mstarzinger@chromium.org Bug: v8:8783, chromium:928722 Change-Id: I059266da3309a4b1ed316016d0a55fa34f139057 Reviewed-on: https://chromium-review.googlesource.com/c/1454484 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Toon Verwaest authored
Change-Id: I2c8bd545dc606d76603bdf73f1ea54d4c04842c1 Reviewed-on: https://chromium-review.googlesource.com/c/1456101Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#59399}
-
Benedikt Meurer authored
This turns the previous compile time constant IC::kMaxPolymorphicMapCount into a runtime flag --max-polymorphic-map-count (defaults to 4 still), which makes it easier to play with different number of maps in POLYMORPHIC state. Bug: v8:8765 Change-Id: I86c04d9b2d8be21a3bc6b31f70b0bbc359067467 Reviewed-on: https://chromium-review.googlesource.com/c/1456097Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#59398}
-
Jakob Gruber authored
Change-Id: I77b811bbccbdb33028e03956342bd4aa2d68a087 Reviewed-on: https://chromium-review.googlesource.com/c/1456077Reviewed-by:
-
Daniel Bratell authored
src/assembler-arch-inl.h was deleted in November but it remained in the build system. This patch also removes it from the build system. Change-Id: Ib384943861156d603636dc3069130cd6c5dfd4ef Reviewed-on: https://chromium-review.googlesource.com/c/1456100Reviewed-by:
-
Simon Zünd authored
This CL allows the check for same security context to be disabled when deciding what frames to include in a stack trace. This flag will be needed to collect detailed stack traces in the same manner as simple ones. R=jgruber@chromium.org Bug: v8:8742 Change-Id: I99651ad11e11546d7bdba88367a0849e7b308dcb Reviewed-on: https://chromium-review.googlesource.com/c/1454719 Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
Code logging was fixed in https://crrev.com/c/1454598. Reenable it. R=mstarzinger@chromium.org CC=herhut@chromium.org Bug: v8:8783 Change-Id: I50773d4b42ce52e8d078e47a797ab517771c2756 Reviewed-on: https://chromium-review.googlesource.com/c/1454601 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Toon Verwaest authored
"this" is a very common expression. By using a single ThisExpression object we can both avoid allocating many unnecessary VariableProxies and specialize the resolution of this since we know where it's declared up-front. This also avoids having to special-case "this" reference handling in the paths that would behave differently for "this" than for regular references; e.g., with-scopes. The tricky pieces are due to DebugEvaluate and this/super() used as default parameters of arrow functions. In the former case we replace the WITH_SCOPE with FUNCTION_SCOPE so that we make sure that "this" is intercepted, and still rely on regular dynamic variable lookup. Arrow functions are dealt with by marking "this" use in ArrowHeadParsingScopes. If the parenthesized expression ends up being an arrow function, we force context allocate on the outer scope (and mark "has_this_reference" on the FUNCTION_SCOPE so DebugEvaluate in the arrow function can expose "this"). The CL also removes the now unused ThisFunction AST node. Change-Id: I0ca38ab92ff58c2f731e07db2fbe91df901681ef Reviewed-on: https://chromium-review.googlesource.com/c/1448313Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#59393}
-
Tamer Tas authored
http://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux%20-%20arm%20-%20sim%20-%20debug V8 Linux ARM SIM Debug bot runs into timeouts consistently in "Check - extra" suite shard#1 after 45 minutes (shard#1 and shard#2 run for 40~ minutes) due to unbalanced sharding. This CL increases the shard size for the bot R=yangguo@chromium.org CC=machenbach@chromium.org,sergiyb@chromium.org Bug: v8:8174 No-Try: true Change-Id: I47fdc2568ff93fb88eda5121d45b6f9d86e596a5 Reviewed-on: https://chromium-review.googlesource.com/c/1456096 Commit-Queue: Tamer Tas <tmrts@chromium.org> Reviewed-by:
-
