- 08 Jan, 2020 1 commit
-
-
Leszek Swirski authored
Most dead variable warnings in GCMole are false positives, either from failing to detect that TryEvacuateObject returning false means it didn't allocate, or a regex error thinking that GarbageCollectionReasonToString causes garbage collection (because the mangled version is something like GarbageCollectionReasonToString[...]GarbageCollectionReason, and that matches /Collect.*Garbage/). Update the whitelist and fix the "Collect.*Garbage" regex to only look at the function name. Bug: v8:9985 Change-Id: I62284e97e4975a6a87616d1d535b2ac7958d17bb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1989829 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Maya Lekova <mslekova@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#65622}
-
- 26 Nov, 2019 2 commits
-
-
Maya Lekova authored
This should help reduce the number of false positives detected by dead variable analysis. Bug: v8:9680, chromium:1000635 Change-Id: Id2893dd5f26cad230dede96930a5caacc0272b64 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1924359 Commit-Queue: Maya Lekova <mslekova@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#65186}
-
Maya Lekova authored
This CL ensures we care only about our internal pointer types and not about raw C++ pointers, because normally special care is taken when storing raw pointers to the managed heap. Furthermore, checking for raw pointers produces too many false positives in the dead variable analysis. Bug: v8:9680, chromium:1000635 Change-Id: Ica9ea1fe09b7456c011910a6886149b6dfdda1f5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1924357 Commit-Queue: Maya Lekova <mslekova@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#65174}
-
- 09 Sep, 2019 1 commit
-
-
Clemens Hammacher authored
The bot that runs gcmole was failing before https://crrev.com/c/1789707 because the test file was missing. It returned with exit status 0 anyway though. After fixing the original fault, this CL ensures that the gcmole tests also trigger an error on the bot(s) if they fail. R=mstarzinger@chromium.org CC=mslekova@chromium.org Change-Id: I29ae40301062baadfcd38b26c336c5749924b0d4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1789702 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#63612}
-
- 06 Sep, 2019 1 commit
-
-
Clemens Hammacher authored
Since we do not support gcc < 5 any more, we can switch to C++14 now. Gcmole is the only tool preventing this currently. R=mstarzinger@chromium.org Bug: v8:9687, v8:9690 Change-Id: Ie7fee25061bdf6f1e7f156bc150b7142c824f5d1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1787426Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#63595}
-
- 29 Aug, 2019 1 commit
-
-
Maya Lekova authored
Since this produces a few false positives, also implemented a whitelist mechanism to not report them. Also, add a couple of tests and implemented automated testing against test-expectations file. Bug: v8:9321 Change-Id: I2915a29fe1891e8bbc51118bbd95ae072c8de023 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1773243 Commit-Queue: Maya Lekova <mslekova@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#63456}
-
- 30 Aug, 2018 1 commit
-
-
Michael Lippautz authored
Revert "Reland "[heap] Attempt to incorporate backing store counters into heap sizing and GC trigger stragery."" This reverts commit eb164dbd. Revert "[d8] Fixed external gc test (limit multiplied by number of isolates)." This reverts commit 38cbc26a. Revert "[heap] Fixed typo in method name." This reverts commit 263174af. Bug: chromium:845409, chromium:879045 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I555bcff2ad04ae23368c7b3999a237083010f9c6 Reviewed-on: https://chromium-review.googlesource.com/1196550Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#55529}
-
- 28 Aug, 2018 1 commit
-
-
Rodrigo Bruno authored
Reland "[heap] Attempt to incorporate backing store counters into heap sizing and GC trigger stragery." This is a reland of ba735dde Original change's description: > [heap] Attempt to incorporate backing store counters into heap sizing and GC trigger stragery. > > Bug: chromium:845409 > Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng > Change-Id: Ic62a4339110e3dd2a6b1961a246e2bee0c07c03b > Reviewed-on: https://chromium-review.googlesource.com/1160162 > Commit-Queue: Rodrigo Bruno <rfbpb@google.com> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55128} Bug: chromium:845409 Change-Id: Iaff177f7bebbc073460fab0ae4e5cd9e632e1921 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Reviewed-on: https://chromium-review.googlesource.com/1177301Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Rodrigo Bruno <rfbpb@google.com> Cr-Commit-Position: refs/heads/master@{#55454}
-
- 16 Apr, 2018 1 commit
-
-
Daniel Clifford authored
An overview of motivation behind Torque and some of its principles can be found here: https://bit.ly/2qAI5Ep Note that there is quite a bit of work left to do in order to get Torque production-ready for any non-trivial amount of code, but landing the prototype as-is will allow for much faster iteration. Bugs will be filed for all of the big-ticket items that are not landing blockers but called out in this patch as important to fix. Cq-Include-Trybots: luci.v8.try:v8_linux_nosnap_rel;luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: Ib07af70966d5133dc57344928885478b9c6b8b73 Reviewed-on: https://chromium-review.googlesource.com/845682 Commit-Queue: Daniel Clifford <danno@chromium.org> Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#52618}
-
- 23 Jan, 2018 1 commit
-
-
Yang Guo authored
Bug: v8:7341 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I90879be3a94745859b7da7c9bb9b6533af11cc2d Reviewed-on: https://chromium-review.googlesource.com/878221Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#50790}
-
- 11 Aug, 2017 1 commit
-
-
Ross McIlroy authored
Deletes the now unused Full-codegen compiler. Also removes some macro assembler instructions which are no longer used. Note: there is still additional cleanup work to do after this lands (e.g., remove support for FCG frames support and FCG debugger support, etc.), but this will be done in followup CLs to keep this patch managable. BUG=v8:6409 Change-Id: I8d828fe7a64d29f2c1252d5fda968a630a2e9ef2 Reviewed-on: https://chromium-review.googlesource.com/584773 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#47307}
-
- 24 Apr, 2017 1 commit
-
-
Daniel Ehrenberg authored
- Split out code for Intl objects into src/objects/ - Rename i18n to intl (except for the name of the build flag) - Use build system more broadly to turn on/off Intl code - Delete a little bit of dead code Bug: v8:5751 Change-Id: I41bf2825a5cb0df20824922b17c24cae637984da Reviewed-on: https://chromium-review.googlesource.com/481284Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
Marja Hölttä <marja@chromium.org> Commit-Queue: Daniel Ehrenberg <littledan@chromium.org> Cr-Commit-Position: refs/heads/master@{#44801}
-
- 21 Sep, 2016 1 commit
-
-
machenbach authored
This also adds sources missing for PPC and x87, fixes a few missing files in gyp due to wrong quotation and a few that were simply not included. The gn files are now authoritative, but the gcmole gyp and gn source lists are enforced to match exactly. This additional enforcement helped finding the bugs above and will be removed when we deprecate the gyp files. BUG=614645 NOTRY=true Review-Url: https://codereview.chromium.org/2352103002 Cr-Commit-Position: refs/heads/master@{#39592}
-
- 28 Jun, 2016 1 commit
-
-
machenbach authored
This avoids forgetting to add files for either gyp or gn. While for most executables, this is detected by compilation errors, for test executables, it can lead to tests silently not running. BUG=chromium:474921 Review-Url: https://codereview.chromium.org/2098313002 Cr-Commit-Position: refs/heads/master@{#37331}
-
- 14 Jun, 2016 1 commit
-
-
mstarzinger authored
The pattern of how our source files are listed in GYP files changed, which in turn broke the parsing pattern that GCMole uses to gather a list of files to check. Only 'cctest' file were checked, 'src' files were being ignored. R=cbruni@chromium.org Review-Url: https://codereview.chromium.org/2065933002 Cr-Commit-Position: refs/heads/master@{#36962}
-
- 25 Apr, 2016 1 commit
-
-
machenbach authored
This will allow to pull in gyp as a deps to the same location as chromium (tools/gyp not build/gyp), needed for gn switch. This is the first step of a 3-way move. 1) Copy v8.gyp in v8 2) Update references in embedders (follow up) 3) Remove old v8.gyp (follow up) BUG=chromium:474921 LOG=n NOTRY=true Review URL: https://codereview.chromium.org/1920793002 Cr-Commit-Position: refs/heads/master@{#35760}
-
- 01 Mar, 2016 1 commit
-
-
jochen authored
BUG= R=yangguo@chromium.org Review URL: https://codereview.chromium.org/1748343002 Cr-Commit-Position: refs/heads/master@{#34381}
-
- 18 Feb, 2015 2 commits
-
-
machenbach authored
TBR=tandrii@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/931233002 Cr-Commit-Position: refs/heads/master@{#26724}
-
machenbach authored
NOTRY=true Review URL: https://codereview.chromium.org/935843003 Cr-Commit-Position: refs/heads/master@{#26723}
-
- 08 Aug, 2014 1 commit
-
-
svenpanne@chromium.org authored
Switching on C++11 features for gcmole might actually be a good idea... :-} TBR=mstarzinger@chromium.org Review URL: https://codereview.chromium.org/452073002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22991 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 07 Aug, 2014 1 commit
-
-
svenpanne@chromium.org authored
* Changes for 2.9: * Use CXX in Makefile instead of hardwired g++, we need a more modern GCC than 4.6 later, anyway. * Changes for 3.0: * Use llvm namespace. * Diagnostic => DiagnosticsEngine. * Changes for 3.1: * The BlockDeclRefExpr AST node is gone. * The structure of the CXXNewExpr AST node has changed. * Path changed from Release to Release+Asserts. * Use clang++ instead of -cc1, otherwise we lose the system include paths. * Changes for 3.2: none needed * Changes for 3.3: * Use lookup_iterator::begin/end instead of first/second. * Changes for 3.4: * createItaniumMangleContext => ItaniumMangleContext::create. * Changes for 3.5: * clang uses <type_traits> now, so -std=c++0x is needed. * Type-trait-related AST changes. * getCustomDiagID signature changed. * We must link the C++ library statically now. R=mstarzinger@chromium.org Review URL: https://codereview.chromium.org/445983002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22972 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 03 Jun, 2014 1 commit
-
-
jochen@chromium.org authored
TBR=mvstanton@chromium.org LOG=n BUG=none Review URL: https://codereview.chromium.org/310733005 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21631 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 17 Apr, 2014 1 commit
-
-
mstarzinger@chromium.org authored
R=rossberg@chromium.org Review URL: https://codereview.chromium.org/240933002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20841 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 25 Mar, 2014 1 commit
-
-
mstarzinger@chromium.org authored
R=ishell@chromium.org BUG= Review URL: https://codereview.chromium.org/210973003 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20237 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 13 Aug, 2013 2 commits
-
-
jochen@chromium.org authored
R=vegorov@chromium.org git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16170 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
jochen@chromium.org authored
BUG=none R=vegorov@chromium.org, vegorov@google.com Review URL: https://codereview.chromium.org/23011004 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16167 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 17 Jun, 2013 1 commit
-
-
mstarzinger@chromium.org authored
R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/16878003 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15187 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 22 Apr, 2013 1 commit
-
-
mstarzinger@chromium.org authored
R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/13956027 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14374 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 19 Apr, 2013 1 commit
-
-
mstarzinger@chromium.org authored
R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/14320024 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14350 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 17 Feb, 2012 1 commit
-
-
vegorov@chromium.org authored
Detect those methods by reference to StateTag::EXTERNAL in their bodies. R=fschneider@google.com Review URL: https://chromiumcodereview.appspot.com/9420046 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10738 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 13 Jul, 2011 1 commit
-
-
sgjesse@chromium.org authored
The preprocessor defines ENABLE_LOGGING_AND_PROFILING and ENABLE_VMSTATE_TRACKING has been removed as these where required to be turned on for Crankshaft to work. To re-enable reducing the binary size by leaving out heap and CPU profiler a new set of defines needs to be created. R=ager@chromium.org BUG=v8:1271 TEST=all Review URL: http://codereview.chromium.org//7350014 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8622 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 16 May, 2011 1 commit
-
-
vegorov@chromium.org authored
Fix various places in the code found by improved GCMole. Review URL: http://codereview.chromium.org/6973063 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@7895 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 07 Apr, 2011 1 commit
-
-
vegorov@chromium.org authored
GCMole is a simple static analysis tool that searches for GC-usafe evaluation order dependent callsites. Review URL: http://codereview.chromium.org/6812002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@7540 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-