Commits · f9a0e2eb2fb5baef5349644e598e9d878ef2cb61 · Linshizhi / V8

03 Jul, 2014 16 commits

kilvadyb@homejinni.com authored Jul 03, 2014

Port r22179 (01402bc)

Original commit message:
Note that until everything is OStream-based, there are a few places
where we have to do some impedance matching. A few accessors had to be
const-corrected on the way.

BUG=
R=palfia@homejinni.com

Review URL: https://codereview.chromium.org/369873002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22196 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

f9a0e2eb

Revert "Turn old space cons strings into regular external strings (not short)." · a0c10d11

yangguo@chromium.org authored Jul 03, 2014

This reverts commits r22192 and r22194.

TBR=hpayer@chromium.org

Review URL: https://codereview.chromium.org/367113003

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22195 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

a0c10d11

Fix changed expectation in Heap::AllowToBeMigrated. · a97789d6

yangguo@chromium.org authored Jul 03, 2014

R=hpayer@chromium.org

Review URL: https://codereview.chromium.org/364173004

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22194 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

a97789d6

Fix deopt reason printing to print stub failure reason with --trace-stub-failures --code-comments · dfa8df2f

jkummerow@chromium.org authored Jul 03, 2014

R=jarin@chromium.org

Review URL: https://codereview.chromium.org/369843002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22193 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

dfa8df2f

Turn old space cons strings into regular external strings (not short). · 6574f33d

yangguo@chromium.org authored Jul 03, 2014

R=hpayer@chromium.org

Review URL: https://codereview.chromium.org/368223002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22192 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

6574f33d

Error in CallFunctionNoFeedback ia32 made less efficient code. · bed08771

mvstanton@chromium.org authored Jul 03, 2014

R=mstarzinger@chromium.org
BUG=

Review URL: https://codereview.chromium.org/369503006

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22191 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

bed08771

add GetOwnPropertyDescriptor to api · 1859b040

dcarney@chromium.org authored Jul 03, 2014

R=verwaest@chromium.org

BUG=

Review URL: https://codereview.chromium.org/364923006

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22190 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

1859b040

Add an API to pump the message loop to libplatform · c1231d42

jochen@chromium.org authored Jul 03, 2014

BUG=none
LOG=n
R=marja@chromium.org

Review URL: https://codereview.chromium.org/363303002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22187 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

c1231d42

Fix result status of rerun flaky tests. · ba584456

machenbach@chromium.org authored Jul 03, 2014

Tests that pass on reruns where wrongly treated as failures. Now the result state can include any of (PASS, FAIL, CRASH, TIMEOUT)

BUG=374134
LOG=n
R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/363883003

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22186 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

ba584456

Hydrogenized KeyedLoadGeneric stub: Fix BuildDecodeField · 34eb0262

jkummerow@chromium.org authored Jul 03, 2014

R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/369673007

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22185 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

34eb0262

Hydrogenized KeyedLoadGeneric stub: Fix string hash retrieval · aca5038b

jkummerow@chromium.org authored Jul 03, 2014

R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/363293002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22184 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

aca5038b

Stack overflow checkers are now compatible with ASAN's detect_stack_use_after_return mode. · ff134a19

ishell@chromium.org authored Jul 03, 2014

BUG=chromium:376287
BUG=chromium:376262
BUG=chromium:369962
LOG=N
R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/368053002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22183 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

ff134a19

Don't even include v8.h from libbase or libplatform · 7b941432

jochen@chromium.org authored Jul 03, 2014

BUG=none
R=yangguo@chromium.org
LOG=n

Review URL: https://codereview.chromium.org/369073002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22182 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

7b941432

Buildfix for windows after r22180 · abb0ff20

jochen@chromium.org authored Jul 03, 2014

TBR=yangguo@chromium.org
LOG=n
BUG=none

Review URL: https://codereview.chromium.org/367293002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22181 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

abb0ff20

Split out libplatform into a separate libary · ca16bb7a

jochen@chromium.org authored Jul 03, 2014

Also remove the "use default platform" compile flag. Instead, the embedder
has to provide the platform.

Change all binaries to use the default platfrom from libplatform.

Unless --job-based-sweeping is passed, nothing uses the platform yet, so
nothing will break for embedders (yet).

BUG=none
R=jkummerow@chromium.org
LOG=y

Review URL: https://codereview.chromium.org/345903004

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22180 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

ca16bb7a

Start using OStreams. · d7934d1f

svenpanne@chromium.org authored Jul 03, 2014

Note that until everything is OStream-based, there are a few places
where we have to do some impedance matching. A few accessors had to be
const-corrected on the way.

R=mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/334763003

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22179 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

d7934d1f

02 Jul, 2014 24 commits

One of the fast cases in JSObject::MigrateFastToFast() should not be taken if... · 2fba1902

ishell@chromium.org authored Jul 02, 2014

One of the fast cases in JSObject::MigrateFastToFast() should not be taken if the number of fields did not change.

BUG=chromium:390918
LOG=N
R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/363073002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22174 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

2fba1902

Revert "Remove special ExecutableAccessorInfo handling based on flag" · a1dd1a26

verwaest@chromium.org authored Jul 02, 2014

Temporarily reverting until we figure out how to handle the API cases that use accessors to lazily compute values.
dataAttributeGetterCustom in V8MessageEventCustom (at least) overwrites itself with the computed value using ForceSet. We can either force such clients to first use ForceDelete before caching, use some other caching mechanism; or provide an API for lazily computed properties.

TBR=dcarney@chromium.org
BUG=

Review URL: https://codereview.chromium.org/365903005

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22173 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

a1dd1a26

Fix rerun barrier for flaky tests. · cf88d3c9

machenbach@chromium.org authored Jul 02, 2014

- The rerun flag doesn't include the first run.
- Timeout is an int. The division makes it 0 for small
numbers.

BUG=374134
LOG=n
R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/364793007

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22172 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

cf88d3c9

Remove special ExecutableAccessorInfo handling based on flag · 2350d461

verwaest@chromium.org authored Jul 02, 2014

This additionally removes special "prototype" handling for O.o, since it's broken; and added test.

BUG=
R=mvstanton@chromium.org

Review URL: https://codereview.chromium.org/368853003

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22171 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

2350d461

MIPS: Clean up the global object naming madness. · ec349cbf

kilvadyb@homejinni.com authored Jul 02, 2014

Port r22117 (e9244d6)

BUG=
R=palfia@homejinni.com

Review URL: https://codereview.chromium.org/364863002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22170 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

ec349cbf

Harden Runtime_LiveEditCheckAndDropActivations against unsafe args. · f353ff66

yangguo@chromium.org authored Jul 02, 2014

R=jarin@chromium.org
BUG=390925
LOG=N

Review URL: https://codereview.chromium.org/362983004

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22169 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

f353ff66

MIPS: KeyedLoadIC should have same register spec as LoadIC. · 7a8a44aa

kilvadyb@homejinni.com authored Jul 02, 2014

Port r22103 (2c36867)

Original commit message:
On arm, arm64 and x64 there is a different register specification between LoadIC and KeyedLoadIC.

It would be nicer if these are the same, allowing some key optimizations.

BUG=
R=palfia@homejinni.com

Review URL: https://codereview.chromium.org/367053002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22168 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

7a8a44aa

Reland^2 r22105 "Remove static initializer from isolate" · d8aefde6

jochen@chromium.org authored Jul 02, 2014

Make Isolate::UncheckedCurrent() return NULL if Isolate wasn't yet initialized
to avoid reentrancy when running with the profiler

BUG=none
R=dcarney@chromium.org
LOG=n

Review URL: https://codereview.chromium.org/365863003

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22167 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

d8aefde6

Reland "Fix stack trace accessor behavior." · 44d6ef37

yangguo@chromium.org authored Jul 02, 2014

BUG=v8:3404
LOG=N
R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/349033007

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22166 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

44d6ef37

Add clang-format to presubmit checks · b0956fb1

jochen@chromium.org authored Jul 02, 2014

The check doesn't modify the patch, instead, you'll have to use "git cl
format" manually.

BUG=none
R=danno@google.com, danno@chromium.org, jkummerow@chromium.org
LOG=y

Review URL: https://codereview.chromium.org/362263002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22165 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

b0956fb1

Make flag definition macros style guide compliant and clang-format it. · df6e1ac6

jochen@chromium.org authored Jul 02, 2014

coding style wants macros to be all upper case, and so clang-format only
detects those as macros.

BUG=none
R=jkummerow@chromium.org
LOG=n

Review URL: https://codereview.chromium.org/259573003

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22164 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

df6e1ac6

Allow yield expressions without a RHS. · 341d6186

wingo@igalia.com authored Jul 02, 2014

R=marja@chromium.org
BUG=

Review URL: https://codereview.chromium.org/348893007

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22163 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

341d6186

Stack traces exposed to Javascript should omit extensions. · a481d753

yangguo@chromium.org authored Jul 02, 2014

R=marja@chromium.org
BUG=v8:311
LOG=Y

Review URL: https://codereview.chromium.org/363893003

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22162 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

a481d753

Revert "Precisely sweep scan on scavenge pages and use heap iterator to iterate over them." · 1c6f0fa6

yangguo@chromium.org authored Jul 02, 2014

This reverts r22154.

TBR=hpayer@chromium.org

Review URL: https://codereview.chromium.org/365853003

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22159 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

1c6f0fa6

Wait for sweeper threads only if we have to, i.e. if we globally have to... · d4c07acd

hpayer@chromium.org authored Jul 02, 2014

Wait for sweeper threads only if we have to, i.e. if we globally have to finish sweeping or if we have to allocate from a certain space.
BUG=
R=ulan@chromium.org

Review URL: https://codereview.chromium.org/361983003

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22156 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

d4c07acd

Add more generator/yield parsing tests · 09660b00

wingo@igalia.com authored Jul 02, 2014

R=marja@chromium.org
BUG=

Review URL: https://codereview.chromium.org/362963002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22155 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

09660b00

Precisely sweep scan on scavenge pages and use heap iterator to iterate over them. · 4793ec3b

hpayer@chromium.org authored Jul 02, 2014

BUG=
R=jarin@chromium.org

Review URL: https://codereview.chromium.org/362313002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22154 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

4793ec3b

Fix: Parser::HandleSourceURLComments was making gcmole unhappy (rightfully). · be0d2fbe

marja@chromium.org authored Jul 02, 2014

R=yangguo@chromium.org
BUG=

Review URL: https://codereview.chromium.org/362243005

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22153 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

be0d2fbe

Fix platform-cygwin.cc to really not use an Isolate · 12808664

jochen@chromium.org authored Jul 02, 2014

BUG=none
R=jkummerow@chromium.org
LOG=n

Review URL: https://codereview.chromium.org/367953002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22152 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

12808664

Remove deprecated v8::Context::HasOutOfMemoryException. · 1f24d32b

yangguo@chromium.org authored Jul 02, 2014

LOG=Y
R=ulan@chromium.org

Review URL: https://codereview.chromium.org/369463005

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22151 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

1f24d32b

Revert "Reland "Linux perf tool support update + refactoring." (r22118)" · b6fcac16

yangguo@chromium.org authored Jul 02, 2014

This reverts r22146.

TBR=jarin@chromium.org

Review URL: https://codereview.chromium.org/366883004

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22150 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

b6fcac16

Mark mjsunit/migrations test in debug mode as TIMEOUT · 8bf1b45e

ishell@chromium.org authored Jul 02, 2014

Review URL: https://codereview.chromium.org/362953002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22149 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

8bf1b45e

ARM64: Reland faster immediate check · 91ba0153

m.m.capewell@googlemail.com authored Jul 02, 2014

Improve the code used to check for encodable logical immediates, fix some corner
cases associated with moving kWMinInt into W registers, and add tests.

BUG=
R=ulan@chromium.org

Review URL: https://codereview.chromium.org/364653003

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22148 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

91ba0153

Add information about rerun tests to json output. · 4d55c228

machenbach@chromium.org authored Jul 02, 2014

BUG=374134
LOG=n
R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/364793004

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22147 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

4d55c228