- 24 Jul, 2020 1 commit
-
-
Manos Koukoutos authored
Change-Id: I920a7b8aeda0d92eb0301962589a78e0258f33e5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2315986Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/master@{#69040}
-
- 21 Jul, 2020 1 commit
-
-
Manos Koukoutos authored
They have been replaced with {array,struct}.new_with_rtt. Also, rework tests that used those instructions. Bug: v8:7748 Change-Id: I2aaccb1958bf2b8d6cad4969abc612216856393d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2307318 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#68961}
-
- 16 Jul, 2020 1 commit
-
-
Jakob Kummerow authored
Bug: v8:7748 Change-Id: I30eb7b08b40159e399730eef5866e1f0fbf706e1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2299368 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#68892}
-
- 10 Jul, 2020 1 commit
-
-
Igor Sheludko authored
... by migrating old-style code MyObject* obj = new (zone) MyObject(...) to the new style MyObject* obj = zone->New<MyObject>(...) Bug: v8:10689 Change-Id: I2fc4a44ea05e4d087565811f343893f0e97dc660 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2288857 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#68789}
-
- 07 Jul, 2020 1 commit
-
-
Manos Koukoutos authored
- Remove fixed TODOs - Fix typo - Add a couple of types in subtyping tests Bug: v8:7748 Change-Id: I757fa60ffe4fe9f9361cf0c4e9ca88b31747459f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2282529 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#68700}
-
- 06 Jul, 2020 4 commits
-
-
Manos Koukoutos authored
Bug: v8:7748 Change-Id: Ie9b9fce6288418b95352637a708cbbf05bd0ddc3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2282528 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#68697}
-
Manos Koukoutos authored
Bug: v8:7748 Change-Id: I6bb37fe506b46da4d3df35df244581357498f6b8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2282527 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#68693}
-
Manos Koukoutos authored
Bug: v8:7748 Change-Id: Ia88596d8016ebb63d457cfc04f4feed8da37872e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2279550 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#68686}
-
Manos Koukoutos authored
Bug: v8:7748 Change-Id: Ic18a9ca8fcf21cf8b3dc7028cb95df95dbabf3d1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2275970 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#68684}
-
- 04 Jul, 2020 1 commit
-
-
Manos Koukoutos authored
Bug: v8:7748 Change-Id: I82cbe300223251342f65683522d8bfac1cbe88c7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2275968 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#68680}
-
- 03 Jul, 2020 1 commit
-
-
Igor Sheludko authored
Bug: v8:10506 Change-Id: I9405616566aaec47bfc47cfe2290dc6953e532ad Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2280082 Auto-Submit: Igor Sheludko <ishell@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#68669}
-
- 26 Jun, 2020 1 commit
-
-
Manos Koukoutos authored
Motivation: The immediate-argument classes defined in function-body-decoder.h were often adding an offset to the provided pc. This was inconsistent, bug-prone, and counterintuitive. This CL imposes that all immediates are passed as pc the start of the immediate argument they are parsing. Some other smaller inconsistencies are fixed as well. Changes: src/wasm/: - Enforce that all Immediates are passed the pc at the start of the argument they are parsing. Adapt all call sites. - Remove unneeded offset arguments from two SIMD related immediates. - Add a pc argument to all Validate functions for immediates instead of using the Decoder's current pc. - Remove the (unused) pc argument from all Complete functions for immediates. - Introduce Validate() for BranchOnExceptionImmediate. - In WasmDecoder::Decode(), make sure len is updated before breaking out of the loop in case of a Validate() failure. - Change the default prefix_len of DecodeLoadMem/DecodeStoreMem to 1. wasm-interpreter.cc: - Change the default prefix_len of ExecuteLoad/Store to 1. - Adapt offsets in calls to Immediates. - Remove redundant opcode_length argument from ExecuteSimdOp, use len in its place. function-body-decoder-unittest.cc - Adapt offsets in calls to Immediates. - Introduce and use EXPECT_OK, as is done in other tests. Change-Id: I534606c0e238af309804d4a7c8cec75b1e49c6ad Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2267381 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#68559}
-
- 25 Jun, 2020 1 commit
-
-
Clemens Backes authored
Local type information was stored in the {WasmFullDecoder}, and a pointer to that vector was handed to {WasmDecoder}. Since {WasmFullDecoder} inherits from {WasmDecoder}, we can just move the vector to the {WasmDecoder} class, and save an indirection and an unnecessary nullptr check. Drive-by: Rename {GetLocalType} to {local_type}, since it's a simple accessor. Drive-by 2: Move fields of {WasmDecoder} to the end of the class, as mandated in the style guide. Drive-by 3: Rename some locals in the 'let' decoding to make the meaning more clear. R=thibaudm@chromium.org Bug: v8:10576 Change-Id: I6ab9831f0c1955e47562e84c5fbf15807439b024 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2264360Reviewed-by: Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#68541}
-
- 24 Jun, 2020 1 commit
-
-
Clemens Backes authored
This allows the compiler to eliminate more unneeded branches. Since all functions just do a lookup in a static table (either directly, or via compiling a switch to such a lookup), they are also good candidates for inlining, which is made possible by this change. One DCHECK is removed instead of pulling in the inl header, which would require more refactoring since the check is in a non-inl header. R=thibaudm@chromium.org TBR=jkummerow@chromium.org Bug: v8:10576 Change-Id: If0fd25fd62c5f30b896fc67a5458a5ae475a6351 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2259944 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by: Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/master@{#68508}
-
- 23 Jun, 2020 1 commit
-
-
Andreas Haas authored
Due to recent spec changes, this CL removes the type immediate of ref.is_null again. Instead we check if the type of the input parameter is nullable. R=jkummerow@chromium.org Bug: v8:10556 Change-Id: If07d30fe4dd27664be7774422573b2ab2b0dfa20 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2247654 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#68484}
-
- 19 Jun, 2020 2 commits
-
-
Manos Koukoutos authored
Bug: v8:7748 Change-Id: I9af885e4c33541a8e065082ae7f07804bd11807a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2252190 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#68443}
-
Manos Koukoutos authored
This CL introduces one-letter shorthands to HeapTypes, and fixes signatures to be in sync with the ValueType and HeapType shorthands. Bug: v8:7748 Change-Id: I4cc8e26d6523074bc36bf2d29289e63a23e80ddc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2249672 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#68425}
-
- 18 Jun, 2020 1 commit
-
-
Manos Koukoutos authored
Motivation: Changes to the typed function references and gc proposals solidified the notion of heap type, clarified nullable vs. non-nullable reference types, and introduced rtts, which contain an integer depth field in addition to a heap type. This required us to overhaul our ValueType representation, which results in extensive changes. To keep this CL "small", we do not try to implement the binary encoding as described in the proposals, but rather devise a simpler one of our own (see below). Also, we do not try to implement additional functionality for the new types. Changes: - Introduce HeapType. Move heap types from ValueType to HeapType. - Introduce Nullability for reference types. - Rework ValueType helper methods. - Introduce rtts in ValueType with an integer depth field. Include depth in the ValueType encoding. - Make the constructor of ValueType private, instead expose static functions which explicitly state what they create. - Change every switch statement on ValueType::Kind. Sometimes, we need nested switches. - Introduce temporary constants in ValueTypeCode for nullable types, use them for decoding. - In WasmGlobalObject, split 'flags' into 'raw_type' and 'is_mutable'. - Change IsSubtypeOfRef to IsSubtypeOfHeap and implement changes in subtyping. - kWasmFuncRef initializers are now non-nullable. Initializers are only required to be subtypes of the declared global type. - Change tests and fuzzers as needed. Bug: v8:7748 Change-Id: If41f783bd4128443b07e94188cea7dd53ab0bfa5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2247657 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#68408}
-
- 12 Jun, 2020 1 commit
-
-
Manos Koukoutos authored
This function wasm created as a partial subtyping check after the subtyping refactoring for wasm-gc, but is really not needed. Change-Id: I5f3a38dba599f1571e26d29254eb0f8614c16a8b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2241519Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/master@{#68321}
-
- 10 Jun, 2020 1 commit
-
-
Manos Koukoutos authored
As per the latest update to the 'reference types' wasm proposal, the nullref type is removed. Following that, all its uses in V8 were also removed. This CL: - Removes now dead code referencing nullref. - Changes names of functions/exceptions containing 'nullref' to 'null'. - Changes nullref to the corresponding nullable type in some tests. Bug: v8:7748 Change-Id: I5b4606671d7b24dd48a45a3341e8a1c056fcd1d0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2238026 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#68283}
-
- 09 Jun, 2020 1 commit
-
-
Manos Koukoutos authored
The reference types wasm proposal dropped all subtyping. Subsequently, the 'anyref' type was renamed to externref. This changes all references of the *type* anyref to externref. Additionally, the flag that permits this extension is renamed to "reftypes" to mirror the proposal name. Bug: v8:7748 Change-Id: Icf323f13b9660fd10540e65125af053fca3a03f9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2232941 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by: Kim-Anh Tran <kimanh@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#68270}
-
- 05 Jun, 2020 2 commits
-
-
Manos Koukoutos authored
Changes: - Unpack packed typed in arrays/structs where needed. - i8 should have log-size 0. - Use typed-funcref feature flag instead of gc where appropriate. - Set argument indexes correctly for gc opcodes in function-body-decoder. - Remove no-longer valid TODOs. Bug: v8:7748 Change-Id: I1a73794d0f93da6c7177e496d47df4106031f0eb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2230520 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#68196}
-
Manos Koukoutos authored
Changes: - Remove subtyping checks from value-type.h and move them to dedicated files. Leave a limited version in value-type.h for testing. - Implement subtyping for struct and array types, according to the wasm-gc proposal. - Implement type equivalence checking. - Introduce a subtyping relation cache in WasmModule. - Rename IsSubTypeOf -> IsSubtypeOf. - Fix v8 possible bug where iterator_range took two unused type parameters. - Add unittests for subtyping. Bug: v8:7748 Change-Id: I0ddbda4145e0412196dcf4fc63f3c5875fb3ab5a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2228497 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#68192}
-
- 03 Jun, 2020 2 commits
-
-
Andreas Haas authored
All subtyping has been removed from the reference-types proposal. This CL implements this proposal change now in V8. R=manoskouk@chromium.org Bug: v8:10556 Change-Id: I08ef064952278e03ea655461fa9f0c96426157c7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2222345 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#68152}
-
Andreas Haas authored
With recent changes to the anyref proposal, null refs now have a type immediate which declares the type of a null ref constant. Likewise, the RefIsNull instruction is type aware now. This CL addresses these proposal changes now. R=jkummerow@chromium.org Bug: v8:10556 Change-Id: I810dfa3a4ab4389afc9639f897cee5d43e9b62cb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2215172 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#68141}
-
- 02 Jun, 2020 1 commit
-
-
Clemens Backes authored
In production, we will always pass a pointer to the decoded module. The only reason for the existance of the nullptr checks is that tests sometimes don't pass a module here. Hence we pay in production code for a test-only feature. This CL fixes this by always passing a module pointer from the decoder tests. This even simplifies the code a lot by removing redundant code. The {TestModuleBuilder} class was moved before the definitions of the {FunctionBodyDecoderTest} class in order to be able to reuse it there. It's unmodified otherwise. R=ahaas@chromium.org Bug: v8:10576 Change-Id: I7d876bfc8a27b50fe713afb8848fb4f642287cfa Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2226749Reviewed-by: Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#68116}
-
- 29 May, 2020 1 commit
-
-
Manos Koukoutos authored
Bug: v8:7748, chronium:1080444 Change-Id: I8d7e3cb8b3ea06001794fdda44faaff8e509e1b6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2219930 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#68071}
-
- 18 May, 2020 1 commit
-
-
Manos Koukoutos authored
Changes: Cleanup: - Make sure read_value_type has the same interface as other read_* functions, i.e., returns the decoded value and writes the consumed length into a pointer. - DecodeLocals is now an instance method. - DecodeLocals should fail when given a wrong number of locals. Add tests to catch that. - Fix a buggy test. Refactoring in preparation of introducing the 'let' instruction as per [wasm-gc]: - DecodeLocals does not consume any input and can start from any pc. - DecodeLocals gives the option of not appending the decoded locals to local_types_. - Separate locals initialization from signature. Bug: v8:7748 Change-Id: Iaaff87fdb9abe0ddd716484ea3fa87779d2d1a2f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2202992 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#67845}
-
- 06 May, 2020 1 commit
-
-
Manos Koukoutos authored
Motivation: There were three versions of type decoding for wasm in the codebase. Not all of them decoded gc types with immediates (reference types) correctly. Changes: - Refactor the wasm binary decoder for unify type decoding. - Update BranchTypeImmediate and SelectTypeImmediate to handle reference types. Reference: https://github.com/WebAssembly/gc R=jkummerow@chromium.org Bug: v8:7748 Change-Id: I33b38c911d366570ca6ef2723ded5205698e1979 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2179003 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#67614}
-
- 20 Apr, 2020 1 commit
-
-
Jakob Kummerow authored
Behind --experimental-wasm-gc flag. Bug: v8:7748 Change-Id: Ib96af9c5bde33f1b88862286a37872dbe70d856b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2154198 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#67251}
-
- 16 Apr, 2020 1 commit
-
-
Ng Zhi An authored
SIMD opcodes consist of the prefix byte, then an LEB128 encoded int. We were decoding this incorrectly as a fixed uint8. This fixes the decoder to properly handle multi bytes. In some cases, the multi byte logic is applied to all prefixed opcodes. This is not a problem, since for values < 0x80, the LEB encoding is a single byte, and decodes to the same int. If the prefix opcode has instructions with index >= 0x80, it would be required to be LEB128 encoded anyway. There are a bunch of trivial changes to test-run-wasm-simd, to change the macro from BUILD to BUILD_V, the former only works for single byte opcodes, the latter is a new template-based macro that correct handles multi-byte opcodes. The only unchanged test is the shuffle fuzzer test, which builds its own sequence of bytes without using the BUILD macro. Bug: v8:10258 Change-Id: Ie7377e899a7eab97ecf28176fd908babc08d0f19 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2118476 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#67186}
-
- 12 Mar, 2020 1 commit
-
-
Jakob Kummerow authored
In preparation for adding reference types, which need an additional parameter to indicate the referenced type. Bug: v8:7748 Change-Id: If4023f3d9c7f42ed603b69c43356d2e8b81a0daa Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2091471 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#66687}
-
- 27 Feb, 2020 1 commit
-
-
Clemens Backes authored
Most function signatures are created once and never changed. Hence pass them as const pointer. This makes it clear in function signatures that these parameters will not be modified. This also avoids a few ugly const_casts where we were passing pointers to constexpr FunctionSigs via non-const pointers. R=jkummerow@chromium.org Bug: v8:10155 Change-Id: Ieb658ab5582bff276f76babdaf7ddb8f72bd4790 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2072739Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#66478}
-
- 26 Feb, 2020 1 commit
-
-
Emanuel Ziegler authored
Added a type field to elements to distinguish anyref, funcref and nullref elements and do a proper type checking at compile time as the spec requires. R=ahaas@chromium.org Change-Id: I31be7aa1170439859ca7ec5e20aabb2720c290b3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2069330 Commit-Queue: Emanuel Ziegler <ecmziegler@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#66448}
-
- 17 Feb, 2020 1 commit
-
-
Emanuel Ziegler authored
Implement the latest spec changes: - Allow declarative segments to behave like passive & dropped segments. - Enforce that only declared functions may be returned or used in globals as funcref. - Ensure that table fill does not modify any entries if OOB. Spec tests for select and br_table are still failing due to proposal issue Bug: v8:10156 R=ahaas@chromium.org Change-Id: I5b95be36a67bc7482a84b848908cc4cbdf94af03 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2027458Reviewed-by: Andreas Haas <ahaas@chromium.org> Commit-Queue: Emanuel Ziegler <ecmziegler@chromium.org> Cr-Commit-Position: refs/heads/master@{#66297}
-
- 23 Jan, 2020 1 commit
-
-
Ben Smith authored
The following instructions are affected: memory.init, data.drop, table.init, table.drop. A segment index should be decoded as an unsigned number, but these instructions were decoding as signed. This works properly up to 63, but fails at 64 (which is decoded as -64 = 4294967232). Bug: v8:10151 Change-Id: I742b74cf0bcadf2ff2f606beb65b7bae3e816530 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2015960Reviewed-by: Andreas Haas <ahaas@chromium.org> Commit-Queue: Ben Smith <binji@chromium.org> Cr-Commit-Position: refs/heads/master@{#65957}
-
- 15 Jan, 2020 1 commit
-
-
Emanuel Ziegler authored
Add decoding of ref.null as a valid argument for references in TurboFan, LiftOff and the interpreter. R=ahaas@chromium.org R=jkummerow@chromium.org Bug: chromium:10063 Change-Id: I1e2d9c76f616dacb3aa06f8b535543bdcdcf0783 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1991485 Commit-Queue: Emanuel Ziegler <ecmziegler@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#65788}
-
- 06 Dec, 2019 1 commit
-
-
Deepti Gandluri authored
Change-Id: I607e9565e29b2159c1783cd58fb5a2e19c02b221 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1955524 Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#65365}
-
- 28 Nov, 2019 1 commit
-
-
Clemens Backes authored
Fix a TODO from Ben to change the macro argument order to match the actual order in wasm code. After this fix, we can remove the individual {WASM_CALL_INDIRECT[0-5]} macros and implement them via a common variadic macro. Also, rename {WASM_CALL_INDIRECT_TABLE0} to {WASM_CALL_INDIRECT_TABLE}. The name was confusing, because this macro explictly allows to set a table index different from 0. Thus, just drop the "0" in the name. The individual test changes were done via a vim macro, to avoid manual errors. R=mstarzinger@chromium.org Bug: v8:10021 Change-Id: I9f0f31511c5c6e20a0b07524bf75fe9cf1598eba Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1940265Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#65242}
-
- 26 Nov, 2019 1 commit
-
-
Clemens Backes authored
Make WasmFeatures a proper class which uses an EnumSet under the hood. This way, it inherits all behaviour of EnumSet like comparison, merge, etc. Accesses change from being simple field access into the struct to actually bit tests in the EnumSet. R=mstarzinger@chromium.org Bug: v8:10019 Change-Id: I768f92b90ac0294156f4482defba5ce00bc70165 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1934334 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#65184}
-