1. 29 Mar, 2017 1 commit
  2. 27 Mar, 2017 1 commit
  3. 24 Mar, 2017 2 commits
  4. 22 Mar, 2017 1 commit
    • kozyatinskiy's avatar
      [debugger] tuned StepNext and StepOut at return position · e27d18c9
      kozyatinskiy authored
      Proposed behaviour:
      - StepNext at return position go into next function call (no changes with current behavior, but implemented in v8::Debug instead of hack on inspector side);
      - StepOut at return position go into next non-current function call.
      
      We need this to have better stepping in cases with native functions, blackboxed functions and/or different embedder calls (e.g. event listeners).
      
      New behavior could be illustrated with two examples (for more see stepping-with-natives-and-frameworks test):
      - let's assume that we've blackboxed callAll function, this function just takes its arguments and call one after another:
      var foo = () => 1;
      callAll(foo, foo, () => 2);
      If we break inside of first call of function foo. Then on..
      ..StepNext - we're able to reach second call of function foo,
      ..StepOut - we're able to reach () => 2 call.
      
      - let's consider case with native function:
      [1,2,3].map(x => x * 2)
      If we break inside of first callback call, then with StepNext we can iterate through all calls of callback, with StepOut we go to next statement after .map call.
      
      Implementation details:
      - when we request break we schedule step-in function call for any step action at return position and for step-in at any position,
      - when we request StepOut at return position - we mark current function as needed-to-be-ignored inside of PrepareStepIn(function) call,
      - when we request StepOut at not return position - we set break at return position and ask debugger to just repeat last step action on next stepping-related break.
      
      Design doc: https://docs.google.com/document/d/1ihXHOIhP_q-fJCA0e2EiXz_Zr3B08KMjaPifcaqZ60Q/edit
      
      BUG=v8:6118,chromium:583193
      R=dgozman@chromium.org,yangguo@chromium.org
      
      Review-Url: https://codereview.chromium.org/2758483002
      Cr-Commit-Position: refs/heads/master@{#44028}
      e27d18c9
  5. 18 Mar, 2017 1 commit
  6. 17 Mar, 2017 1 commit
    • littledan's avatar
      [intl] Fix debug-evaluate-no-side-effect-builtins test · 3fa26338
      littledan authored
      String case conversion is known to debug-evaluate to not have a side
      effect in noi18n mode, but debug-evaluate thinks it has a side effect
      in i18n mode. Update the tests accordingly.
      
      Verified locally that the test passes in i18n and noi18n mode (not sure
      whether the noi18n trybot executes this test).
      
      CQ_INCLUDE_TRYBOTS=master.tryserver.v8:v8_linux_noi18n_rel_ng
      
      Review-Url: https://codereview.chromium.org/2750403004
      Cr-Commit-Position: refs/heads/master@{#43882}
      3fa26338
  7. 16 Mar, 2017 1 commit
  8. 13 Mar, 2017 1 commit
  9. 10 Mar, 2017 1 commit
  10. 07 Mar, 2017 1 commit
  11. 28 Feb, 2017 2 commits
  12. 22 Feb, 2017 2 commits
  13. 10 Feb, 2017 2 commits
  14. 09 Feb, 2017 4 commits
  15. 04 Feb, 2017 1 commit
  16. 02 Feb, 2017 4 commits
  17. 27 Jan, 2017 1 commit
    • yangguo's avatar
      [liveedit] reimplement frame restarting. · 3f47c63d
      yangguo authored
      Previously, when restarting a frame, we would rewrite all frames
      between the debugger activation and the frame to restart to squash
      them, and replace the return address with that of a builtin to
      leave that rewritten frame, and restart the function by calling it.
      
      We now simply remember the frame to drop to, and upon returning
      from the debugger, we check whether to drop the frame, load the
      new FP, and restart the function.
      
      R=jgruber@chromium.org, mstarzinger@chromium.org
      BUG=v8:5587
      
      Review-Url: https://codereview.chromium.org/2636913002
      Cr-Commit-Position: refs/heads/master@{#42725}
      3f47c63d
  18. 26 Jan, 2017 3 commits
  19. 25 Jan, 2017 2 commits
  20. 19 Jan, 2017 1 commit
  21. 17 Jan, 2017 2 commits
  22. 16 Jan, 2017 1 commit
  23. 15 Jan, 2017 1 commit
  24. 13 Jan, 2017 2 commits
  25. 12 Jan, 2017 1 commit