1. 27 Jul, 2020 1 commit
  2. 17 Mar, 2020 1 commit
  3. 04 Jul, 2019 1 commit
    • Simon Zünd's avatar
      [stack-trace] Separate stack-trace symbolization and serialization · db24e200
      Simon Zünd authored
      This CL moves the code responsible for serializing a stack trace frame into
      a string, out of messages.cc and into stack-frame-info.cc. Instead of
      symbolizing the stack trace frame while serializing, the code is changed to
      work on top of StackTraceFrame and StackFrameInfo objects.
      
      The result is that the serialization code no longer cares when a stack trace
      frame is symbolized. Symbolization could happen eagerly during capturing, or
      lazily the first time any of StackFrameInfo fields are accessed.
      
      Drive-by: Existing users of StackFrameBase::ToString are adapted to the
      new SerializeStackTraceFrame API. This includes Isolate::PrintCurrentStackTrace,
      which is changed to re-use the existing capturing and serializing mechanism.
      
      Bug: v8:8742
      Change-Id: Ic7fd80668c9d993e99d586ef7fe022850104c34f
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1631414
      Commit-Queue: Simon Zünd <szuend@chromium.org>
      Reviewed-by: 's avatarUlan Degenbaev <ulan@chromium.org>
      Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#62522}
      db24e200
  4. 09 Aug, 2018 1 commit
    • Alexey Kozyatinskiy's avatar
      [inspector] added V8InspectorClient::resourceNameToUrl · dbfcc487
      Alexey Kozyatinskiy authored
      Some clients (see Node.js) use platform path as ScriptOrigin.
      Reporting platform path in protocol makes using protocol much harder.
      This CL introduced V8InspectorClient::resourceNameToUrl method that
      is called for any reported using protocol url.
      V8Inspector uses url internally as well so protocol client may generate
      pattern for blackboxing with file urls only and does not need to build
      complicated regexp that covers files urls and platform paths on
      different platforms.
      
      R=lushnikov@chromium.org
      TBR=yangguo@chromium.org
      
      Bug: none
      Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel
      Change-Id: Iff302e7441df922fa5d689fe510f5a9bfd470b9b
      Reviewed-on: https://chromium-review.googlesource.com/1164624
      Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
      Reviewed-by: 's avatarAlexei Filippov <alph@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#55029}
      dbfcc487