- 29 May, 2017 27 commits
-
-
Michael Starzinger authored
This widens the range of value output counts to 32 bit on the {Operator} class. Note that the limit imposed by the parser is 65535 parameters for each function, but the {Start} node has additional value outputs. R=jarin@chromium.org TEST=mjsunit/regress/regress-crbug-724153 BUG=chromium:724153 Change-Id: I21b5d947cc2305b255ddbbff6ec1dfa5c02784c7 Reviewed-on: https://chromium-review.googlesource.com/517489Reviewed-by:Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#45573}
-
Toon Verwaest authored
Bug: Change-Id: Ie754efaec80eb175ac18c328c750524009ca8e60 Reviewed-on: https://chromium-review.googlesource.com/517104Reviewed-by:
Igor Sheludko <ishell@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#45572}
-
ulan authored
BUG= Review-Url: https://codereview.chromium.org/2906313002 Cr-Commit-Position: refs/heads/master@{#45571}
-
ulan authored
BUG=chromium:694255 Review-Url: https://codereview.chromium.org/2910933002 Cr-Commit-Position: refs/heads/master@{#45570}
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/53a7b31..ff6a082 Rolling v8/buildtools: https://chromium.googlesource.com/chromium/buildtools/+log/98f00fa..1045741 Rolling v8/third_party/catapult: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+log/51b3178..ea7d9cf Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/05f3060..34e6d43 Rolling v8/tools/swarming_client: https://chromium.googlesource.com/external/swarming.client/+log/a941a08..5c4eed8 TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org Change-Id: Ic7e269d5c8e3051caf61c117465bfcdd96cb5266 Reviewed-on: https://chromium-review.googlesource.com/517644Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#45569}
-
Michael Starzinger authored
This removes special support in the compilation pipeline to keep alive unoptimized code for inlined functions (i.e. preventing the code flusher from clearing it). Now that the code flusher is gone, this is obsolete. R=jarin@chromium.org Change-Id: I00361d12f2d17556056d06c10ad19f09a4772cd8 Reviewed-on: https://chromium-review.googlesource.com/517948Reviewed-by:
-
Peter Marshall authored
Bug: chromium:725865 Change-Id: I94006d45aefb969fb0cf98ec475c30c14b3837fa Reviewed-on: https://chromium-review.googlesource.com/517488Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#45567}
-
Marja Hölttä authored
For non-simple param lists, the parser first declares a TEMPORARY for each param, and then the named variables as locals. The TEMPORARY variables determine the parameter count. This CL makes the PreParser produce the same parameter count as the Parser. BUG=v8:5516 Change-Id: I8a794d6a8342145ab7934d922e2d69450d67b199 Reviewed-on: https://chromium-review.googlesource.com/517944 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#45566}
-
Marja Hölttä authored
BUG=v8:5402 Change-Id: If5f763e6a11d446e36719277a18b00a0cd8df8fa Reviewed-on: https://chromium-review.googlesource.com/517162 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#45565}
-
Michael Achenbach authored
Manually rolls: https://chromium.googlesource.com/chromium/src/build/+log/5488ca8df..53a7b319 Fixes gyp build after: https: //codereview.chromium.org/2900193003 Change-Id: I0249aa7d1c40bcb1533c56577bfbda4aedd8cbf9 Reviewed-on: https://chromium-review.googlesource.com/518144Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#45564}
-
Camillo Bruni authored
Bug: v8:6211 Change-Id: If6d2ef7889ae6a0c3aa430d3f69c53f19cc1f1c6 Reviewed-on: https://chromium-review.googlesource.com/509571Reviewed-by:
Marja Hölttä <marja@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#45563}
-
Jochen Eisinger authored
R=machenbach@chromium.org Change-Id: I48b6bda0bfb3c8aef117616015ee4225d4bdecfc Reviewed-on: https://chromium-review.googlesource.com/517486 Commit-Queue: Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#45562}
-
Jochen Eisinger authored
Eventually I want to delete that macro, so just inline it at the places where we'll need to keep it. BUG=v8:5830 R=marja@chromium.org Change-Id: I904a1dd3555c23c69e457e078faaaa86a9514932 Reviewed-on: https://chromium-review.googlesource.com/518043Reviewed-by:
-
Jochen Eisinger authored
Replace the macro with more generic macros expanding to the same code. BUG=v8:5830 R=marja@chromium.org Change-Id: Ibf31fa4d89960a025af859198e190910c5608a20 Reviewed-on: https://chromium-review.googlesource.com/518006 Commit-Queue: Jochen Eisinger <jochen@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
For lazy compilation, we encode information about table exports in the deoptimization data. This information is rebuilt on each instantiation, so we need to reset it when reusing code objects from another instance. R=ahaas@chromium.org BUG=chromium:727219 Change-Id: I90557ef06e692d0a8323223cac26679efcfa408b Reviewed-on: https://chromium-review.googlesource.com/517945Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#45559}
-
Clemens Hammacher authored
It happens frequently that unrelated compiler errors lead to the instantiation of {read_leb_tail} with an invalid {byte_index}, which again triggers compiler errors. This change fixes this, such that illegal instantiation just triggers a static_assert and nothing more. This helps to spot the actual error. Drive-by: Mark {Min} and {Max} constexpr, such that they can produce constexpr results. Note that the result will only be constexpr if both arguments are constexpr. R=ahaas@chromium.org Change-Id: I35d6865a7f569d72ace0debb045ac615cfd87d92 Reviewed-on: https://chromium-review.googlesource.com/518005Reviewed-by: -
Jochen Eisinger authored
All APIs that can throw exceptions should return Maybe<> values BUG=none R=neis@chromium.org,gsathya@chromium.org Change-Id: I6a6e5888cd71257bb02bdcfcc587c909d0c1d8f4 Reviewed-on: https://chromium-review.googlesource.com/517785 Commit-Queue: Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#45557}
-
Clemens Hammacher authored
WasmGraphBuilder::GrowMemory does not access the module or the instance any more. This was initially needed to reference the context as a HeapConstant in the code. This CL just removes the DCHECKs, which failed with the --wasm-lazy-compilation flag. R=ahaas@chromium.org BUG=chromium:726665 Change-Id: Ieac53fe376256c47e8ef2fafca818a99ff063683 Reviewed-on: https://chromium-review.googlesource.com/516706Reviewed-by:
-
Clemens Hammacher authored
Parallel compilation should only be chosen if there are background threads available. Otherwise, the overhead of orchestrating (non-)parallel work can be omitted by just compiling synchronously. R=ahaas@chromium.org Change-Id: I333fb87e07fdb3260ab4c9c2c1885a1df4c5e4ef Reviewed-on: https://chromium-review.googlesource.com/513062Reviewed-by:
-
Jochen Eisinger authored
Also move the soon-to-be-deprecated version to deprecated BUG=none R=ulan@chromium.org Change-Id: I2252404f63e25ac35c7798daf66b36144bef6a7e Reviewed-on: https://chromium-review.googlesource.com/518162Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#45554}
-
ulan authored
BUG= Review-Url: https://codereview.chromium.org/2900603004 Cr-Commit-Position: refs/heads/master@{#45553}
-
Michael Achenbach authored
Tests should instead be skipped or fixed. Existing timeout expectations are either optimistically deleted or replaced by the SLOW keyword. Change-Id: Ic43f52bf18d0702674c95f9263a109041a1c9cd8 Reviewed-on: https://chromium-review.googlesource.com/518122Reviewed-by:
-
Sathya Gunasekaran authored
Implements the Allocate, Add, and HasKey operations. Also, adds GC support for this new instance type. Bug: v8:6443 Change-Id: I1cc7ba2faead2a11f7b0381a57858629e123aee6 Reviewed-on: https://chromium-review.googlesource.com/500447 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
Hannes Payer <hpayer@chromium.org> Reviewed-by:
-
Igor Sheludko authored
Bug: chromium:724820 Change-Id: If4d05326ad00d0d3efe8f58b361595f2655d90d2 Reviewed-on: https://chromium-review.googlesource.com/518142Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#45550}
-
Peter Marshall authored
Bug: v8:6391 Change-Id: If63078c756d9cfb00e515fae005755c4ed8b12f7 Reviewed-on: https://chromium-review.googlesource.com/512803Reviewed-by:
-
Ilija.Pavlovic authored
The test OneByteArrayJoin failed on MIPS64 in debug mode after https://chromium-review.googlesource.com/c/489946/ with error messages "allocation failure GC in old space requested" and "Fatal javascript OOM in CALL_AND_RETRY_LAST". Successful test execution is possible on two ways: with flag --max_old_space_size=7 or with modification in the test (constraints.set_max_old_space_size(7)). TEST=cctest/test-strings/OneByteArrayJoin BUG= Review-Url: https://codereview.chromium.org/2907803002 Cr-Commit-Position: refs/heads/master@{#45548}
-
Michael Achenbach authored
This reverts commit 7a9cc704. Reason for revert: Changes layout tests: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/15882 This is about: inspector/sources/debugger/source-frame-inline-breakpoint-decorations.html Original change's description: > [inspector] moved var initialization break location before init expression > > This CL improves break locations for expressions like 'var a = <expr>'. Without CL we use <expr> position as break location for initialization statement, with this CL we use position of first character after '=' as position. > Benefits (see test for details): > - only one break in expressions which includes mix of property lookup and calls, e.g. var p = Promise.resolve().then(x => x * 2), > - removed redundant break location for expressions like: let { x, y } = { x: 1, y: 2}. > > Bug: v8:5909 > Change-Id: I039d911903a2826c9859710a63ab0462c992e11b > Reviewed-on: https://chromium-review.googlesource.com/513926 > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Reviewed-by: Marja Hölttä <marja@chromium.org> > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#45530} TBR=dgozman@chromium.org,marja@chromium.org,kozyatinskiy@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:5909 Change-Id: Ibf84401e8050d3c84db219d983de2c6bba0f697f Reviewed-on: https://chromium-review.googlesource.com/518102Reviewed-by:
-
- 27 May, 2017 2 commits
-
-
jan.krems authored
This allows embedders to delay initialization of the module system until after the isolate was created. BUG=v8:6428 R=gsathya@chromium.org Review-Url: https://codereview.chromium.org/2897103002 Cr-Commit-Position: refs/heads/master@{#45546}
-
hans authored
The memcpy and memmove externals can end up at the same address; see bug for details. BUG=chromium:726896 Review-Url: https://codereview.chromium.org/2906193002 Cr-Commit-Position: refs/heads/master@{#45545}
-
- 26 May, 2017 10 commits
-
-
Igor Sheludko authored
... to make AsyncFunction subclassing work. Bug: chromium:725537 Change-Id: I7edf4891e14e01567046e7536b3aa93877111448 Reviewed-on: https://chromium-review.googlesource.com/517087 Commit-Queue: Adam Klein <adamk@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#45544}
-
Igor Sheludko authored
... which caused assertion failures in --enable-slow-asserts mode. The surrounding code treated the constructor value properly so regression test is not necessary. Bug: chromium:726622 Change-Id: Icd43d9117a1125bec8feca8eca5708993de2c3ef Reviewed-on: https://chromium-review.googlesource.com/516626Reviewed-by:
-
Ross McIlroy authored
BUG=v8:6243 Change-Id: Ia6dfa407591d1b06d5b014627bb44413540aecb3 Reviewed-on: https://chromium-review.googlesource.com/516984Reviewed-by:
Mythri Alle <mythria@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#45542}
-
Toon Verwaest authored
Bug: Change-Id: I56f41392a2c3bbd203553e3fb386f8b7234d5e75 Reviewed-on: https://chromium-review.googlesource.com/516624Reviewed-by:
-
georgia.kouveli authored
Which I introduced in: c15b3ffc [arm] Share constant pool entries in snapshot. BUG=chromium:725714 Review-Url: https://codereview.chromium.org/2905643002 Cr-Commit-Position: refs/heads/master@{#45540}
-
Toon Verwaest authored
All other properties in the boilerplate are data fields, so we can avoid additional checks. Bug: Change-Id: Ie494329332b0ba646515850b6d267fb05735f0ea Reviewed-on: https://chromium-review.googlesource.com/517044Reviewed-by:
-
Clemens Hammacher authored
This removes a lot of special handling for the predictable platform. Instead of executing spawned foreground and background tasks immediately (i.e. inside the scope that spawns the tasks), just add both to the foreground task queue. This avoids existing special handling for predictable mode in wasm async compilation, and should fix current failures on the predictable bot. BUG=v8:6427 Change-Id: Idbaa764a3dc8c230c29f3937d885e12174691ac4 Reviewed-on: https://chromium-review.googlesource.com/509694Reviewed-by:
-
Sathya Gunasekaran authored
Bug: chromium:726636 Change-Id: Ied6af8c969ed05b7a334238b30930658af060e7d Reviewed-on: https://chromium-review.googlesource.com/516734Reviewed-by:
-
Toon Verwaest authored
This speeds up fast-mode object copying by ~2x and __proto__:null cases by ~20x. Bug: Change-Id: Ic3893ae4c87063f0c8c524ef55c0e786b7a87192 Reviewed-on: https://chromium-review.googlesource.com/516983 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Andreas Haas authored
This CL removes the isolate_ property from the Cancelable class. The isolate is actually not used in the class itself, only in sub-classes which can store the isolate themselves. R=jochen@chromium.org, mlippautz@chromium.org Change-Id: If102fdea41b81fb3cb25782728f7fcbce9642815 Reviewed-on: https://chromium-review.googlesource.com/516704Reviewed-by:
-
- 25 May, 2017 1 commit
-
-
bbudge authored
- This won't save a bit, since the enum is not a flags enum and there is still room for another value. - While it may be possible to eliminate this value, the code to init and check for invalid becomes much more complex. Unallocated operands are currently created with invalid vreg code, so we also have to check the policy. BUG=v8:6325 Review-Url: https://codereview.chromium.org/2904603004 Cr-Commit-Position: refs/heads/master@{#45534}
-
