1. 25 Aug, 2022 1 commit
  2. 24 Aug, 2022 1 commit
    • Leszek Swirski's avatar
      Revert "Reland "[ptr-compr][x64][compiler] Support load map in compressed" · cec5b750
      Leszek Swirski authored
      This reverts commit 63b37c0e.
      
      Reason for revert: Seems to regress performance
      
      Original change's description:
      > Reland "[ptr-compr][x64][compiler] Support load map in compressed
      > form"
      >
      > This is a reland of commit 6ca3adb9
      >
      > Fix build failed with V8_MAP_PACKING.
      >
      > Original change's description:
      > > [ptr-compr][x64][compiler] Support load map in compressed form
      > >
      > > ...to allow pointer decompression at use-site.
      > >
      > > Bug: v8:13056, v8:7703
      > > Change-Id: If369286814c76340a945cc2a9fd863888a813080
      > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3811737
      > > Reviewed-by: Leszek Swirski <leszeks@chromium.org>
      > > Commit-Queue: Hao A Xu <hao.a.xu@intel.com>
      > > Cr-Commit-Position: refs/heads/main@{#82242}
      >
      > Bug: v8:13056, v8:7703
      > Change-Id: Ic753558058f70f6ee7850019aac9235b87d0e56a
      > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3815779
      > Commit-Queue: Hao A Xu <hao.a.xu@intel.com>
      > Reviewed-by: Leszek Swirski <leszeks@chromium.org>
      > Cr-Commit-Position: refs/heads/main@{#82322}
      
      Bug: v8:13056, v8:7703
      Change-Id: I8693af9189e214ec54a56149e0b29038e85838c2
      Fixed: chromium:1352384
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3842931
      Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
      Commit-Queue: Leszek Swirski <leszeks@chromium.org>
      Auto-Submit: Leszek Swirski <leszeks@chromium.org>
      Cr-Commit-Position: refs/heads/main@{#82689}
      cec5b750
  3. 23 Aug, 2022 1 commit
    • Jakob Linke's avatar
      Revert "Fix CSA_CHECK failure on BE" · 85f32019
      Jakob Linke authored
      This reverts commit c060af4d.
      
      Reason for revert: Fails with `v8_enable_verify_csa = true`:
      
      ```
      # Fatal error in ../../src/compiler/machine-graph-verifier.cc, line 821
      # TypeError: node #1503:Word32Equal uses node #1501:Load[kRepWord64] which doesn't have a compressed, tagged, or int32 representation.
      #     Current block: id:187 <= id:154 <= id:183 <= id:93 <= id:144
      #
      #     Specify option --csa-trap-on-node=RegExpExecInternal,1503 for debugging.
      ```
      
      Original change's description:
      > Fix CSA_CHECK failure on BE
      >
      > The load for external reference should be a full pointer load
      > instead of tagged size.
      >
      > Change-Id: I3460a26abea5053ba6daa5c6ed908cb93431654a
      > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3842348
      > Reviewed-by: Camillo Bruni <cbruni@chromium.org>
      > Commit-Queue: Junliang Yan <junyan@redhat.com>
      > Cr-Commit-Position: refs/heads/main@{#82625}
      
      Change-Id: Iaf9d0432157cba8c585377d33083a798c62e516c
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3848171
      Auto-Submit: Jakob Linke <jgruber@chromium.org>
      Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
      Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
      Cr-Commit-Position: refs/heads/main@{#82649}
      85f32019
  4. 22 Aug, 2022 4 commits
  5. 19 Aug, 2022 3 commits
  6. 18 Aug, 2022 3 commits
  7. 17 Aug, 2022 2 commits
    • Nico Hartmann's avatar
      Revert "[sandbox] Sandboxify WasmExportedFunctionData::sig" · d8b8024e
      Nico Hartmann authored
      This reverts commit 6ec7be21.
      
      Reason for revert: Speculative revert for https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Win64/47984/overview
      
      Original change's description:
      > [sandbox] Sandboxify WasmExportedFunctionData::sig
      >
      > This CL changes the WasmExportedFunctionData class to store a direct
      > ExternalPointer to the wasm::FunctionSig instead of referencing it
      > through a Foreign. This in turn makes it possible to use a unique
      > pointer tag for that external pointer when the sandbox is enabled.
      >
      > Drive-by: move WasmInternalFunction::call_target external pointer to the
      > end of the object, in line with other external pointer fields.
      >
      > Bug: v8:10391, v8:12949
      > Change-Id: Ic3ff622a075c9eaa2f8d8835803437466290c928
      > Cq-Include-Trybots: luci.v8.try:v8_linux64_heap_sandbox_dbg_ng,v8_linux_arm64_sim_heap_sandbox_dbg_ng
      > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3829086
      > Commit-Queue: Samuel Groß <saelo@chromium.org>
      > Reviewed-by: Igor Sheludko <ishell@chromium.org>
      > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
      > Cr-Commit-Position: refs/heads/main@{#82523}
      
      Bug: v8:10391, v8:12949
      Change-Id: I18a7c9603e30d7cd78fd599e59596015260a5818
      Cq-Include-Trybots: luci.v8.try:v8_linux64_heap_sandbox_dbg_ng,v8_linux_arm64_sim_heap_sandbox_dbg_ng
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3834259
      Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
      Owners-Override: Nico Hartmann <nicohartmann@chromium.org>
      Commit-Queue: Nico Hartmann <nicohartmann@chromium.org>
      Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
      Auto-Submit: Nico Hartmann <nicohartmann@chromium.org>
      Cr-Commit-Position: refs/heads/main@{#82535}
      d8b8024e
    • Samuel Groß's avatar
      [sandbox] Sandboxify WasmExportedFunctionData::sig · 6ec7be21
      Samuel Groß authored
      This CL changes the WasmExportedFunctionData class to store a direct
      ExternalPointer to the wasm::FunctionSig instead of referencing it
      through a Foreign. This in turn makes it possible to use a unique
      pointer tag for that external pointer when the sandbox is enabled.
      
      Drive-by: move WasmInternalFunction::call_target external pointer to the
      end of the object, in line with other external pointer fields.
      
      Bug: v8:10391, v8:12949
      Change-Id: Ic3ff622a075c9eaa2f8d8835803437466290c928
      Cq-Include-Trybots: luci.v8.try:v8_linux64_heap_sandbox_dbg_ng,v8_linux_arm64_sim_heap_sandbox_dbg_ng
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3829086
      Commit-Queue: Samuel Groß <saelo@chromium.org>
      Reviewed-by: 's avatarIgor Sheludko <ishell@chromium.org>
      Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
      Cr-Commit-Position: refs/heads/main@{#82523}
      6ec7be21
  8. 16 Aug, 2022 5 commits
  9. 15 Aug, 2022 2 commits
  10. 13 Aug, 2022 1 commit
  11. 12 Aug, 2022 6 commits
  12. 11 Aug, 2022 4 commits
  13. 10 Aug, 2022 7 commits