- 06 Jun, 2016 1 commit
-
-
cbruni authored
Passing in the isolate and pointer compare the instnance against the corresponding constant is always faster than decoding the instance types. BUG= Review-Url: https://codereview.chromium.org/2028983002 Cr-Commit-Position: refs/heads/master@{#36744}
-
- 13 Apr, 2016 1 commit
-
-
mlippautz authored
- Additionally allow to commit late lists to an already started sweeper BUG=chromium:581412 LOG=N Review URL: https://codereview.chromium.org/1871423002 Cr-Commit-Position: refs/heads/master@{#35432}
-
- 23 Mar, 2016 1 commit
-
-
hpayer authored
RecordWrites is not performing black to grey transitions anymore. In a follow up CL I will clean-up the remaining sites where we do black to grey, e.g. when we overflow marking deque. BUG= Review URL: https://codereview.chromium.org/1823783003 Cr-Commit-Position: refs/heads/master@{#35031}
-
- 14 Mar, 2016 2 commits
-
-
hpayer authored
BUG=chromium:561449 LOG=n Review URL: https://codereview.chromium.org/1794383004 Cr-Commit-Position: refs/heads/master@{#34760}
-
hpayer authored
When black allocation is active, all objects allocated in old space are allocated black. Important: With that change, you cannot assume anymore that new objects are white right after their allocation. Currently, black allocation is enabled when incremental marking is started. This feature can be turned off via flag: --noblack-allocation BUG=chromium:561449 LOG=n Review URL: https://codereview.chromium.org/1420423009 Cr-Commit-Position: refs/heads/master@{#34743}
-
- 25 Feb, 2016 1 commit
-
-
ulan authored
Reland "Replace slots buffer with remembered set. (patchset #14 id:250001 of https://codereview.chromium.org/1703823002/ )" This reverts commit 9146bc5e. This contains a fix for the following crash: 1. We record slots for a fixed array. 2. We trim the fixed array, so that some recorded slots are now in free space. 3. During mark-compact we sweep the page with the fixed array. Now free list items contain memory with recorded slots. 4. We evacuate a byte array using the new free list items. 5. We iterate slots that are now inside the byte array and crash. BUG=chromium:589413,chromium:578883 LOG=NO Review URL: https://codereview.chromium.org/1735523002 Cr-Commit-Position: refs/heads/master@{#34302}
-
- 24 Feb, 2016 1 commit
-
-
ulan authored
Revert of Replace slots buffer with remembered set. (patchset #14 id:250001 of https://codereview.chromium.org/1703823002/ ) Reason for revert: Revert because of canary crashes: crbug.com/589413 Original issue's description: > Replace slots buffer with remembered set. > > Slots pointing to evacuation candidates are now recorded in the new RememberedSet<OLD_TO_OLD>. > > The remembered set is extended to support typed slots. > > During parallel evacuation all migration slots are recorded in local slots buffers. > After evacuation all local slots are added to the remembered set. > > BUG=chromium:578883 > LOG=NO > > Committed: https://crrev.com/2285a99ef6f7d52f4f0c4d88a7db4224443ee152 > Cr-Commit-Position: refs/heads/master@{#34212} TBR=jochen@chromium.org,hpayer@chromium.org,mlippautz@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:578883 Review URL: https://codereview.chromium.org/1725073003 Cr-Commit-Position: refs/heads/master@{#34238}
-
- 23 Feb, 2016 1 commit
-
-
ulan authored
Slots pointing to evacuation candidates are now recorded in the new RememberedSet<OLD_TO_OLD>. The remembered set is extended to support typed slots. During parallel evacuation all migration slots are recorded in local slots buffers. After evacuation all local slots are added to the remembered set. BUG=chromium:578883 LOG=NO Review URL: https://codereview.chromium.org/1703823002 Cr-Commit-Position: refs/heads/master@{#34212}
-
- 16 Feb, 2016 1 commit
-
-
verwaest authored
BUG= Review URL: https://codereview.chromium.org/1694403002 Cr-Commit-Position: refs/heads/master@{#34034}
-
- 21 Jan, 2016 1 commit
-
-
mlippautz authored
Also restrict how many pages are swept during slow path allocation. BUG=chromium:524425 LOG=N Review URL: https://codereview.chromium.org/1596343004 Cr-Commit-Position: refs/heads/master@{#33435}
-
- 11 Jan, 2016 1 commit
-
-
hpayer authored
This CL changes the color for encoding black and grey. Moreover, it introduces a higher level live object iterator. BUG=chromium:561449 LOG=n Review URL: https://codereview.chromium.org/1517993003 Cr-Commit-Position: refs/heads/master@{#33208}
-
- 09 Nov, 2015 1 commit
-
-
mstarzinger authored
This separates the post-processing step for optimized code maps out of the CodeFlusher. It uses the complete SharedFunctionInfo::Iterator to visit all candidates instead of gathering candidates during marking. Gathering candidates during marking no longer makes sense, now that the majority of SharedFunctionInfo objects will hold such an optimized code map. Also it reduces complexity of the implementation. Also conflating this mechanism with "code flushing" was confusing. This reverts commit 7f1fb29f. R=ulan@chromium.org Review URL: https://codereview.chromium.org/1418453008 Cr-Commit-Position: refs/heads/master@{#31876}
-
- 05 Nov, 2015 4 commits
-
-
mstarzinger authored
Revert of [heap] Separate out optimized code map processing. (patchset #2 id:20001 of https://codereview.chromium.org/1421903012/ ) Reason for revert: Causes GC-Stress failures. Original issue's description: > [heap] Separate out optimized code map processing. > > This separates the post-processing step for optimized code maps out of > the CodeFlusher. It uses the complete SharedFunctionInfo::Iterator to > visit all candidates instead of gathering candidates during marking. > > Gathering candidates during marking no longer makes sense, now that the > majority of SharedFunctionInfo objects will hold such an optimized code > map. Also it reduces complexity of the implementation. Also conflating > this mechanism with "code flushing" was confusing. > > This reverts commit b6644e84. > > R=ulan@chromium.org > > Committed: https://crrev.com/bb7a5eb2d89bae25f2b5ecb9515669f0ac73c111 > Cr-Commit-Position: refs/heads/master@{#31836} TBR=ulan@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1412063012 Cr-Commit-Position: refs/heads/master@{#31837}
-
mstarzinger authored
This separates the post-processing step for optimized code maps out of the CodeFlusher. It uses the complete SharedFunctionInfo::Iterator to visit all candidates instead of gathering candidates during marking. Gathering candidates during marking no longer makes sense, now that the majority of SharedFunctionInfo objects will hold such an optimized code map. Also it reduces complexity of the implementation. Also conflating this mechanism with "code flushing" was confusing. This reverts commit b6644e84. R=ulan@chromium.org Review URL: https://codereview.chromium.org/1421903012 Cr-Commit-Position: refs/heads/master@{#31836}
-
hablich authored
Revert of [heap] Separate out optimized code map processing. (patchset #3 id:40001 of https://codereview.chromium.org/1426953006/ ) Reason for revert: Breaks build: https://uberchromegw.corp.google.com/i/client.v8/builders/V8%20Linux%20-%20nosnap%20-%20debug/builds/3565 Original issue's description: > [heap] Separate out optimized code map processing. > > This separates the post-processing step for optimized code maps out of > the CodeFlusher. It uses the complete SharedFunctionInfo::Iterator to > visit all candidates instead of gathering candidates during marking. > > Gathering candidates during marking no longer makes sense, now that the > majority of SharedFunctionInfo objects will hold such an optimized code > map. Also it reduces complexity of the implementation. Also conflating > this mechanism with "code flushing" was confusing. > > R=ulan@chromium.org > > Committed: https://crrev.com/8ad6168d197dd167235c9d342ec7ce37b0daa88b > Cr-Commit-Position: refs/heads/master@{#31830} TBR=ulan@chromium.org,yangguo@chromium.org,mvstanton@chromium.org,mstarzinger@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1434503003 Cr-Commit-Position: refs/heads/master@{#31832}
-
mstarzinger authored
This separates the post-processing step for optimized code maps out of the CodeFlusher. It uses the complete SharedFunctionInfo::Iterator to visit all candidates instead of gathering candidates during marking. Gathering candidates during marking no longer makes sense, now that the majority of SharedFunctionInfo objects will hold such an optimized code map. Also it reduces complexity of the implementation. Also conflating this mechanism with "code flushing" was confusing. R=ulan@chromium.org Review URL: https://codereview.chromium.org/1426953006 Cr-Commit-Position: refs/heads/master@{#31830}
-
- 17 Sep, 2015 1 commit
-
-
hpayer authored
BUG=chromium:532784 LOG=n Review URL: https://codereview.chromium.org/1347363002 Cr-Commit-Position: refs/heads/master@{#30789}
-
- 15 Sep, 2015 1 commit
-
-
hpayer authored
BUG= Review URL: https://codereview.chromium.org/1343043002 Cr-Commit-Position: refs/heads/master@{#30746}
-
- 21 Aug, 2015 1 commit
-
-
mlippautz authored
GC flags are now part of the {Heap} and should be respected by all sub-components. Also add a infrastructure to write tests accessing private methods. Review URL: https://codereview.chromium.org/1301183002 Cr-Commit-Position: refs/heads/master@{#30281}
-
- 17 Aug, 2015 3 commits
-
-
mstarzinger authored
R=hpayer@chromium.org Review URL: https://codereview.chromium.org/1294093003 Cr-Commit-Position: refs/heads/master@{#30202}
-
mstarzinger authored
R=mlippautz@chromium.org Review URL: https://codereview.chromium.org/1291833003 Cr-Commit-Position: refs/heads/master@{#30195}
-
mstarzinger authored
This removes the dependency of the MarkingDeque on the underlying collector by moving out the live bytes accounting and object color mutations into a wrapper. The MarkingDeque can now be split into a separate file. R=hpayer@chromium.org Review URL: https://codereview.chromium.org/1293773002 Cr-Commit-Position: refs/heads/master@{#30194}
-
- 14 Aug, 2015 1 commit
-
-
mstarzinger authored
This CL is a pure refactoring that makes an empty compilation unit including just "foo.h" but not "foo-inl.h" compile without warnings or errors. This is needed to further reduce the header dependency tangle. This realizes above state for "spaces.h" and "mark-compact.h". R=hpayer@chromium.org Review URL: https://codereview.chromium.org/1288413002 Cr-Commit-Position: refs/heads/master@{#30171}
-
- 10 Aug, 2015 1 commit
-
-
mstarzinger authored
This is a first step towards constraining down the heap interface to just the heap.h file. Note that many includes still leak through that file to the global "src" directory, but there now is a single place controlling which declarations leak that way. Especially inclusion of inline header files within "heap" has been limited drastically. R=hpayer@chromium.org,mlippautz@chromium.org Review URL: https://codereview.chromium.org/1281233003 Cr-Commit-Position: refs/heads/master@{#30092}
-
- 04 Aug, 2015 2 commits
-
-
hpayer authored
BUG= Review URL: https://codereview.chromium.org/1259613006 Cr-Commit-Position: refs/heads/master@{#30007}
-
hpayer authored
That makes going to the page safe. Addresses can be in arbitrary locations of an object, e.g. in a large object but not on the first 1M page. BUG= Review URL: https://codereview.chromium.org/1256203004 Cr-Commit-Position: refs/heads/master@{#29991}
-
- 23 Apr, 2015 1 commit
-
-
hpayer authored
BUG= Review URL: https://codereview.chromium.org/1099783003 Cr-Commit-Position: refs/heads/master@{#28024}
-
- 16 Apr, 2015 1 commit
-
-
ulan authored
This breaks the (evacuation -> slots buffer overflow -> abort -> new GC -> evacuation) cycle for popular pages. BUG= Review URL: https://codereview.chromium.org/1037433002 Cr-Commit-Position: refs/heads/master@{#27868}
-
- 15 Apr, 2015 2 commits
-
-
machenbach authored
Revert of Force full GCwhenever CollectAllGarbage is meant to trigger a full GC. (patchset #4 id:60001 of https://codereview.chromium.org/1082973003/) Reason for revert: [Sheriff] Breaks http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap%20-%20debug/builds/3348 and maybe leads to timeouts/crashes on layout test bots: http://build.chromium.org/p/client.v8/builders/V8-Blink%20Linux%2064/builds/3002 Original issue's description: > Force full GC whenever CollectAllGarbage is meant to trigger a full GC. > > Add a finalize incremental marking mode for CollectAllGarbage to finalize incremental marking when incremental marking is in progress, but we want a full gc at a given CollectAllGarbage call site. > > Default mode for CollectAllGarbage is finalize incremental marking and perform a full GC. > > BUG= > > Committed: https://crrev.com/9c105f0940ba757364ac18fcdf649815ec5ab2d1 > Cr-Commit-Position: refs/heads/master@{#27831} TBR=ulan@chromium.org,hpayer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1088083002 Cr-Commit-Position: refs/heads/master@{#27834}
-
hpayer authored
Add a finalize incremental marking mode for CollectAllGarbage to finalize incremental marking when incremental marking is in progress, but we want a full gc at a given CollectAllGarbage call site. Default mode for CollectAllGarbage is finalize incremental marking and perform a full GC. BUG= Review URL: https://codereview.chromium.org/1082973003 Cr-Commit-Position: refs/heads/master@{#27831}
-
- 09 Apr, 2015 1 commit
-
-
hpayer authored
MarkBit cleanup: They have to be accessed through Marking accessors. Avoid arbitrary abuse of mark bits and make marking explicit. Added DCHECKs to mark bit transitions to check source state. BUG= Review URL: https://codereview.chromium.org/1040443002 Cr-Commit-Position: refs/heads/master@{#27689}
-
- 07 Apr, 2015 1 commit
-
-
hpayer authored
This reverts commit cbfcee55. BUG= Review URL: https://codereview.chromium.org/1051233002 Cr-Commit-Position: refs/heads/master@{#27623}
-
- 19 Mar, 2015 1 commit
-
-
hpayer authored
TBR=verwaest@chromium.org,ulan@chromium.org,ishell@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/1027463002 Cr-Commit-Position: refs/heads/master@{#27323}
-
- 18 Mar, 2015 1 commit
-
-
hpayer authored
BUG= Review URL: https://codereview.chromium.org/1012023002 Cr-Commit-Position: refs/heads/master@{#27259}
-
- 27 Aug, 2014 1 commit
-
-
svenpanne@chromium.org authored
* Removed a few useless and non-standard #includes. * Made OS::GetCurrentProcessId compile without syscall. R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/508933002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23459 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 21 Aug, 2014 1 commit
-
-
hpayer@chromium.org authored
BUG= R=jarin@chromium.org Review URL: https://codereview.chromium.org/479113004 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23283 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 05 Aug, 2014 1 commit
-
-
jochen@chromium.org authored
BUG=none R=hpayer@chromium.org LOG=n Review URL: https://codereview.chromium.org/437993003 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22850 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 04 Aug, 2014 1 commit
-
-
bmeurer@chromium.org authored
This way we don't clash with the ASSERT* macros defined by GoogleTest, and we are one step closer to being able to replace our homegrown base/ with base/ from Chrome. R=jochen@chromium.org, svenpanne@chromium.org Review URL: https://codereview.chromium.org/430503007 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22812 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 03 Jun, 2014 1 commit
-
-
jochen@chromium.org authored
- this avoids using relative include paths which are forbidden by the style guide - makes the code more readable since it's clear which header is meant - allows for starting to use checkdeps BUG=none R=jkummerow@chromium.org, danno@chromium.org LOG=n Review URL: https://codereview.chromium.org/304153016 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21625 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 29 Apr, 2014 1 commit
-
-
bmeurer@chromium.org authored
R=svenpanne@chromium.org Review URL: https://codereview.chromium.org/259183002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@21035 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-