- 12 Dec, 2016 2 commits
-
-
bradnelson authored
Generalize Messages to include an error level. Add a parameter to AddMessageHandler to select which error levels to receive, using a mask (default being just errors, i.e. the current behavior). BUG=v8:4203 R=dgozman@chromium.org,machenbach@chromium.org,danno@chromium.org,bmeurer@chromium.org,jochen@chromium.org Review-Url: https://codereview.chromium.org/2526703002 Cr-Commit-Position: refs/heads/master@{#41648}
-
bradnelson authored
BUG=673240 R=titzer@chromium.org Review-Url: https://codereview.chromium.org/2568773002 Cr-Commit-Position: refs/heads/master@{#41638}
-
- 06 Dec, 2016 1 commit
-
-
bradnelson authored
The asm-wasm-builder started allocating SharedFunctionInfos, this makes it bad we'd passed Script by pointer (due to ignorance). Switching to Handle<Script>. R=clemensh@chromium.org,titzer@chromium.org BUG=v8:5716 Review-Url: https://codereview.chromium.org/2552873003 Cr-Commit-Position: refs/heads/master@{#41529}
-
- 30 Nov, 2016 1 commit
-
-
bradnelson authored
Make the AsmWasmBuilder drive the process of typing and potentially parsing function bodies. This will allow us to keep only a single asm.js function's AST in memory as we convert to WebAssembly. This is needed to keep our memory footprint low. Add some additional output to a few tests that's helpful to see which stage they fail at. BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203 LOG=N R=marja@chromium.org,adamk@chromium.org,aseemgarg@chromium.org,titzer@chromium.org Review-Url: https://codereview.chromium.org/2398023002 Cr-Commit-Position: refs/heads/master@{#41372}
-
- 10 Nov, 2016 1 commit
-
-
ulan authored
BUG=v8:5614 Review-Url: https://codereview.chromium.org/2490973002 Cr-Commit-Position: refs/heads/master@{#40879}
-
- 08 Nov, 2016 1 commit
-
-
bradnelson authored
We recently allowed global constants in asm.js validated code. When used in a return statement, these need to be of an allowed type. BUG=660813 R=jpp@chromium.org,aseemgarg@chromium.org Review-Url: https://codereview.chromium.org/2481103002 Cr-Commit-Position: refs/heads/master@{#40850}
-
- 02 Nov, 2016 1 commit
-
-
verwaest authored
This reduces per-scope overhead from minimally 6 words to 2 words, with one additional pointer per entry, rather than an average of 2 per entry for larger-than-4 element lists. For temp zone parsed functions it additionally makes the declaration-list actually freeable. This introduces ThreadedList to implement the details of dealing with such a list. BUG=v8:5209 Review-Url: https://codereview.chromium.org/2457393003 Cr-Commit-Position: refs/heads/master@{#40703}
-
- 20 Oct, 2016 1 commit
-
-
jpp authored
This CL adds support for: https://discourse.wicg.io/t/allow-const-global-variables/684 It allows global const variables to be used as if they were numeric literals. For example: const f0 = fround(0); ... function foo() { var v = f0; // no type annotation. ... return f0; // no return type annotation. } BUG= https://bugs.chromium.org/p/v8/issues/detail?id=5540 Review-Url: https://chromiumcodereview.appspot.com/2435823002 Cr-Commit-Position: refs/heads/master@{#40477}
-
- 11 Oct, 2016 1 commit
-
-
verwaest authored
BUG=v8:5501 Review-Url: https://codereview.chromium.org/2406803003 Cr-Commit-Position: refs/heads/master@{#40160}
-
- 07 Oct, 2016 1 commit
-
-
mstarzinger authored
R=marja@chromium.org Review-Url: https://codereview.chromium.org/2392303004 Cr-Commit-Position: refs/heads/master@{#40070}
-
- 05 Oct, 2016 1 commit
-
-
bradnelson authored
Allow fround to take values without dots for globals (the spec allows this subtly). Drop over-restrictive assert preventing floating point globals from working. BUG=v8:4203 R=jpp@chromium.org,aseemgarg@chromium.org Review-Url: https://codereview.chromium.org/2397823003 Cr-Commit-Position: refs/heads/master@{#40013}
-
- 20 Sep, 2016 1 commit
-
-
rmcilroy authored
Avoid internalizing on-the-fly now that scope analysis and natives syntax runtime calls no longer require internalized AST values. This should be more efficient by avoiding extra branches on every AST value creation. BUG=v8:5215, chromium:634953 Review-Url: https://codereview.chromium.org/2328593002 Cr-Commit-Position: refs/heads/master@{#39531}
-
- 09 Sep, 2016 1 commit
-
-
marja authored
TBR=bmeurer@chromium.org BUG=v8:5294 Review-Url: https://codereview.chromium.org/2324783002 Cr-Commit-Position: refs/heads/master@{#39304}
-
- 23 Aug, 2016 1 commit
-
-
jpp authored
Adds a check so that module validation fails if there are any assignments to immutable identifiers (e.g., module name, module parameters, stdlib imports.) BUG= https://bugs.chromium.org/p/chromium/issues/detail?id=640194 Review-Url: https://codereview.chromium.org/2268363002 Cr-Commit-Position: refs/heads/master@{#38838}
-
- 22 Aug, 2016 1 commit
-
-
marja authored
This makes us able to get rid of dependencies to parser.h from places which only need the ParseInfo, and also gets rid of the curious Parser <-> Compiler circular dependency. Also IWYUd where necessary. BUG= Review-Url: https://codereview.chromium.org/2268513002 Cr-Commit-Position: refs/heads/master@{#38777}
-
- 12 Aug, 2016 1 commit
-
-
verwaest authored
BUG= Review-Url: https://codereview.chromium.org/2231813003 Cr-Commit-Position: refs/heads/master@{#38599}
-
- 05 Aug, 2016 3 commits
-
-
verwaest authored
This reduces peak zone memory usage by ~10% on codeload and ~5% on mandreel. BUG=v8:5209 Committed: https://crrev.com/2648162dcfff622f8587cea2faa8c3af56456968 Review-Url: https://codereview.chromium.org/2209573002 Cr-Original-Commit-Position: refs/heads/master@{#38367} Cr-Commit-Position: refs/heads/master@{#38390}
-
machenbach authored
Revert of Separate Scope into DeclarationScope and Scope (patchset #13 id:240001 of https://codereview.chromium.org/2209573002/ ) Reason for revert: [Sheriff] Make leak checker unhappy: https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20-%20debug/builds/10959 Original issue's description: > Separate Scope into DeclarationScope and Scope > > This reduces peak zone memory usage by ~10% on codeload and ~5% on mandreel. > > BUG=v8:5209 > > Committed: https://crrev.com/2648162dcfff622f8587cea2faa8c3af56456968 > Cr-Commit-Position: refs/heads/master@{#38367} TBR=marja@chromium.org,mstarzinger@chromium.org,ahaas@chromium.org,adamk@chromium.org,verwaest@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5209 Review-Url: https://codereview.chromium.org/2212383003 Cr-Commit-Position: refs/heads/master@{#38380}
-
verwaest authored
This reduces peak zone memory usage by ~10% on codeload and ~5% on mandreel. BUG=v8:5209 Review-Url: https://codereview.chromium.org/2209573002 Cr-Commit-Position: refs/heads/master@{#38367}
-
- 26 Jul, 2016 1 commit
-
-
jpp authored
The bug was caused when validating expressions X >> 0 for indexing into 8-bit heap views. If X was not an intish, the 'normal' validation path would fail. That, however, left the type of X registered in the AsmTyper::node_types_ member. Later, in the 'lenient' code path for 8-bit views, the entire X >> 0 expression would be validated, which would cause X to be validated again, at which point AsmTyper::SetTypeOf() would DCHECK because the supplied node already had a type associated with it. The fix was to simply FAIL() when X is not an intish. This is safe because if X is not an intish, then Validate(>>, !intish, FixNum) will also fail. BUG= https://bugs.chromium.org/p/chromium/issues/detail?id=628803 BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203 TEST= cctest/asmjs/test-asm-typer.cc LOG= N Review-Url: https://codereview.chromium.org/2181723002 Cr-Commit-Position: refs/heads/master@{#38053}
-
- 21 Jul, 2016 2 commits
-
-
jpp authored
BUG= https://bugs.chromium.org/p/chromium/issues/detail?id=628803 BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203 TEST= cctest/asmjs/test-asm-typer.cc LOG= N Review-Url: https://codereview.chromium.org/2172603002 Cr-Commit-Position: refs/heads/master@{#37954}
-
jpp authored
BUG= https://bugs.chromium.org/p/chromium/issues/detail?id=628450 BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203 TEST= cctest/asmjs/test-asm-typer.cc TEST= mjsunit/wasm/* LOG= N Review-Url: https://codereview.chromium.org/2164273002 Cr-Commit-Position: refs/heads/master@{#37950}
-
- 15 Jul, 2016 1 commit
-
-
jpp authored
The issue was caused by a mishandling of "special" identifiers, i.e., the module's name, and the module's parameter. BUG= https://bugs.chromium.org/p/chromium/issues/detail?id=628446 BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203 TEST= cctest/asmjs/test-asm-typer.cc TEST= cctest/wasm/* LOG=N Review-Url: https://codereview.chromium.org/2147403002 Cr-Commit-Position: refs/heads/master@{#37800}
-
- 14 Jul, 2016 3 commits
-
-
jpp authored
The asm typer would CHECK fail for imports like var bogus = stdlib.<HeapViewType> This CL changes this behavior so the typer reports a validation error instead. BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203 TEST=cctest/asmjs/test-asm-typer.cc LOG=N Review-Url: https://codereview.chromium.org/2152763002 Cr-Commit-Position: refs/heads/master@{#37777}
-
jpp authored
1) Validation fails for literal indexes too large for accessing a given heap type 2) Removes the special handling of FloatishDoubleQ, and FloatQDoubleQ; the inheritance issue that required this special handling was fixed in another CL. 3) Fix a macro name (from asm_* to ASM_*) BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203 TEST=cctest/asmjs/test-asm-typer.cc LOG=N Review-Url: https://codereview.chromium.org/2150583003 Cr-Commit-Position: refs/heads/master@{#37776}
-
bradnelson authored
BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203 TEST= cctest/asmjs/test-asm-typer LOG=N R=jpp@chromium.org Review-Url: https://codereview.chromium.org/2146853004 Cr-Commit-Position: refs/heads/master@{#37734}
-
- 12 Jul, 2016 1 commit
-
-
jpp authored
This is a rewrite of the ASM validator. This one follows the spec instead of using the AST visitors. BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203 TEST=cctest/asmjs/test-asm-typer TEST=cctest/asmjs/test-typing-asm LOG=N Review-Url: https://codereview.chromium.org/2071343003 Cr-Commit-Position: refs/heads/master@{#37694}
-