- 10 Aug, 2016 1 commit
-
-
bmeurer authored
For holey/growing keyed stores, we need to check that there are no setters in the prototype chain and protect against changes to that via code dependencies. R=verwaest@chromium.org BUG=v8:5275,v8:5276 Review-Url: https://codereview.chromium.org/2231683002 Cr-Commit-Position: refs/heads/master@{#38514}
-
- 09 Aug, 2016 2 commits
-
-
mstarzinger authored
R=machenbach@chromium.org Review-Url: https://codereview.chromium.org/2228853002 Cr-Commit-Position: refs/heads/master@{#38494}
-
machenbach authored
NOTRY=true TBR=mstarzinger@chromium.org,bmeurer@chromium.org BUG=v8:5276 Review-Url: https://codereview.chromium.org/2221313002 Cr-Commit-Position: refs/heads/master@{#38470}
-
- 04 Aug, 2016 1 commit
-
-
machenbach authored
This adds the possibility to address test cases in the status file with the variant under which the test is running. This is only allowed in top-level sections. Example: [{ 'test-case': [PASS, SLOW], }] ['variant == foo', { 'test-case': [FAIL], }] The test case "test-case" is marked as slow in all variants. Additionally, in variant foo, it'll be expected to fail. This CL also exemplifies the new feature with test cases running under the ignition_turbofan variant. The corresponding legacy flag is deprecated. BUG=v8:5238 Review-Url: https://codereview.chromium.org/2203013002 Cr-Commit-Position: refs/heads/master@{#38342}
-
- 01 Aug, 2016 1 commit
-
-
machenbach authored
The flag was introduced for ignition development. It can only be used when running ignition tests in isolation on the bots. The bots only use ignition_turbo in isolation since a while and don't pass the --ignition flag anymore. BUG=v8:5238 Review-Url: https://codereview.chromium.org/2197123002 Cr-Commit-Position: refs/heads/master@{#38206}
-
- 22 Jul, 2016 1 commit
-
-
jwolfe authored
See discussion in https://codereview.chromium.org/2156303002/#msg8 With the new --harmony-function-tostring behavior, these tests would fail without this change. This change makes the tests pass regardless of whether or not --harmony-function-tostring is used. All of these changes are simply inserting a space after the "function" keyword to match the current function toString behavior. When --harmony-function-tostring is enabled, the toString behavior matches the spacing used in the function declaration. With the declaration matching the current formatting, the toString behavior becomes unaffected by --harmony-function-tostring. BUG=v8:4958 LOG=n Review-Url: https://codereview.chromium.org/2161413002 Cr-Commit-Position: refs/heads/master@{#37959}
-
- 12 Jul, 2016 2 commits
-
-
mstarzinger authored
R=machenbach@chromium.org Review-Url: https://codereview.chromium.org/2141013002 Cr-Commit-Position: refs/heads/master@{#37678}
-
yangguo authored
R=franzih@chromium.org BUG=chromium:515897 Review-Url: https://codereview.chromium.org/2137033002 Cr-Commit-Position: refs/heads/master@{#37664}
-
- 11 Jul, 2016 1 commit
-
-
jwolfe authored
When the scanner finds a '-->', it's either part of an HTMLCloseComment or a '--' followed by a '>'. Previously, only a preceding newline would make it an HTMLCloseComment. Now, a preceding multiline comment also makes it an HTMLCloseComment. The effect is that now the following is not a SyntaxError: x/* */-->this is now a comment BUG=v8:5142 LOG=y Review-Url: https://codereview.chromium.org/2119763003 Cr-Commit-Position: refs/heads/master@{#37656}
-
- 08 Jul, 2016 1 commit
-
-
yangguo authored
R=bmeurer@chromium.org, mstarzinger@chromium.org, rmcilroy@chromium.org Review-Url: https://codereview.chromium.org/2112853002 Cr-Commit-Position: refs/heads/master@{#37602}
-
- 30 Jun, 2016 1 commit
-
-
littledan authored
Revert of Put RegExp js code in strict mode (patchset #2 id:20001 of https://codereview.chromium.org/1776883005/ ) Reason for revert: Found to break SAP Web IDE, and these semantics are not shipped in any other browser. Revert to legacy semantics while assessing web compatibility. BUG=chromium:624318 Original issue's description: > Put RegExp js code in strict mode > > src/js/regexp.js was one of the few files that was left in sloppy > mode. The ES2017 draft specification requires that writes to > lastIndex throw when the property is non-writable, and test262 > tests enforce this behavior. This patch puts that file in strict > mode. > > BUG=v8:4504 > R=yangguo@chromium.org > LOG=Y > > Committed: https://crrev.com/80b1b2a45bbd9bf3d08e4e6516acfaaa8f438213 > Cr-Commit-Position: refs/heads/master@{#34801} TBR=yangguo@chromium.org,adamk@chromium.org Review-Url: https://codereview.chromium.org/2112713003 Cr-Commit-Position: refs/heads/master@{#37449}
-
- 24 Jun, 2016 1 commit
-
-
adamk authored
Flags removed (all begin with "harmony-"): function-name instanceof iterator-close unicode-regexps regexp-exec regexp-subclass species BUG=v8:3566, v8:3648, v8:3699, v8:4093, v8:4447, v8:4602 Review-Url: https://codereview.chromium.org/2096933002 Cr-Commit-Position: refs/heads/master@{#37235}
-
- 21 Jun, 2016 1 commit
-
-
zhengxing.li authored
BUG= Review-Url: https://codereview.chromium.org/2080693002 Cr-Commit-Position: refs/heads/master@{#37119}
-
- 31 May, 2016 2 commits
-
-
littledan authored
Async functions are built out of generators, but the SharedFunctionInfo returns false for is_generator. is_resumable is the broader query. This patch fixes many parts of V8 to refer to is_resumable as appropriate. One incidental change is to remove a check for generators extending classes. This is part of a general check for constructors being the only thing which can extend classes, so it is removed here and the error message for the general case is made more accurate. BUG=v8:4483 Review-Url: https://codereview.chromium.org/1996943002 Cr-Commit-Position: refs/heads/master@{#36621}
-
yangguo authored
R=bmeurer@chromium.org Review-Url: https://codereview.chromium.org/2026643003 Cr-Commit-Position: refs/heads/master@{#36610}
-
- 27 May, 2016 1 commit
-
-
littledan authored
We now have data that 0.011% of websites use the pattern for (var i = 0 in j) { ... } This pattern was banned by ES2015, with the idea to revisit if it presents a web compatibility problem. Informally, after the May 2016 TC39 meeting, the new data was discussed, and there was interest in reversing the decision. Although the specification is not yet updated, it seems likely to come soon. This patch turns off the flag which bans that construct, reenabling it. The change should prevent websites from breaking. BUG=v8:4942 Review-Url: https://codereview.chromium.org/2011223003 Cr-Commit-Position: refs/heads/master@{#36562}
-
- 11 May, 2016 1 commit
-
-
rmcilroy authored
The previous approach taken by FastNew[Sloppy,Strict,Rest]ArgumentsStub looked at the function slot in order to skip stub frames and find the JS frame. However, stub frames do not have a function slot (in fact their fixed frame ends one slot before the JS frame's function slot). Therefore, if this location in the stub frame happens to have the function object the create arguments stubs won't skip this frame correctly. Replace this approach with one where the stub is specialized to either skip a frame if required (since there will only ever be one extra frame on Ignition the loop approach isn't necessary). BUG=v8:4928 LOG=N CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_nosnap_dbg Review-Url: https://codereview.chromium.org/1949023003 Cr-Commit-Position: refs/heads/master@{#36181}
-
- 02 May, 2016 2 commits
-
-
machenbach authored
BUG=v8:4280 LOG=N TBR=rmcilroy@chromium.org, rmcilroy@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/1934283002 Cr-Commit-Position: refs/heads/master@{#35931}
-
machenbach authored
This adds ignition to the testing variants that are run on all bots. Failing tests can only be skipped with the NO_IGNITION keyword in status files. Existing expectations for the ignition_turbofan variant are all duplicated and use the NO_IGNITION keyword as well now. BUG=v8:4280 LOG=N Committed: https://crrev.com/132c09ed619f23fb7c6d26a4e3552c703389eabd Cr-Commit-Position: refs/heads/master@{#35865} Review-Url: https://codereview.chromium.org/1804003002 Cr-Commit-Position: refs/heads/master@{#35926}
-
- 29 Apr, 2016 1 commit
-
-
machenbach authored
This prepares for pulling chromium's build as dependency for gn. After this, the files in build and gypfiles need to stay in sync until chromium is updated. BUG=chromium:474921 LOG=n Review-Url: https://codereview.chromium.org/1848553003 Cr-Commit-Position: refs/heads/master@{#35898}
-
- 28 Apr, 2016 3 commits
-
-
machenbach authored
Revert of [Ignition] Test ignition on all bots. (patchset #4 id:60001 of https://codereview.chromium.org/1804003002/ ) Reason for revert: Will resubmit with proper fix and more test skips. Original issue's description: > [Ignition] Test ignition on all bots. > > This adds ignition to the testing variants that are run on all > bots. > > Failing tests can only be skipped with the NO_IGNITION > keyword in status files. Existing expectations for the > ignition_turbofan variant are all duplicated and use the > NO_IGNITION keyword as well now. > > BUG=v8:4280 > LOG=N > NOTRY=true TBR=rmcilroy@chromium.org,mstarzinger@chromium.org,yangguo@chromium.org,mythria@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4280 Review-Url: https://codereview.chromium.org/1930943002 Cr-Commit-Position: refs/heads/master@{#35871}
-
rossberg authored
R=hablich@chromium.org BUG=v8:4942 LOG=true Review-Url: https://codereview.chromium.org/1928513004 Cr-Commit-Position: refs/heads/master@{#35868}
-
machenbach authored
This adds ignition to the testing variants that are run on all bots. Failing tests can only be skipped with the NO_IGNITION keyword in status files. Existing expectations for the ignition_turbofan variant are all duplicated and use the NO_IGNITION keyword as well now. BUG=v8:4280 LOG=N NOTRY=true Review-Url: https://codereview.chromium.org/1804003002 Cr-Commit-Position: refs/heads/master@{#35865}
-
- 26 Apr, 2016 1 commit
-
-
machenbach authored
This adds a new ignition_turbofan testing variant that'll allow switching turbofan off in the other ignition variant. The switch will happen in a follow up after reconfiguring the bots. BUG=v8:4280 LOG=N Review URL: https://codereview.chromium.org/1922623003 Cr-Commit-Position: refs/heads/master@{#35790}
-
- 21 Apr, 2016 2 commits
-
-
mstarzinger authored
R=machenbach@chromium.org Review URL: https://codereview.chromium.org/1908503003 Cr-Commit-Position: refs/heads/master@{#35710}
-
machenbach authored
BUG=v8:4928 LOG=n NOTRY=true Review URL: https://codereview.chromium.org/1903043006 Cr-Commit-Position: refs/heads/master@{#35688}
-
- 08 Apr, 2016 2 commits
-
-
machenbach authored
TBR=jyan@ca.ibm.com NOTRY=true Review URL: https://codereview.chromium.org/1871893002 Cr-Commit-Position: refs/heads/master@{#35361}
-
adamk authored
These were all on by default in M49 without complaint. R=littledan@chromium.org Review URL: https://codereview.chromium.org/1858943002 Cr-Commit-Position: refs/heads/master@{#35342}
-
- 04 Apr, 2016 1 commit
-
-
littledan authored
- RegExp.prototype.toString() doesn't have any special handling of RegExp instances and simply calls the source and flags getters - Use the original values of global and sticky, rather than based on the current flag getters, as specified in https://github.com/tc39/ecma262/pull/494 R=yangguo@chromium.org,adamk LOG=Y BUG=v8:4602 Review URL: https://codereview.chromium.org/1846303002 Cr-Commit-Position: refs/heads/master@{#35225}
-
- 01 Apr, 2016 1 commit
-
-
littledan authored
Revert of Remove RegExp.prototype.source getter compat workaround (patchset #2 id:20001 of https://codereview.chromium.org/1837843002/ ) Reason for revert: TC39 decided that this compatibility fix should be standardized. Original issue's description: > Remove RegExp.prototype.source getter compat workaround > > The getter RegExp.prototype.source is specified in ES2015 to throw when > called on a non-RegExp instance, such as RegExp.prototype. We had previously > put in a compatibility workaround for all RegExp getters to make them > throw on access specifically with RegExp.prototype as the receiver; however, > we only have evidence that this is needed for properties other than source. > This patch removes the compatibility workaround for get RegExp.prototype.source > and gives it semantics precisely as per the ES2015 specification. > > R=adamk > BUG=chromium:581577,v8:4827 > LOG=Y > > Committed: https://crrev.com/80803aa89e31839b8f73959776fa7e1923c6b461 > Cr-Commit-Position: refs/heads/master@{#35086} R=adamk@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:581577,v8:4827 LOG=Y Review URL: https://codereview.chromium.org/1847783003 Cr-Commit-Position: refs/heads/master@{#35180}
-
- 28 Mar, 2016 1 commit
-
-
littledan authored
The getter RegExp.prototype.source is specified in ES2015 to throw when called on a non-RegExp instance, such as RegExp.prototype. We had previously put in a compatibility workaround for all RegExp getters to make them throw on access specifically with RegExp.prototype as the receiver; however, we only have evidence that this is needed for properties other than source. This patch removes the compatibility workaround for get RegExp.prototype.source and gives it semantics precisely as per the ES2015 specification. R=adamk BUG=chromium:581577,v8:4827 LOG=Y Review URL: https://codereview.chromium.org/1837843002 Cr-Commit-Position: refs/heads/master@{#35086}
-
- 22 Mar, 2016 2 commits
-
-
adamk authored
Now that ES2015 const has shipped, in Chrome 49, legacy const declarations are no more. This lets us remove a bunch of code from many parts of the codebase. In this patch, I remove parser support for generating legacy const variables from const declarations. This also removes the special "illegal declaration" bit from Scope, which has ripples into all compiler backends. Also gone are any tests which relied on legacy const declarations. Note that we do still generate a Variable in mode CONST_LEGACY in one case: function name bindings in sloppy mode. The likely fix there is to add a new Variable::Kind for this case and handle it appropriately for stores in each backend, but I leave that for a later patch to make this one completely subtractive. Review URL: https://codereview.chromium.org/1819123002 Cr-Commit-Position: refs/heads/master@{#35002}
-
mythria authored
Fixes CopyBytecodeArray to set the interrupt_budget field. BUG=v8:4280,v8:4690 LOG=N Review URL: https://codereview.chromium.org/1809123003 Cr-Commit-Position: refs/heads/master@{#34982}
-
- 21 Mar, 2016 1 commit
-
-
mstarzinger authored
This rebaselines all our internal tests for error messages thrown by the implementation of 'instanceof' to the new ES6 semantics. It also applies a minor rephrasing to the messages in question. R=rossberg@chromium.org BUG=v8:4447 LOG=n Review URL: https://codereview.chromium.org/1822663002 Cr-Commit-Position: refs/heads/master@{#34940}
-
- 18 Mar, 2016 1 commit
-
-
adamk authored
It was never being set to false in production (though it was in test-parsing.cc, due to that test having its own flag-setting logic). Review URL: https://codereview.chromium.org/1815033002 Cr-Commit-Position: refs/heads/master@{#34878}
-
- 16 Mar, 2016 1 commit
-
-
littledan authored
Function declarations were previously permitted by V8 in many locations which no ECMAScript specification allowed; the ECMAScript 2015 spec enumerates a few locations (in blocks, as well as after labels and in conditionals when in sloppy mode). This patch ships the flag to restrict the usage of function declarations to those contexts. R=adamk LOG=Y BUG=v8:4824 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1799233003 Cr-Commit-Position: refs/heads/master@{#34828}
-
- 15 Mar, 2016 2 commits
-
-
littledan authored
src/js/regexp.js was one of the few files that was left in sloppy mode. The ES2017 draft specification requires that writes to lastIndex throw when the property is non-writable, and test262 tests enforce this behavior. This patch puts that file in strict mode. BUG=v8:4504 R=yangguo@chromium.org LOG=Y Review URL: https://codereview.chromium.org/1776883005 Cr-Commit-Position: refs/heads/master@{#34801}
-
machenbach authored
BUG=v8:4280 LOG=n TBR=rmcilroy@chromium.org, mstarzinger@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/1799423004 Cr-Commit-Position: refs/heads/master@{#34772}
-
- 14 Mar, 2016 2 commits
-
-
littledan authored
test262 "negative" test expectations list which exception is thrown. The ES2017 draft specification is very specific about which exception class is thrown from which path, and V8 works hard to be correct with respect to that spec. Previously, the test262 test runner would accept any nonzero status code, such as from a crash, or a FAIL printed out, for a negative test. This patch makes negative tests check for the right answer using a quick-and-dirty parsing of the exception printing from d8 to find the exception class. It invokes d8 in a way to get a status code of 0 from thrown exceptions so that 'negative' tests aren't actually implemented by negating the output. Amazingly, this didn't catch any test262 failures, but I verified the extra checking interactively by changing a negative test to expect a different type and saw it fail. BUG=v8:4803 R=machenbach LOG=Y Review URL: https://codereview.chromium.org/1766503002 Cr-Commit-Position: refs/heads/master@{#34763}
-
mstarzinger authored
This fixes the label binding mechanism that forwards a label to another already bound target label. For source labels that are not being reached by a jump, we should not try to patch jump sites. We still bind the source label to reflect the target position though, just in case this binding method will be used for backwards branches in the future. R=rmcilroy@chromium.org TEST=webkit/fast/js/parser-syntax-check Review URL: https://codereview.chromium.org/1804643002 Cr-Commit-Position: refs/heads/master@{#34759}
-