- 17 Nov, 2021 2 commits
-
-
Maria Tîmbur authored
Use recursion scope only for nullable references in the GenerateRef function. We declare the recursion scope as an optional and only initialize it if the reference type is nullable. Bug: v8:11954, chromium:1270126 Change-Id: I1548290cc9d48167f6fd56ff653744d472f65635 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3284894Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Reviewed-by:
Manos Koukoutos <manoskouk@chromium.org> Commit-Queue: Maria Tîmbur <mtimbur@google.com> Cr-Commit-Position: refs/heads/main@{#77943}
-
Maria Tîmbur authored
Add the numeric conversion logic in ConsumeAndGenerate function. Bug: v8:11954 Change-Id: I24a97dade0485315d21f280a6b99a4d5377f09f7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3260509 Commit-Queue: Maria Tîmbur <mtimbur@google.com> Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Reviewed-by:
Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/main@{#77942}
-
- 16 Nov, 2021 1 commit
-
-
Clemens Backes authored
This CL refactors how the first byte(s) of the input are used to set internal configuration, like which compiler to use and whether Liftoff will be used as reference instead of the interpreter. We now always use exactly one byte, and use it for all internal configuration. If more bits are needed in the future we can either extend to two bytes, or use the same bits for multiple things, while avoiding to lose coverage of all interesting configurations. For now, we use the first byte to derive - which compiler to use per function, - whether to use Liftoff as reference, and - (new) whether to globally enable the mid-tier register allocator. R=thibaudm@chromium.org Bug: v8:12330 Change-Id: I2cae6628554ca8f7e08115015b36f9f0a6b8c34f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3253156 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/main@{#77929}
-
- 05 Nov, 2021 1 commit
-
-
Manos Koukoutos authored
We enable struct.new and array.init initializer expressions in the JS testcase generated by --wasm-fuzzer-gen-test. We needed to make some changes in the WasmInitExpr class, and to implement a new interface for the WasmFullDecoder, which constructs a WasmInitExpr. Changes: - Make WasmInitExpr a ZoneObject. Use a pointer for its operands_ field. This is needed so WasmInitExpr is trivially copiable, and thus usable as a Value type in WasmFullDecoder. - Implement a WasmFullDecoder interface in wasm-fuzzer-common that constructs a WasmInitExpr. Use it to decode initializers in the module generated by the fuzzer. - Change AppendInitExpr to take a WasmInitExpr as argument. - Fix an issue with printing of struct definitions. - Change initializer expression used for structs to struct.new_with_rtt. This is consistent with the currently used structural types. Bug: v8:11954 Change-Id: I65a87cc98701a54f32500be192b3b6eef2ff6c8c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3257712Reviewed-by:
Andreas Haas <ahaas@chromium.org> Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/main@{#77730}
-
- 02 Nov, 2021 2 commits
-
-
Maria Tîmbur authored
Add support for non-nullable reference types. Refactor the GetValueType function. Emit a meaningful initializer for every ref type in globals instead of an empty one. Avoid the non-nullable recursive type by only allowing indices that are strictly less than the current index. Bug: v8:11954 Change-Id: Id1a405525080de7eb9dbbd4f2b8aea5f05684665 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3251171 Commit-Queue: Maria Tîmbur <mtimbur@google.com> Reviewed-by:
Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/main@{#77659}
-
Thibaud Michaud authored
Apply a "modulo" (i32.rem_s) operator to the array size before allocating the array. The unbounded array allocations frequently lead to out-of-memory crashes in the fuzzer. R=manoskouk@chromium.org Bug: chromium:1238063, chromium:1258319 Change-Id: Ie344f783323294c711d75b6e004ff2dca4da5923 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3256548 Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Reviewed-by:
Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/main@{#77657}
-
- 26 Oct, 2021 1 commit
-
-
Maria Tîmbur authored
Add support for immutable arrays. Bug: v8:11954 Change-Id: Ia343247d5fbc960e0e5b1f9b7cb75e734a747d0e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3240827Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Reviewed-by:
Manos Koukoutos <manoskouk@chromium.org> Commit-Queue: Maria Tîmbur <mtimbur@google.com> Cr-Commit-Position: refs/heads/main@{#77541}
-
- 18 Oct, 2021 1 commit
-
-
Maria Tîmbur authored
Change the logic behind GenerateOneOf so that not only ref_null would appear almost everytime. Increase the probability of other alternatives to appear as well. Change the name of GenerateOptRef to GenerateRef. Bug: v8:11954 Change-Id: I8bff1661c3d3a91105bca1ffa68e1e9b0b662240 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3229367 Commit-Queue: Maria Tîmbur <mtimbur@google.com> Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Reviewed-by:
Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/main@{#77438}
-
- 13 Oct, 2021 2 commits
-
-
Manos Koukoutos authored
The purpose of this CL is: - To include all the logic of this function within the bit case switch. - To make it more clear what the probabilities for each generated subtype are. - To fix bugs where anyref fell back to unsupported types in interpreter mode. Bug: v8:11954 Change-Id: Ibc2d487c3fd66ec44a2a4f0eee874c8d3591be52 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3220347Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/main@{#77385}
-
Manos Koukoutos authored
Instead, pass a return parameter to store the error message, if any. Change-Id: Ie71910149271a4268799ee41a8873df51812c505 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3218989 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#77375}
-
- 12 Oct, 2021 1 commit
-
-
Maria Tîmbur authored
We add support for i31.new, i31.get_u and i31.get_s to the fuzzed module. Bug: v8:11954 Change-Id: Ic6cdb5ced1b56507083d91e5c0c7f21d59a18acf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3218980Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Reviewed-by:
Manos Koukoutos <manoskouk@chromium.org> Commit-Queue: Maria Tîmbur <mtimbur@google.com> Cr-Commit-Position: refs/heads/main@{#77354}
-
- 08 Oct, 2021 1 commit
-
-
Manos Koukoutos authored
For debugging purposes, we print the validation error if the module generated by WasmCompileFuzzer fails to validate. Change-Id: I79d2827e489194d02150484ab5a196e979a302af Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3211574Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/main@{#77295}
-
- 07 Oct, 2021 1 commit
-
-
Maria Tîmbur authored
Add support for the i8 and i16 packed types. Because i8 and i16 do not exist as value types we need an i32 to instantiate a packed field. Bug: v8:11954 Change-Id: Ib311fee537c4c9e4aed0ac366172b9b5fb1ee88e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3210267 Commit-Queue: Maria Tîmbur <mtimbur@google.com> Reviewed-by:
Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/main@{#77288}
-
- 04 Oct, 2021 1 commit
-
-
Maria Tîmbur authored
Add the array.get and struct.get functions to GenerateOptRef. Bug: v8:11954 Change-Id: I39b03f909abfd19d89d7d6a76cdef5f0d5219b8e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3197689Reviewed-by:
Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Maria Tîmbur <mtimbur@google.com> Cr-Commit-Position: refs/heads/main@{#77217}
-
- 01 Oct, 2021 1 commit
-
-
Maria Tîmbur authored
When we generate identical signatures in the fuzzer, we generate one function for each of the copies. However, when these functions are added to WasmModulBuilder, all will be assigned the same signature index. Therefore, when ref.func tries to find a function corresponding to a signature index, it will fail, despite a matching signature existing in the module. This CL fixes this issue by looking up functions by signature over signature index. Bug: v8:11954, chromium:1254387 Change-Id: Iac8d5444d4914d993da63d0630ca4d95e671630c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3197711Reviewed-by:
Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Maria Tîmbur <mtimbur@google.com> Cr-Commit-Position: refs/heads/main@{#77187}
-
- 28 Sep, 2021 2 commits
-
-
Maria Tîmbur authored
As now struct and array types are generated arbitrary, struct.set should only pick mutable fields. Bug: v8:11954, chromium:1253031 Change-Id: Ic248e93b09ffefd4f5547e102c8ea4d56bb2bd90 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3186439 Commit-Queue: Maria Tîmbur <mtimbur@google.com> Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Reviewed-by:
Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/main@{#77128}
-
Maria Tîmbur authored
Because there can be fewer function signatures than there are functions a new ForceAddSignature function was added which does not deduplicate. Bug: v8:11954 Change-Id: Ib028de47962dd1e797ead1b1f05a4e6815029487 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3186431 Commit-Queue: Maria Tîmbur <mtimbur@google.com> Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Reviewed-by:
Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/main@{#77126}
-
- 27 Sep, 2021 1 commit
-
-
Ng Zhi An authored
Don't really have a good name for this inner TryCatch. Bug: v8:12244 Change-Id: I4c1353bcd98e78e49d0354e285249302a8ee0dd8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3183522Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/main@{#77097}
-
- 23 Sep, 2021 2 commits
-
-
Maria Tîmbur authored
Generate arbitrary struct and array types based on the fuzzer random input stream. They replace the hard-coded types. Generated types include nested reference types and recursive types. Bug: v8:11954 Change-Id: I2e40697f2ace3eb818360213e8a4dd40037e580e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3173683 Commit-Queue: Maria Tîmbur <mtimbur@google.com> Reviewed-by:
Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/main@{#77010}
-
Thibaud Michaud authored
R=clemensb@chromium.org Bug: chromium:1251465 Change-Id: I09507f1f945252be54c916dcd7ac9e8b7c09643b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3177220Reviewed-by:
Clemens Backes <clemensb@chromium.org> Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/main@{#77009}
-
- 20 Sep, 2021 4 commits
-
-
Rakhim Khismet authored
We add table.copy operation to the fuzzed module. Bug: v8:11954 Change-Id: I7f584335b977ae9bf46f13cb8ddacdcce0824291 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3168275Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Reviewed-by:
Manos Koukoutos <manoskouk@chromium.org> Commit-Queue: Rakhim Khismet <khismet@google.com> Cr-Commit-Position: refs/heads/main@{#76935}
-
Rakhim Khismet authored
Make GetValueType to generate only function signatures to avoid default values in new_object. Bug: v8:11954 Change-Id: Ia6ebdde0a9c10c56afef29d6db3b3266816210e3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3158222Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Rakhim Khismet <khismet@google.com> Cr-Commit-Position: refs/heads/main@{#76934}
-
Maria Tîmbur authored
We add support for array.get, array.set and array.len operation to the fuzzed module. Bug: v8:11954 Change-Id: Ic8fd89ec7f7f31e70a40bad831567e50ae49f668 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3168624Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Reviewed-by:
Manos Koukoutos <manoskouk@chromium.org> Commit-Queue: Maria Tîmbur <mtimbur@google.com> Cr-Commit-Position: refs/heads/main@{#76931}
-
Manos Koukoutos authored
Change-Id: Ie07e626900f8fc8218944be2b33da6fc109adf92 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3168273 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Reviewed-by:
Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/main@{#76930}
-
- 15 Sep, 2021 1 commit
-
-
Jakob Kummerow authored
Per https://github.com/WebAssembly/gc/issues/234, this implements "nominal" type definitions with explicit supertypes, and statically typed RTT-less instructions for allocation and testing/casting. This should be fully backwards compatible with existing Wasm modules. Spec: https://bit.ly/3cWcm6Q ("version 4") Bug: v8:7748 Change-Id: Id5a1399b368fdfad22036cfd66f1bef593e640f7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3144916 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/main@{#76844}
-
- 09 Sep, 2021 1 commit
-
-
Rakhim Khismet authored
We add call_ref and return_call_ref to the fuzzed module. We alter call function to generate call_ref in it. Bug: v8:11954 Change-Id: I972b8e053d7eab758ac343d48f0c4631ef24b22b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3148011Reviewed-by:
Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Rakhim Khismet <khismet@google.com> Cr-Commit-Position: refs/heads/main@{#76748}
-
- 08 Sep, 2021 1 commit
-
-
Thibaud Michaud authored
R=clemensb@chromium.org Bug: v8:8091 Change-Id: I99546c99de2283c1169b299b5ae3cd89298a8a95 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3148134Reviewed-by:
Clemens Backes <clemensb@chromium.org> Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/main@{#76728}
-
- 07 Sep, 2021 1 commit
-
-
Rakhim Khismet authored
We add table operations to the fuzzed module. GetTableType function is added in WasmModuleBuilder. Alter alternatives array in GenerateOptRef to generate less default values. Bug: v8:11954 Change-Id: I433a6fac0ab10307aeede505b7d0c1d625d27477 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3137493Reviewed-by:
Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Rakhim Khismet <khismet@google.com> Cr-Commit-Position: refs/heads/main@{#76697}
-
- 06 Sep, 2021 2 commits
-
-
Manos Koukoutos authored
Bug: v8:11954 Change-Id: I4886109edf5a732736051205076bed78fe78d5e2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3141582 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/main@{#76676}
-
Manos Koukoutos authored
Change-Id: Ib43602065122806e8cecc0fa810888f9d0ff52c8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3141603 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/main@{#76673}
-
- 01 Sep, 2021 1 commit
-
-
Manos Koukoutos authored
This is needed so tables are available for table operations. Bug: v8:11954 Change-Id: If0cbb07ddf0852d2e2515aca3e1f54168c2e0ab8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3135576Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/main@{#76625}
-
- 31 Aug, 2021 2 commits
-
-
Manos Koukoutos authored
WasmModuleBuilder is a class that is used to build Wasm modules in the asm.js parser, in the fuzzer, as well as some tests. When it comes to Wasm tables, WasmModuleBuilder currently supports only basic tables (before the reftypes proposal) using an ad-hoc indirect-function index vector. This CL adds proper support for element sections and tables that use them in the full potential of the reftypes extension. The new functionality will only be used in the fuzzer and potentially some tests in the future. Along this, we drop some functionality from WasmModuleBuilder that was only used in tests and is redundant with the new architecture. Additionally, we remove tables other than externref and funcref from the fuzzer (which were not supported properly or used anyway). We will reintroduce them at a later time. Bug: v8:11954 Change-Id: I0a4f6e7b63b6e3d9f7da03b5202fbf14d8678332 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3122162 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#76597}
-
Milad Fa authored
template specialisations must be defined outside of class body to prevent the following compilation error: error: explicit specialization in non-namespace scope Change-Id: Ic4b74a28cd21d96991ad784fbd3c598668ffc476 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3129881Reviewed-by:
Clemens Backes <clemensb@chromium.org> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/main@{#76591}
-
- 30 Aug, 2021 1 commit
-
-
Clemens Backes authored
The wasm-compile fuzzer sometimes needs to generate a boolean flag from the input bytes. Since the general {DataRange::get} method results in undefined behaviour if instantiated with the {bool} type, we are getting an 8-bit value instead and looking at the least significant bit only. This CL improves this situation by implementing a template specialization for {bool} which uses the same trick, and uses that instead of hand-coding the modulo operation at the call sites. R=manoskouk@chromium.org Bug: v8:11879 Change-Id: I6f9ce02dd8d9cd0998b83e081e4c6ca773e6cb53 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3129429Reviewed-by:
Manos Koukoutos <manoskouk@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#76588}
-
- 27 Aug, 2021 3 commits
-
-
Manos Koukoutos authored
Change-Id: I8ac9f04ce8410f8ca81b1436850cd96ce79a3b6d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3122161 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/main@{#76535}
-
Manos Koukoutos authored
Given ref.func, we might need to wrap any function in the program, as opposed to imported functions only. Change-Id: I79942ef2dabf3b6da2d26b49167db6caff53745e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3122160 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/main@{#76533}
-
Rakhim Khismet authored
We add br.on_null, ref.as_non_null and ref.eq to the fuzzed module. They are called when liftoff is used. ref.is_null has been changed, according to comments from the last CL. GetRefType has been removed. Bug: v8:11954 Change-Id: If93f6e9911cbcd3001ab45da02ebc037af8bdc54 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3122171 Commit-Queue: Rakhim Khismet <khismet@google.com> Reviewed-by:
Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/main@{#76531}
-
- 25 Aug, 2021 3 commits
-
-
Ng Zhi An authored
This function was added (and tests updated) in https://crrev.com/c/2928505. Change-Id: I8e5ab63a832e5689811b09ab624e7f88b1c449b3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3116116Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/main@{#76492}
-
Samuel Groß authored
In a follow-up CL, the backing stores will, when the sandbox is enabled, be referenced from V8 objects through offsets rather than raw pointers. For that to work, all backing stores must be located inside the virtual memory cage. This CL prepares for that. Bug: chromium:1218005 Change-Id: Ibb989626ed7094bd4f02ca15464539f4e2bda90f Cq-Include-Trybots: luci.v8.try:v8_linux64_heap_sandbox_dbg_ng Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3114136 Commit-Queue: Samuel Groß <saelo@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/main@{#76486}
-
Samuel Groß authored
The v8::internal::IsolateData class in test/inspector/isolate-data.h collides with v8::internal::IsolateData defined in src/execution/isolate-data.h. In some circumstances, this can lead to compilation or runtime issues. To fix that, this CL renames the class in test/inspector to InspectorIsolateData. Change-Id: I4b62b2a9d141169480c5a0591c1bcb2f275f87f4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3116248Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Samuel Groß <saelo@chromium.org> Cr-Commit-Position: refs/heads/main@{#76481}
-